linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ia64: disable SCHED_STACK_END_CHECK
@ 2018-09-14  7:06 Sergei Trofimovich
  2018-10-15 19:14 ` Sergei Trofimovich
  0 siblings, 1 reply; 2+ messages in thread
From: Sergei Trofimovich @ 2018-09-14  7:06 UTC (permalink / raw)
  To: Tony Luck
  Cc: Sergei Trofimovich, Fenghua Yu, linux-ia64, Andrew Morton, linux-kernel

SCHED_STACK_END_CHECK assumes stack grows in one direction.
ia64 is a rare case where it is not.

As a result kernel fails at startup as:
  Kernel panic - not syncing: corrupted stack end detected inside scheduler

The error does not find a real problem: it's register backing store
is written on top of canary value.

Disable SCHED_STACK_END_CHECK on ia64 as there is no good
place for canary without moving initial stack address.

CC: Tony Luck <tony.luck@intel.com>
CC: Fenghua Yu <fenghua.yu@intel.com>
CC: linux-ia64@vger.kernel.org
CC: Andrew Morton <akpm@linux-foundation.org>
CC: linux-kernel@vger.kernel.org
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
---
 lib/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 4966c4fbe7f7..a097dfe38d2b 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1004,7 +1004,7 @@ config SCHEDSTATS
 
 config SCHED_STACK_END_CHECK
 	bool "Detect stack corruption on calls to schedule()"
-	depends on DEBUG_KERNEL
+	depends on DEBUG_KERNEL && !IA64
 	default n
 	help
 	  This option checks for a stack overrun on calls to schedule().
-- 
2.19.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ia64: disable SCHED_STACK_END_CHECK
  2018-09-14  7:06 [PATCH] ia64: disable SCHED_STACK_END_CHECK Sergei Trofimovich
@ 2018-10-15 19:14 ` Sergei Trofimovich
  0 siblings, 0 replies; 2+ messages in thread
From: Sergei Trofimovich @ 2018-10-15 19:14 UTC (permalink / raw)
  To: Tony Luck; +Cc: Fenghua Yu, linux-ia64, Andrew Morton, linux-kernel

On Fri, 14 Sep 2018 08:06:17 +0100
Sergei Trofimovich <slyfox@gentoo.org> wrote:

> SCHED_STACK_END_CHECK assumes stack grows in one direction.
> ia64 is a rare case where it is not.
> 
> As a result kernel fails at startup as:
>   Kernel panic - not syncing: corrupted stack end detected inside scheduler
> 
> The error does not find a real problem: it's register backing store
> is written on top of canary value.
> 
> Disable SCHED_STACK_END_CHECK on ia64 as there is no good
> place for canary without moving initial stack address.
> 
> CC: Tony Luck <tony.luck@intel.com>
> CC: Fenghua Yu <fenghua.yu@intel.com>
> CC: linux-ia64@vger.kernel.org
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: linux-kernel@vger.kernel.org
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> ---
>  lib/Kconfig.debug | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 4966c4fbe7f7..a097dfe38d2b 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1004,7 +1004,7 @@ config SCHEDSTATS
>  
>  config SCHED_STACK_END_CHECK
>  	bool "Detect stack corruption on calls to schedule()"
> -	depends on DEBUG_KERNEL
> +	depends on DEBUG_KERNEL && !IA64
>  	default n
>  	help
>  	  This option checks for a stack overrun on calls to schedule().
> -- 
> 2.19.0
> 

Ping.

-- 

  Sergei

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-15 19:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-14  7:06 [PATCH] ia64: disable SCHED_STACK_END_CHECK Sergei Trofimovich
2018-10-15 19:14 ` Sergei Trofimovich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).