From: Borislav Petkov <bp@alien8.de>
To: Manish Narani <manish.narani@xilinx.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, mchehab@kernel.org,
michal.simek@xilinx.com, leoyang.li@nxp.com,
sudeep.holla@arm.com, amit.kucheria@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 1/7] edac: synopsys: Fix code comments and naming convention
Date: Tue, 18 Sep 2018 09:53:11 +0200 [thread overview]
Message-ID: <20180918075311.GB22202@nazgul.tnic> (raw)
In-Reply-To: <1537194305-9243-2-git-send-email-manish.narani@xilinx.com>
On Mon, Sep 17, 2018 at 07:54:59PM +0530, Manish Narani wrote:
> Update the comments in the Synopsys EDAC driver. Minor changes to function
> names and return types are also included.
>
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> ---
> drivers/edac/synopsys_edac.c | 176 ++++++++++++++++++++-----------------------
> 1 file changed, 80 insertions(+), 96 deletions(-)
So this patch does a bunch of things together and should be split into:
* functional changes like code cleanup
* functions renaming
* comments cleanup
Maybe in that order.
This way you'll have one logical set of changes per patch and review
will be almost trivial.
Thx.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2018-09-18 7:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 14:24 [PATCH v7 0/7] EDAC: Enhancements to Synopsys EDAC driver Manish Narani
2018-09-17 14:24 ` [PATCH v7 1/7] edac: synopsys: Fix code comments and naming convention Manish Narani
2018-09-18 7:53 ` Borislav Petkov [this message]
2018-09-19 5:08 ` Manish Narani
2018-09-17 14:25 ` [PATCH v7 2/7] edac: synps: Add platform specific structures for ddrc controller Manish Narani
2018-09-18 7:55 ` Borislav Petkov
2018-09-19 5:14 ` Manish Narani
2018-09-19 11:15 ` Borislav Petkov
2018-09-19 13:33 ` Manish Narani
2018-09-21 9:07 ` Borislav Petkov
2018-09-21 9:15 ` Borislav Petkov
2018-09-24 10:16 ` Manish Narani
2018-09-24 10:07 ` Manish Narani
2018-09-17 14:25 ` [PATCH v7 3/7] dt: bindings: Document ZynqMP DDRC in Synopsys documentation Manish Narani
2018-09-17 14:25 ` [PATCH v7 4/7] edac: synopsys: Add macro defines for ZynqMP DDRC Manish Narani
2018-09-24 9:22 ` Borislav Petkov
2018-09-24 10:29 ` Manish Narani
2018-09-24 10:41 ` Borislav Petkov
2018-09-17 14:25 ` [PATCH v7 5/7] edac: synopsys: Add EDAC ECC support " Manish Narani
2018-09-21 12:56 ` Borislav Petkov
2018-09-24 10:20 ` Manish Narani
2018-09-17 14:25 ` [PATCH v7 6/7] arm64: zynqmp: Add DDRC node Manish Narani
2018-09-21 12:57 ` Borislav Petkov
2018-09-17 14:25 ` [PATCH v7 7/7] edac: synopsys: Add Error Injection support for ZynqMP DDRC Manish Narani
2018-09-24 9:53 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918075311.GB22202@nazgul.tnic \
--to=bp@alien8.de \
--cc=amit.kucheria@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).