From: Manish Narani <MNARANI@xilinx.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
Michal Simek <michals@xilinx.com>,
"leoyang.li@nxp.com" <leoyang.li@nxp.com>,
"sudeep.holla@arm.com" <sudeep.holla@arm.com>,
"amit.kucheria@linaro.org" <amit.kucheria@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v7 2/7] edac: synps: Add platform specific structures for ddrc controller
Date: Wed, 19 Sep 2018 05:14:51 +0000 [thread overview]
Message-ID: <DM6PR02MB5227F5B1B329C903BA64A27CC11C0@DM6PR02MB5227.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20180918075522.GC22202@nazgul.tnic>
Hi Boris,
Thanks for your continuous guidance.
> -----Original Message-----
> From: Borislav Petkov [mailto:bp@alien8.de]
> Sent: Tuesday, September 18, 2018 1:25 PM
> To: Manish Narani <MNARANI@xilinx.com>
> Cc: robh+dt@kernel.org; mark.rutland@arm.com; mchehab@kernel.org;
> Michal Simek <michals@xilinx.com>; leoyang.li@nxp.com;
> sudeep.holla@arm.com; amit.kucheria@linaro.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> edac@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH v7 2/7] edac: synps: Add platform specific structures for
> ddrc controller
>
> On Mon, Sep 17, 2018 at 07:55:00PM +0530, Manish Narani wrote:
> > Add platform specific structures, so that we can add different IP
> > support later using quirks.
> >
> > Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> > ---
> > drivers/edac/synopsys_edac.c | 91
> > +++++++++++++++++++++++++++++++-------------
> > 1 file changed, 65 insertions(+), 26 deletions(-)
>
> ...
>
> > @@ -423,6 +465,7 @@ static void edac_mc_init(struct mem_ctl_info *mci,
> > */
> > static int synps_edac_mc_probe(struct platform_device *pdev) {
> > + const struct synps_platform_data *p_data;
> > struct edac_mc_layer layers[2];
> > struct synps_edac_priv *priv;
> > struct mem_ctl_info *mci;
> > @@ -435,7 +478,8 @@ static int synps_edac_mc_probe(struct
> platform_device *pdev)
> > if (IS_ERR(baseaddr))
> > return PTR_ERR(baseaddr);
> >
> > - if (!edac_get_eccstate(baseaddr)) {
> > + p_data = of_device_get_match_data(&pdev->dev);
> > + if (!(p_data->get_eccstate(baseaddr))) {
>
> From last review round:
>
> "Too many parentheses:
>
> if (!p_data->...
>
> is enough."
>
> So I'm going to stop reviewing this patchset until you go through the old review
> round again and make sure you've incorporated *all* review feedback and
> haven't forgotten some, like the one above.
>
Okay, I will double check again for the comments from previous review and rectify the same in v8. Can you please review the remaining patches so that I can accommodate any changes for them in v8? I regret the inconvenience caused to you in this.
Thanks,
Manish
next prev parent reply other threads:[~2018-09-19 5:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 14:24 [PATCH v7 0/7] EDAC: Enhancements to Synopsys EDAC driver Manish Narani
2018-09-17 14:24 ` [PATCH v7 1/7] edac: synopsys: Fix code comments and naming convention Manish Narani
2018-09-18 7:53 ` Borislav Petkov
2018-09-19 5:08 ` Manish Narani
2018-09-17 14:25 ` [PATCH v7 2/7] edac: synps: Add platform specific structures for ddrc controller Manish Narani
2018-09-18 7:55 ` Borislav Petkov
2018-09-19 5:14 ` Manish Narani [this message]
2018-09-19 11:15 ` Borislav Petkov
2018-09-19 13:33 ` Manish Narani
2018-09-21 9:07 ` Borislav Petkov
2018-09-21 9:15 ` Borislav Petkov
2018-09-24 10:16 ` Manish Narani
2018-09-24 10:07 ` Manish Narani
2018-09-17 14:25 ` [PATCH v7 3/7] dt: bindings: Document ZynqMP DDRC in Synopsys documentation Manish Narani
2018-09-17 14:25 ` [PATCH v7 4/7] edac: synopsys: Add macro defines for ZynqMP DDRC Manish Narani
2018-09-24 9:22 ` Borislav Petkov
2018-09-24 10:29 ` Manish Narani
2018-09-24 10:41 ` Borislav Petkov
2018-09-17 14:25 ` [PATCH v7 5/7] edac: synopsys: Add EDAC ECC support " Manish Narani
2018-09-21 12:56 ` Borislav Petkov
2018-09-24 10:20 ` Manish Narani
2018-09-17 14:25 ` [PATCH v7 6/7] arm64: zynqmp: Add DDRC node Manish Narani
2018-09-21 12:57 ` Borislav Petkov
2018-09-17 14:25 ` [PATCH v7 7/7] edac: synopsys: Add Error Injection support for ZynqMP DDRC Manish Narani
2018-09-24 9:53 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR02MB5227F5B1B329C903BA64A27CC11C0@DM6PR02MB5227.namprd02.prod.outlook.com \
--to=mnarani@xilinx.com \
--cc=amit.kucheria@linaro.org \
--cc=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=michals@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).