From: Manish Narani <MNARANI@xilinx.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
Michal Simek <michals@xilinx.com>,
"leoyang.li@nxp.com" <leoyang.li@nxp.com>,
"sudeep.holla@arm.com" <sudeep.holla@arm.com>,
"amit.kucheria@linaro.org" <amit.kucheria@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v7 2/7] edac: synps: Add platform specific structures for ddrc controller
Date: Mon, 24 Sep 2018 10:07:33 +0000 [thread overview]
Message-ID: <DM6PR02MB5227B76AD2D71C4EABCA48DCC1170@DM6PR02MB5227.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20180921090721.GB30439@nazgul.tnic>
Hi Boris,
Thanks for the review.
> -----Original Message-----
> From: Borislav Petkov [mailto:bp@alien8.de]
> Sent: Friday, September 21, 2018 2:37 PM
> To: Manish Narani <MNARANI@xilinx.com>
> Cc: robh+dt@kernel.org; mark.rutland@arm.com; mchehab@kernel.org;
> Michal Simek <michals@xilinx.com>; leoyang.li@nxp.com;
> sudeep.holla@arm.com; amit.kucheria@linaro.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> edac@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH v7 2/7] edac: synps: Add platform specific structures for
> ddrc controller
>
> On Wed, Sep 19, 2018 at 01:33:58PM +0000, Manish Narani wrote:
> > Apart from this one, I have covered all the comments from the previous
> review.
>
> Are you sure?
>
> Let's see. I said:
>
> | Kill all that "function pointer" fluff. Here's how I've changed it:
> |
> | /**
> | * struct synps_platform_data - synps platform data structure
> | * @edac_geterror_info: edac error info
> | * @edac_get_mtype: get mtype
> | * @edac_get_dtype: get dtype
> | * @edac_get_eccstate: get ECC state
> ^^^^^^^^^^^^^
>
> This is supposed to denote that this function returns whether ECC checking is
> enabled on the controller or not.
>
> Your patch has:
>
> + * struct synps_platform_data - synps platform data structure.
> + * @geterror_info: Get error info.
> + * @get_mtype: Get mtype.
> + * @get_dtype: Get dtype.
> + * @get_eccstate: Get eccstate.
>
> So what is "eccstate"? Is it a struct or a variable or ...?
>
> Do you see my point?
>
> I know, it is a small thing but documenting our code properly is something
> which people would be thanking us for. Even you will be thanking yourself when
> you look at this months from now after having forgotten it all.
>
> Please check the rest of your additions for similar discrepancies.
Okay sure. Will be rectified in v8.
Thanks,
Manish
next prev parent reply other threads:[~2018-09-24 10:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 14:24 [PATCH v7 0/7] EDAC: Enhancements to Synopsys EDAC driver Manish Narani
2018-09-17 14:24 ` [PATCH v7 1/7] edac: synopsys: Fix code comments and naming convention Manish Narani
2018-09-18 7:53 ` Borislav Petkov
2018-09-19 5:08 ` Manish Narani
2018-09-17 14:25 ` [PATCH v7 2/7] edac: synps: Add platform specific structures for ddrc controller Manish Narani
2018-09-18 7:55 ` Borislav Petkov
2018-09-19 5:14 ` Manish Narani
2018-09-19 11:15 ` Borislav Petkov
2018-09-19 13:33 ` Manish Narani
2018-09-21 9:07 ` Borislav Petkov
2018-09-21 9:15 ` Borislav Petkov
2018-09-24 10:16 ` Manish Narani
2018-09-24 10:07 ` Manish Narani [this message]
2018-09-17 14:25 ` [PATCH v7 3/7] dt: bindings: Document ZynqMP DDRC in Synopsys documentation Manish Narani
2018-09-17 14:25 ` [PATCH v7 4/7] edac: synopsys: Add macro defines for ZynqMP DDRC Manish Narani
2018-09-24 9:22 ` Borislav Petkov
2018-09-24 10:29 ` Manish Narani
2018-09-24 10:41 ` Borislav Petkov
2018-09-17 14:25 ` [PATCH v7 5/7] edac: synopsys: Add EDAC ECC support " Manish Narani
2018-09-21 12:56 ` Borislav Petkov
2018-09-24 10:20 ` Manish Narani
2018-09-17 14:25 ` [PATCH v7 6/7] arm64: zynqmp: Add DDRC node Manish Narani
2018-09-21 12:57 ` Borislav Petkov
2018-09-17 14:25 ` [PATCH v7 7/7] edac: synopsys: Add Error Injection support for ZynqMP DDRC Manish Narani
2018-09-24 9:53 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR02MB5227B76AD2D71C4EABCA48DCC1170@DM6PR02MB5227.namprd02.prod.outlook.com \
--to=mnarani@xilinx.com \
--cc=amit.kucheria@linaro.org \
--cc=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=michals@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).