From: kbuild test robot <lkp@intel.com>
To: Dilip Kota <dkota@codeaurora.org>
Cc: kbuild-all@01.org, swboyd@chromium.org, dianders@chromium.org,
broonie@kernel.org, mka@chromium.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Girish Mahadevan <girishm@codeaurora.org>,
Dilip Kota <dkota@codeaurora.org>
Subject: Re: [PATCH V4 3/4] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP
Date: Wed, 19 Sep 2018 08:41:31 +0800 [thread overview]
Message-ID: <201809190813.xn0x079o%fengguang.wu@intel.com> (raw)
In-Reply-To: <1537294047-12093-4-git-send-email-dkota@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 3025 bytes --]
Hi Girish,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on spi/for-next]
[also build test ERROR on v4.19-rc4 next-20180918]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Dilip-Kota/spi-geni-qcom-QUP-SPI-GENI-driver-and-SPI-device-tree-bindings/20180919-043055
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 8.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=xtensa
All errors (new ones prefixed by >>):
drivers/spi/spi-geni-qcom.c: In function 'spi_geni_init':
>> drivers/spi/spi-geni-qcom.c:236:10: error: implicit declaration of function 'GENI_SE_VERSION_MAJOR'; did you mean 'XCHAL_HW_VERSION_MAJOR'? [-Werror=implicit-function-declaration]
major = GENI_SE_VERSION_MAJOR(ver);
^~~~~~~~~~~~~~~~~~~~~
XCHAL_HW_VERSION_MAJOR
>> drivers/spi/spi-geni-qcom.c:237:10: error: implicit declaration of function 'GENI_SE_VERSION_MINOR'; did you mean 'XCHAL_HW_VERSION_MINOR'? [-Werror=implicit-function-declaration]
minor = GENI_SE_VERSION_MINOR(ver);
^~~~~~~~~~~~~~~~~~~~~
XCHAL_HW_VERSION_MINOR
cc1: some warnings being treated as errors
vim +236 drivers/spi/spi-geni-qcom.c
208
209 static int spi_geni_init(struct spi_geni_master *mas)
210 {
211 struct geni_se *se = &mas->se;
212 unsigned int proto, major, minor, ver;
213
214 pm_runtime_get_sync(mas->dev);
215
216 proto = geni_se_read_proto(se);
217 if (proto != GENI_SE_SPI) {
218 dev_err(mas->dev, "Invalid proto %d\n", proto);
219 pm_runtime_put(mas->dev);
220 return -ENXIO;
221 }
222 mas->tx_fifo_depth = geni_se_get_tx_fifo_depth(se);
223 mas->rx_fifo_depth = geni_se_get_rx_fifo_depth(se);
224
225 /* Width of Tx and Rx FIFO is same */
226 mas->fifo_width_bits = geni_se_get_tx_fifo_width(se);
227
228 /*
229 * Hardware programming guide suggests to configure
230 * RX FIFO RFR level to fifo_depth-2.
231 */
232 geni_se_init(se, 0x0, mas->tx_fifo_depth - 2);
233 /* Transmit an entire FIFO worth of data per IRQ */
234 mas->tx_wm = 1;
235 ver = geni_se_get_qup_hw_version(se);
> 236 major = GENI_SE_VERSION_MAJOR(ver);
> 237 minor = GENI_SE_VERSION_MINOR(ver);
238
239 if (major == 1 && minor == 0)
240 mas->oversampling = 2;
241 else
242 mas->oversampling = 1;
243
244 pm_runtime_put(mas->dev);
245 return 0;
246 }
247
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 55176 bytes --]
next prev parent reply other threads:[~2018-09-19 0:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 18:07 [PATCH V4 0/4] spi-geni-qcom: QUP SPI GENI driver and SPI device tree bindings Dilip Kota
2018-09-18 18:07 ` [PATCH V4 1/4] dt-bindings: soc: qcom: Remove SPI controller maximum frequency binding Dilip Kota
2018-09-18 20:11 ` Doug Anderson
2018-09-20 15:38 ` Stephen Boyd
2018-09-26 22:51 ` Rob Herring
2018-09-18 18:07 ` [PATCH V4 2/4] dt-bindings: soc: qcom: GENI SE SPI controller device tree binding Dilip Kota
2018-09-18 20:11 ` Doug Anderson
2018-09-20 15:39 ` Stephen Boyd
2018-09-26 22:51 ` Rob Herring
2018-09-18 18:07 ` [PATCH V4 3/4] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP Dilip Kota
2018-09-18 20:12 ` Doug Anderson
2018-09-19 0:41 ` kbuild test robot [this message]
2018-09-24 16:47 ` Stephen Boyd
2018-09-25 19:36 ` dkota
2018-09-25 19:54 ` Doug Anderson
2018-09-26 18:36 ` dkota
2018-09-18 18:07 ` [PATCH V4 4/4] spi: spi-geni-qcom: Plugin API to assert and de-assert Chipselect Dilip Kota
2018-09-18 20:12 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201809190813.xn0x079o%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=dkota@codeaurora.org \
--cc=girishm@codeaurora.org \
--cc=kbuild-all@01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mka@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).