From: Doug Anderson <dianders@chromium.org>
To: Dilip Kota <dkota@codeaurora.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
Mark Brown <broonie@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH V4 4/4] spi: spi-geni-qcom: Plugin API to assert and de-assert Chipselect
Date: Tue, 18 Sep 2018 13:12:17 -0700 [thread overview]
Message-ID: <CAD=FV=VP5xKY8GSwcsb3WBinb+wn75AL8Z2Z=fWau_KAx7iztQ@mail.gmail.com> (raw)
In-Reply-To: <1537294047-12093-5-git-send-email-dkota@codeaurora.org>
Hi,
On Tue, Sep 18, 2018 at 11:09 AM Dilip Kota <dkota@codeaurora.org> wrote:
>
> Plugin set cs API to the SPI framework so that
> framework can do chipselect assert de-assert
> during SPI transfers.
>
> Signed-off-by: Dilip Kota <dkota@codeaurora.org>
> ---
> drivers/spi/spi-geni-qcom.c | 65 ++++++++++++++++++++++++++++++++-------------
> 1 file changed, 46 insertions(+), 19 deletions(-)
As I mentioned in out-of-band I don't see a huge reason why this can't
be squashed into patch #3. Logically patch #3 has a bug where it
can't handle setting the chip select without a non-zero transfer and
that bug isn't fixed until patch #4. ...but if folks really feel like
it should be a separate patch then I won't object too loudly since the
end result is the same.
...so feel free to add:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
-Doug
prev parent reply other threads:[~2018-09-18 20:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 18:07 [PATCH V4 0/4] spi-geni-qcom: QUP SPI GENI driver and SPI device tree bindings Dilip Kota
2018-09-18 18:07 ` [PATCH V4 1/4] dt-bindings: soc: qcom: Remove SPI controller maximum frequency binding Dilip Kota
2018-09-18 20:11 ` Doug Anderson
2018-09-20 15:38 ` Stephen Boyd
2018-09-26 22:51 ` Rob Herring
2018-09-18 18:07 ` [PATCH V4 2/4] dt-bindings: soc: qcom: GENI SE SPI controller device tree binding Dilip Kota
2018-09-18 20:11 ` Doug Anderson
2018-09-20 15:39 ` Stephen Boyd
2018-09-26 22:51 ` Rob Herring
2018-09-18 18:07 ` [PATCH V4 3/4] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP Dilip Kota
2018-09-18 20:12 ` Doug Anderson
2018-09-19 0:41 ` kbuild test robot
2018-09-24 16:47 ` Stephen Boyd
2018-09-25 19:36 ` dkota
2018-09-25 19:54 ` Doug Anderson
2018-09-26 18:36 ` dkota
2018-09-18 18:07 ` [PATCH V4 4/4] spi: spi-geni-qcom: Plugin API to assert and de-assert Chipselect Dilip Kota
2018-09-18 20:12 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VP5xKY8GSwcsb3WBinb+wn75AL8Z2Z=fWau_KAx7iztQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=broonie@kernel.org \
--cc=dkota@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mka@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).