From: Sebastian Reichel <sre@kernel.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, yuanjiang.yu@unisoc.com,
broonie@kernel.org, ctatlor97@gmail.com,
linus.walleij@linaro.org
Subject: Re: [PATCH v2 3/4] dt-bindings: power: Add Spreadtrum SC27XX fuel gauge unit documentation
Date: Wed, 26 Sep 2018 16:14:08 +0200 [thread overview]
Message-ID: <20180926141408.dumlwnjmbue4nkjm@earth.universe> (raw)
In-Reply-To: <b4b36b7b54cc227e6e7f14c314b4617863a205f5.1537930252.git.baolin.wang@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 2879 bytes --]
Hi,
On Wed, Sep 26, 2018 at 10:59:13AM +0800, Baolin Wang wrote:
> This patch adds the binding documentation for Spreadtrum SC27XX series PMICs
> fuel gauge unit device, which is used to calculate the battery capacity.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
Looks good to me.
-- Sebastian
> Changes from v1:
> - Renamed GPIO property.
> - Use standand battery properties instead of 'sprd,inner-resist' and
> 'sprd,ocv-cap-table'.
> - Remove battery node's description.
> ---
> .../devicetree/bindings/power/supply/sc27xx-fg.txt | 52 ++++++++++++++++++++
> 1 file changed, 52 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/sc27xx-fg.txt
>
> diff --git a/Documentation/devicetree/bindings/power/supply/sc27xx-fg.txt b/Documentation/devicetree/bindings/power/supply/sc27xx-fg.txt
> new file mode 100644
> index 0000000..b161468
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/sc27xx-fg.txt
> @@ -0,0 +1,52 @@
> +Spreadtrum SC27XX PMICs Fuel Gauge Unit Power Supply Bindings
> +
> +Required properties:
> +- compatible: Should be one of the following:
> + "sprd,sc2720-fgu",
> + "sprd,sc2721-fgu",
> + "sprd,sc2723-fgu",
> + "sprd,sc2730-fgu",
> + "sprd,sc2731-fgu".
> +- reg: The address offset of fuel gauge unit.
> +- battery-detect-gpios: GPIO for battery detection.
> +- io-channels: Specify the IIO ADC channel to get temperature.
> +- io-channel-names: Should be "bat-temp".
> +- monitored-battery: Phandle of battery characteristics devicetree node.
> + See Documentation/devicetree/bindings/power/supply/battery.txt
> +
> +Example:
> +
> + bat: battery {
> + compatible = "simple-battery";
> + charge-full-design-microamp-hours = <1900000>;
> + constant-charge-voltage-max-microvolt = <4350000>;
> + ocv-capacity-table-temperatures = <20>;
> + ocv-capacity-table-0 = <4185000 100>, <4113000 95>, <4066000 90>,
> + <4022000 85>, <3983000 80>, <3949000 75>,
> + <3917000 70>, <3889000 65>, <3864000 60>,
> + <3835000 55>, <3805000 50>, <3787000 45>,
> + <3777000 40>, <3773000 35>, <3770000 30>,
> + <3765000 25>, <3752000 20>, <3724000 15>,
> + <3680000 10>, <3605000 5>, <3400000 0>;
> + ......
> + };
> +
> + sc2731_pmic: pmic@0 {
> + compatible = "sprd,sc2731";
> + reg = <0>;
> + spi-max-frequency = <26000000>;
> + interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + fgu@a00 {
> + compatible = "sprd,sc2731-fgu";
> + reg = <0xa00>;
> + battery-detect-gpios = <&pmic_eic 9 GPIO_ACTIVE_HIGH>;
> + io-channels = <&pmic_adc 5>;
> + io-channel-names = "bat-temp";
> + monitored-battery = <&bat>;
> + };
> + };
> --
> 1.7.9.5
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-09-26 14:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 2:59 [PATCH v2 1/4] power: supply: core: Introduce one property to present the battery internal resistance Baolin Wang
2018-09-26 2:59 ` [PATCH v2 2/4] power: supply: core: Introduce properties to present the battery OCV table Baolin Wang
2018-09-26 8:02 ` Linus Walleij
2018-09-26 13:51 ` Sebastian Reichel
2018-09-27 1:10 ` Baolin Wang
2018-09-27 6:40 ` Sebastian Reichel
2018-09-26 2:59 ` [PATCH v2 3/4] dt-bindings: power: Add Spreadtrum SC27XX fuel gauge unit documentation Baolin Wang
2018-09-26 8:04 ` Linus Walleij
2018-09-26 14:14 ` Sebastian Reichel [this message]
2018-09-26 2:59 ` [PATCH v2 4/4] power: supply: Add Spreadtrum SC27XX fuel gauge unit driver Baolin Wang
2018-09-26 8:09 ` Linus Walleij
2018-09-26 8:33 ` Baolin Wang
2018-09-26 15:30 ` Sebastian Reichel
2018-09-27 5:17 ` Baolin Wang
2018-09-26 8:00 ` [PATCH v2 1/4] power: supply: core: Introduce one property to present the battery internal resistance Linus Walleij
2018-09-26 8:30 ` Baolin Wang
2018-09-26 12:45 ` Sebastian Reichel
2018-09-27 1:06 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926141408.dumlwnjmbue4nkjm@earth.universe \
--to=sre@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=ctatlor97@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=yuanjiang.yu@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).