From: Sebastian Reichel <sre@kernel.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linux PM list <linux-pm@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
yuanjiang.yu@unisoc.com, Mark Brown <broonie@kernel.org>,
Craig Tatlor <ctatlor97@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 2/4] power: supply: core: Introduce properties to present the battery OCV table
Date: Thu, 27 Sep 2018 08:40:47 +0200 [thread overview]
Message-ID: <20180927064047.gjxg5ikbrdgbc54u@earth.universe> (raw)
In-Reply-To: <CAMz4kuK0PGonikK=pH50p=7NFXZHRuMZ+Aq9ZYT+8q8giKZCAQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
Hi,
On Thu, Sep 27, 2018 at 09:10:05AM +0800, Baolin Wang wrote:
> On 26 September 2018 at 21:51, Sebastian Reichel <sre@kernel.org> wrote:
> > Looks good to me. Technically this can result in existing users of
> > power_supply_get_battery_info leaking memory, if they have an OCV
> > table in DT.
>
> Fortunately existing users did not have an OCV table.
Right. I was just talking about potential memory leak, if the DT
file of these boards has the OCV table defined. I don't think
that this will be a problem in real life.
> Moreover once this patch merged, I will send patches to add
> power_supply_put_battery_info() for existing users of battery
> info.
Thanks.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-09-27 6:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 2:59 [PATCH v2 1/4] power: supply: core: Introduce one property to present the battery internal resistance Baolin Wang
2018-09-26 2:59 ` [PATCH v2 2/4] power: supply: core: Introduce properties to present the battery OCV table Baolin Wang
2018-09-26 8:02 ` Linus Walleij
2018-09-26 13:51 ` Sebastian Reichel
2018-09-27 1:10 ` Baolin Wang
2018-09-27 6:40 ` Sebastian Reichel [this message]
2018-09-26 2:59 ` [PATCH v2 3/4] dt-bindings: power: Add Spreadtrum SC27XX fuel gauge unit documentation Baolin Wang
2018-09-26 8:04 ` Linus Walleij
2018-09-26 14:14 ` Sebastian Reichel
2018-09-26 2:59 ` [PATCH v2 4/4] power: supply: Add Spreadtrum SC27XX fuel gauge unit driver Baolin Wang
2018-09-26 8:09 ` Linus Walleij
2018-09-26 8:33 ` Baolin Wang
2018-09-26 15:30 ` Sebastian Reichel
2018-09-27 5:17 ` Baolin Wang
2018-09-26 8:00 ` [PATCH v2 1/4] power: supply: core: Introduce one property to present the battery internal resistance Linus Walleij
2018-09-26 8:30 ` Baolin Wang
2018-09-26 12:45 ` Sebastian Reichel
2018-09-27 1:06 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927064047.gjxg5ikbrdgbc54u@earth.universe \
--to=sre@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=ctatlor97@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=yuanjiang.yu@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).