From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org,
dave.hansen@intel.com, sean.j.christopherson@intel.com,
nhorman@redhat.com, npmccallum@redhat.com, serge.ayoun@intel.com,
shay.katz-zamir@intel.com, linux-sgx@vger.kernel.org,
andriy.shevchenko@linux.intel.com,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"David Woodhouse" <dwmw@amazon.co.uk>,
"David Wang" <davidwang@zhaoxin.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>,
"Jia Zhang" <qianyue.zj@alibaba-inc.com>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@vger.kernel.org>,
"He Chen" <he.chen@linux.intel.com>,
"Luwei Kang" <luwei.kang@intel.com>,
kvm@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>,
"Piotr Luc" <Piotr.Luc@intel.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v14 04/19] x86/cpufeatures: Add SGX feature bits
Date: Thu, 27 Sep 2018 17:52:38 +0300 [thread overview]
Message-ID: <20180927145238.GA9769@linux.intel.com> (raw)
In-Reply-To: <20180927135139.GB19687@zn.tnic>
On Thu, Sep 27, 2018 at 03:51:39PM +0200, Borislav Petkov wrote:
> On Thu, Sep 27, 2018 at 04:16:42PM +0300, Jarkko Sakkinen wrote:
> > Still kind of leaves me puzzled about the situation :-) Why this wasn't
> > used for example to replace detect_vmx_virtcap()?
>
> I don't understand - detect_vmx_virtcap() is setting X86_FEATURE bits
> based on MSR settings. get_scattered_cpuid_leaf() is regenerating a
> CPUID leaf from the scattered bits.
>
> Looks like apples and oranges to me...
>
> --
> Regards/Gruss,
> Boris.
>
> Good mailing practices for 400: avoid top-posting and trim the reply.
Ugh, sorry, I was not thinking clearly :-)
/Jarkko
next prev parent reply other threads:[~2018-09-27 14:52 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 13:06 [PATCH v14 00/19] Intel SGX1 support Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 01/19] x86/sgx: Update MAINTAINERS Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 02/19] x86/sgx: Architectural structures Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 03/19] x86/cpufeature: Add SGX and SGX_LC CPU features Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 04/19] x86/cpufeatures: Add SGX feature bits Jarkko Sakkinen
2018-09-25 16:48 ` Borislav Petkov
2018-09-26 11:11 ` Jarkko Sakkinen
2018-09-26 11:36 ` Borislav Petkov
2018-09-27 13:16 ` Jarkko Sakkinen
2018-09-27 13:51 ` Borislav Petkov
2018-09-27 14:52 ` Jarkko Sakkinen [this message]
2018-09-25 13:06 ` [PATCH v14 05/19] x86/msr: Add SGX definitions to msr-index.h Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 06/19] x86/mm: x86/sgx: Add new 'PF_SGX' page fault error code bit Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 07/19] x86/fault: x86/mm/pkeys: relocate stale comment regarding OSPKE Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 08/19] signal: x86/sgx: Add SIGSEGV siginfo code for SGX EPCM fault Jarkko Sakkinen
2018-09-26 19:14 ` Sean Christopherson
2018-09-27 18:41 ` Eric W. Biederman
2018-09-25 13:06 ` [PATCH v14 09/19] x86/mm: x86/sgx: Signal SEGV_SGXERR for #PFs w/ PF_SGX Jarkko Sakkinen
2018-09-25 22:53 ` Andy Lutomirski
2018-09-26 17:35 ` Sean Christopherson
2018-09-26 18:12 ` Andy Lutomirski
2018-09-26 20:16 ` Dave Hansen
2018-09-26 20:44 ` Sean Christopherson
2018-09-26 20:49 ` Dave Hansen
2018-09-26 21:15 ` Andy Lutomirski
2018-09-26 21:45 ` Dave Hansen
2018-09-26 22:37 ` Andy Lutomirski
2018-09-27 14:21 ` Jarkko Sakkinen
2018-09-27 14:41 ` Andy Lutomirski
2018-09-27 13:56 ` Jarkko Sakkinen
2018-10-01 21:42 ` Jethro Beekman
2018-10-01 22:03 ` Dave Hansen
2018-10-31 21:30 ` Sean Christopherson
2018-10-31 21:35 ` Dave Hansen
2018-11-01 17:42 ` Jarkko Sakkinen
2018-11-01 17:44 ` Jarkko Sakkinen
2018-10-02 0:31 ` Jarkko Sakkinen
2018-10-01 14:29 ` Sean Christopherson
2018-10-01 14:41 ` Dave Hansen
2018-10-02 0:07 ` Jarkko Sakkinen
2018-09-27 13:42 ` Jarkko Sakkinen
2018-09-27 14:58 ` Dave Hansen
2018-09-27 15:39 ` Jarkko Sakkinen
2018-09-27 15:53 ` Dave Hansen
2018-09-27 13:14 ` Jarkko Sakkinen
2018-09-27 19:43 ` Eric W. Biederman
2018-09-28 12:17 ` Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 10/19] x86/sgx: Detect Intel SGX Jarkko Sakkinen
2018-09-25 20:02 ` Randy Dunlap
2018-09-27 13:13 ` Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 11/19] x86/sgx: Add wrappers for ENCLS leaf functions Jarkko Sakkinen
2018-09-25 20:01 ` Randy Dunlap
2018-09-27 13:12 ` Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 12/19] x86/sgx: Add data structures for tracking the EPC pages Jarkko Sakkinen
2018-09-25 20:00 ` Randy Dunlap
2018-09-27 13:11 ` Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 13/19] x86/sgx: Enclave Page Cache (EPC) memory manager Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 14/19] x86/sgx: Add sgx_einit() for initializing enclaves Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 15/19] platform/x86: Intel SGX driver Jarkko Sakkinen
2018-10-04 18:01 ` Sean Christopherson
2018-10-05 11:32 ` Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 16/19] platform/x86: Add swapping functionality to the " Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 17/19] x86/sgx: Add a simple swapper for the EPC memory manager Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 18/19] platform/x86: ptrace() support for the SGX driver Jarkko Sakkinen
2018-09-25 13:06 ` [PATCH v14 19/19] x86/sgx: Driver documentation Jarkko Sakkinen
2018-09-25 13:27 ` Jonathan Corbet
2018-10-15 20:54 ` Pavel Machek
2018-10-17 23:45 ` Jarkko Sakkinen
2018-10-18 9:57 ` Pavel Machek
2018-10-19 23:59 ` Jarkko Sakkinen
2018-10-17 23:56 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927145238.GA9769@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Piotr.Luc@intel.com \
--cc=alexander.levin@verizon.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=davidwang@zhaoxin.com \
--cc=dwmw@amazon.co.uk \
--cc=he.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=luwei.kang@intel.com \
--cc=mingo@redhat.com \
--cc=nhorman@redhat.com \
--cc=npmccallum@redhat.com \
--cc=pbonzini@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qianyue.zj@alibaba-inc.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=serge.ayoun@intel.com \
--cc=shay.katz-zamir@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).