* [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command
@ 2018-09-27 1:41 Leonardo Brás
2018-09-27 6:34 ` Rolf Eike Beer
0 siblings, 1 reply; 6+ messages in thread
From: Leonardo Brás @ 2018-09-27 1:41 UTC (permalink / raw)
To: lkcamp
Cc: Alexander Shishkin, Finn Thain, Robert Richter,
James E.J. Bottomley, Helge Deller, Martin Schwidefsky,
Heiko Carstens, Geert Uytterhoeven, linux-kernel, linux-m68k,
oprofile-list, linux-parisc, linux-s390
Creates new Makefile to avoid building driver if
'make drivers/oprofile/' is called directly.
This driver is usually built from arch/$ARCH and seems to have
no meaning building alone.
Signed-off-by: Leonardo Brás <leobras.c@gmail.com>
---
drivers/oprofile/Makefile | 2 ++
1 file changed, 2 insertions(+)
create mode 100644 drivers/oprofile/Makefile
diff --git a/drivers/oprofile/Makefile b/drivers/oprofile/Makefile
new file mode 100644
index 000000000000..acaed2ad6eee
--- /dev/null
+++ b/drivers/oprofile/Makefile
@@ -0,0 +1,2 @@
+#Does nothing, since the source is called from arch/$ARCH/ tree.
+
--
2.19.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command
2018-09-27 1:41 [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command Leonardo Brás
@ 2018-09-27 6:34 ` Rolf Eike Beer
2018-09-27 11:23 ` Leonardo Bras
0 siblings, 1 reply; 6+ messages in thread
From: Rolf Eike Beer @ 2018-09-27 6:34 UTC (permalink / raw)
To: Leonardo Brás, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
Am Donnerstag, 27. September 2018, 03:41:38 CEST schrieb Leonardo Brás:
> Creates new Makefile to avoid building driver if
> 'make drivers/oprofile/' is called directly.
>
> This driver is usually built from arch/$ARCH and seems to have
> no meaning building alone.
>
> Signed-off-by: Leonardo Brás <leobras.c@gmail.com>
> ---
> drivers/oprofile/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
> create mode 100644 drivers/oprofile/Makefile
>
> diff --git a/drivers/oprofile/Makefile b/drivers/oprofile/Makefile
> new file mode 100644
> index 000000000000..acaed2ad6eee
> --- /dev/null
> +++ b/drivers/oprofile/Makefile
> @@ -0,0 +1,2 @@
> +#Does nothing, since the source is called from arch/$ARCH/ tree.
> +
Now there is a blank line where it does not need to be.
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command
2018-09-27 6:34 ` Rolf Eike Beer
@ 2018-09-27 11:23 ` Leonardo Bras
2018-09-27 13:14 ` Rolf Eike Beer
0 siblings, 1 reply; 6+ messages in thread
From: Leonardo Bras @ 2018-09-27 11:23 UTC (permalink / raw)
To: Rolf Eike Beer; +Cc: linux-kernel
Hello Rolf,
On Thu, Sep 27, 2018 at 3:34 AM, Rolf Eike Beer <eike-kernel@sf-tec.de> wrote:
> Am Donnerstag, 27. September 2018, 03:41:38 CEST schrieb Leonardo Brás:
>> Creates new Makefile to avoid building driver if
>> 'make drivers/oprofile/' is called directly.
>>
>> This driver is usually built from arch/$ARCH and seems to have
>> no meaning building alone.
>>
>> Signed-off-by: Leonardo Brás <leobras.c@gmail.com>
>> ---
>> drivers/oprofile/Makefile | 2 ++
>> 1 file changed, 2 insertions(+)
>> create mode 100644 drivers/oprofile/Makefile
>>
>> diff --git a/drivers/oprofile/Makefile b/drivers/oprofile/Makefile
>> new file mode 100644
>> index 000000000000..acaed2ad6eee
>> --- /dev/null
>> +++ b/drivers/oprofile/Makefile
>> @@ -0,0 +1,2 @@
>> +#Does nothing, since the source is called from arch/$ARCH/ tree.
>> +
>
> Now there is a blank line where it does not need to be.
>
> Eike
Oh, it's a Makefile, and as all text files, it have to end with newline.
If I am wrong, please let me know.
Thanks for your feedback,
Leonardo Bras,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command
2018-09-27 11:23 ` Leonardo Bras
@ 2018-09-27 13:14 ` Rolf Eike Beer
2018-09-28 1:32 ` Leonardo Brás
2018-09-28 1:55 ` Leonardo Brás
0 siblings, 2 replies; 6+ messages in thread
From: Rolf Eike Beer @ 2018-09-27 13:14 UTC (permalink / raw)
To: Leonardo Bras; +Cc: linux-kernel
Am 2018-09-27 13:23, schrieb Leonardo Bras:
> Hello Rolf,
>
> On Thu, Sep 27, 2018 at 3:34 AM, Rolf Eike Beer <eike-kernel@sf-tec.de>
> wrote:
>> Am Donnerstag, 27. September 2018, 03:41:38 CEST schrieb Leonardo
>> Brás:
>>> Creates new Makefile to avoid building driver if
>>> 'make drivers/oprofile/' is called directly.
>>>
>>> This driver is usually built from arch/$ARCH and seems to have
>>> no meaning building alone.
>>>
>>> Signed-off-by: Leonardo Brás <leobras.c@gmail.com>
>>> ---
>>> drivers/oprofile/Makefile | 2 ++
>>> 1 file changed, 2 insertions(+)
>>> create mode 100644 drivers/oprofile/Makefile
>>>
>>> diff --git a/drivers/oprofile/Makefile b/drivers/oprofile/Makefile
>>> new file mode 100644
>>> index 000000000000..acaed2ad6eee
>>> --- /dev/null
>>> +++ b/drivers/oprofile/Makefile
>>> @@ -0,0 +1,2 @@
>>> +#Does nothing, since the source is called from arch/$ARCH/ tree.
>>> +
>>
>> Now there is a blank line where it does not need to be.
>>
>> Eike
>
> Oh, it's a Makefile, and as all text files, it have to end with
> newline.
> If I am wrong, please let me know.
No, that's fine. But it means it has to have one LF after "tree.". It
had none, now it hat 2.
Eike
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command
2018-09-27 13:14 ` Rolf Eike Beer
@ 2018-09-28 1:32 ` Leonardo Brás
2018-09-28 1:55 ` Leonardo Brás
1 sibling, 0 replies; 6+ messages in thread
From: Leonardo Brás @ 2018-09-28 1:32 UTC (permalink / raw)
To: Rolf Eike Beer; +Cc: linux-kernel
Hello Eike,
> No, that's fine. But it means it has to have one LF after "tree.". It had
> none, now it hat 2.
>
> Eike
Oh, i haven't noticed. Sorry for the trouble.
Thanks for the feedback!
Leonardo Brás
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command
2018-09-27 13:14 ` Rolf Eike Beer
2018-09-28 1:32 ` Leonardo Brás
@ 2018-09-28 1:55 ` Leonardo Brás
1 sibling, 0 replies; 6+ messages in thread
From: Leonardo Brás @ 2018-09-28 1:55 UTC (permalink / raw)
To: Rolf Eike Beer; +Cc: linux-kernel
Hello Eike,
> > Oh, it's a Makefile, and as all text files, it have to end with newline.
> > If I am wrong, please let me know.
>
> No, that's fine. But it means it has to have one LF after "tree.". It had
> none, now it hat 2.
>
> Eike
Oh, i haven't noticed. Sorry for the trouble.
Thanks for the feedback!
Leonardo Bras
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-28 1:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-27 1:41 [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command Leonardo Brás
2018-09-27 6:34 ` Rolf Eike Beer
2018-09-27 11:23 ` Leonardo Bras
2018-09-27 13:14 ` Rolf Eike Beer
2018-09-28 1:32 ` Leonardo Brás
2018-09-28 1:55 ` Leonardo Brás
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).