linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: clock: add description of 74aup1g157gw
Date: Wed, 17 Oct 2018 11:05:56 -0500	[thread overview]
Message-ID: <20181017160556.GA14935@bogus> (raw)
In-Reply-To: <87d0si1rkt.wl-kuninori.morimoto.gx@renesas.com>

On Wed, Oct 10, 2018 at 02:16:35AM +0000, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> 74aup1g157gw needs i0 and i1 pin as input, select and output it by
> sel gpio pin. This patch adds description for 74aup1g157gw as clock
> multiplexer.
> "nxp,74aup1g157gw-clk" will select most closest input as output,
> "nxp,74aup1g157gw-audio-clk" will select 48kHz/44.1kHz categorized
> input as output.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  .../devicetree/bindings/clock/nxp,74aup1g157gw.txt    | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/nxp,74aup1g157gw.txt
> 
> diff --git a/Documentation/devicetree/bindings/clock/nxp,74aup1g157gw.txt b/Documentation/devicetree/bindings/clock/nxp,74aup1g157gw.txt
> new file mode 100644
> index 0000000..d07bc04
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/nxp,74aup1g157gw.txt
> @@ -0,0 +1,19 @@
> +NXP 74AUP1G157GW Low-power 2-input multiplexer for clock
> +
> +Required properties:
> +- compatible:	"nxp,74aup1g157gw-clk"      (select closest input as output)
> +		"nxp,74aup1g157gw-audio-clk (select 48kHz / 44.1kHz as output)

I don't understand why you need the second one.


What's wrong with the existing gpio-mux-clock binding?

> +- clocks:	select input clock as i0, i1
> +- clock-names:	"i0" and "i1"
> +- sel-gpios:	selector pin
> +
> +Examples:
> +
> +	clk {
> +		#clock-cells = <0>;
> +		compatible = "nxp,74aup1g157gw-audio-clk";
> +		clocks = <&clk8snd>, <&clksnd>;
> +		clock-names = "i0", "i1";
> +		sel-gpios = <&gpio_exp_75 13 GPIO_ACTIVE_HIGH>;
> +	};
> +
> -- 
> 2.7.4
> 

  reply	other threads:[~2018-10-17 16:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10  2:15 [PATCH 0/2] add 74aup1g157gw 2-input multiplexer as clock driver Kuninori Morimoto
2018-10-10  2:16 ` [PATCH 1/2] dt-bindings: clock: add description of 74aup1g157gw Kuninori Morimoto
2018-10-17 16:05   ` Rob Herring [this message]
2018-10-18  0:15     ` Kuninori Morimoto
2018-10-10  2:16 ` [PATCH 2/2] clk: add 74aup1g157gw 2-input multiplexer as clock driver Kuninori Morimoto
2018-10-11  6:39   ` Stephen Boyd
2018-10-12  0:37     ` Kuninori Morimoto
2018-10-12 16:06       ` Stephen Boyd
2018-10-14 23:53         ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181017160556.GA14935@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --subject='Re: [PATCH 1/2] dt-bindings: clock: add description of 74aup1g157gw' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).