linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sven Van Asbroeck <svendev@arcx.com>
Cc: lee.jones@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
	afaerber@suse.de, treding@nvidia.com, david@lechnology.com,
	noralf@tronnes.org, johan@kernel.org, monstr@monstr.eu,
	michal.vokac@ysoft.com, arnd@arndb.de,
	gregkh@linuxfoundation.org, john.garry@huawei.com,
	geert+renesas@glider.be, robin.murphy@arm.com,
	paul.gortmaker@windriver.com,
	sebastien.bourdelin@savoirfairelinux.com, icenowy@aosc.io,
	yuanzhichang@hisilicon.com, stuyoder@gmail.com,
	linus.walleij@linaro.org, maxime.ripard@bootlin.com,
	bogdan.purcareata@nxp.com, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH anybus v1 0/4] Support HMS Profinet Card over Anybus
Date: Thu, 25 Oct 2018 12:18:36 +0300	[thread overview]
Message-ID: <20181025091836.GV10650@smile.fi.intel.com> (raw)
In-Reply-To: <20181024142456.10084-1-svendev@arcx.com>

On Wed, Oct 24, 2018 at 10:24:52AM -0400, Sven Van Asbroeck wrote:
> This patch set adds support for the HMS Industrial Networks AB Profinet card.
> 
> Profinet is an industry technical standard for data communication over
> Industrial Ethernet, designed for collecting data from, and controlling,
> equipment in industrial systems, with a particular strength in delivering data
> under tight time constraints (on the order of 1ms or less).
> 
> The profinet card itself is connected to the system via an industrial bus
> called 'anybus'.
> 
> I have followed the bus driver/client driver pattern, and created an anybus
> bus driver, plus a client driver for the profinet card.
> 
> In case this patch set gets (eventually) accepted, drivers for other anybus
> client cards may follow: flnet, cc-link, ...
> 
> The anybus slot on the host is located on an 'anybus bridge', which is
> custom h/w designed by Arcx. Its driver is modeled as an mfd, which
> instantiates two anybus slots.

I highly recommend to look at my recent (for few month?) reviews -- they are
almost repeating each other.

Also check what we have under lib/ (hint: read linux/kernel.h for inline and
exported function helpers).

I might look at the patches later on if I would have some spare time (I
actually don't know why I'm in Cc list here).

> 
> v1:
> 	first shot
> 
> Sven Van Asbroeck (4):
>   mfd: support the Arcx anybus bridge.
>   dt-bindings: anybus-bridge: document devicetree binding.
>   bus: support HMS Anybus-S bus.
>   misc: support HMS Profinet IRT industrial controller.
> 
>  .../bindings/mfd/arcx,anybus-bridge.txt       |   37 +
>  .../devicetree/bindings/vendor-prefixes.txt   |    1 +
>  drivers/bus/Kconfig                           |   11 +
>  drivers/bus/Makefile                          |    1 +
>  drivers/bus/anybuss-host.c                    | 1301 +++++++++++++++++
>  drivers/mfd/Kconfig                           |   11 +
>  drivers/mfd/Makefile                          |    1 +
>  drivers/mfd/anybus-bridge.c                   |  441 ++++++
>  drivers/misc/Kconfig                          |   11 +
>  drivers/misc/Makefile                         |    1 +
>  drivers/misc/hms-profinet.c                   |  747 ++++++++++
>  include/linux/anybuss-client.h                |  100 ++
>  include/linux/anybuss-host.h                  |   28 +
>  include/uapi/linux/hms-common.h               |   14 +
>  include/uapi/linux/hms-profinet.h             |  101 ++
>  15 files changed, 2806 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/arcx,anybus-bridge.txt
>  create mode 100644 drivers/bus/anybuss-host.c
>  create mode 100644 drivers/mfd/anybus-bridge.c
>  create mode 100644 drivers/misc/hms-profinet.c
>  create mode 100644 include/linux/anybuss-client.h
>  create mode 100644 include/linux/anybuss-host.h
>  create mode 100644 include/uapi/linux/hms-common.h
>  create mode 100644 include/uapi/linux/hms-profinet.h
> 
> -- 
> 2.17.1
> 

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2018-10-25  9:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24 14:24 Sven Van Asbroeck
2018-10-24 14:24 ` [PATCH anybus v1 1/4] mfd: support the Arcx anybus bridge Sven Van Asbroeck
2018-10-24 15:58   ` Randy Dunlap
2018-10-26  8:34   ` Lee Jones
2018-10-26 13:40     ` Sven Van Asbroeck
2018-10-24 14:24 ` [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding Sven Van Asbroeck
2018-10-25  0:06   ` Rob Herring
2018-10-25  5:19   ` Lee Jones
2018-10-25 10:16   ` Linus Walleij
2018-10-24 14:24 ` [PATCH anybus v1 3/4] bus: support HMS Anybus-S bus Sven Van Asbroeck
2018-10-24 15:58   ` Randy Dunlap
2018-10-25 11:08   ` Linus Walleij
2018-10-24 14:24 ` [PATCH anybus v1 4/4] misc: support HMS Profinet IRT industrial controller Sven Van Asbroeck
2018-10-24 15:58   ` Randy Dunlap
2018-10-25  9:18 ` Andy Shevchenko [this message]
2018-11-05 14:49   ` [PATCH anybus v1 0/4] Support HMS Profinet Card over Anybus Sven Van Asbroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025091836.GV10650@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=afaerber@suse.de \
    --cc=arnd@arndb.de \
    --cc=bogdan.purcareata@nxp.com \
    --cc=david@lechnology.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=icenowy@aosc.io \
    --cc=johan@kernel.org \
    --cc=john.garry@huawei.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=michal.vokac@ysoft.com \
    --cc=monstr@monstr.eu \
    --cc=noralf@tronnes.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=sebastien.bourdelin@savoirfairelinux.com \
    --cc=stuyoder@gmail.com \
    --cc=svendev@arcx.com \
    --cc=treding@nvidia.com \
    --cc=yuanzhichang@hisilicon.com \
    --subject='Re: [PATCH anybus v1 0/4] Support HMS Profinet Card over Anybus' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).