From: Lee Jones <lee.jones@linaro.org>
To: Sven Van Asbroeck <svendev@arcx.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, afaerber@suse.de,
treding@nvidia.com, david@lechnology.com, noralf@tronnes.org,
johan@kernel.org, monstr@monstr.eu, michal.vokac@ysoft.com,
arnd@arndb.de, gregkh@linuxfoundation.org, john.garry@huawei.com,
andriy.shevchenko@linux.intel.com, geert+renesas@glider.be,
robin.murphy@arm.com, paul.gortmaker@windriver.com,
sebastien.bourdelin@savoirfairelinux.com, icenowy@aosc.io,
yuanzhichang@hisilicon.com, stuyoder@gmail.com,
linus.walleij@linaro.org, maxime.ripard@bootlin.com,
bogdan.purcareata@nxp.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.
Date: Thu, 25 Oct 2018 06:19:18 +0100 [thread overview]
Message-ID: <20181025051918.GC4939@dell> (raw)
In-Reply-To: <20181024142456.10084-3-svendev@arcx.com>
On Wed, 24 Oct 2018, Sven Van Asbroeck wrote:
> This patch adds devicetree binding documentation for the
> Arcx anybus bridge.
>
> Signed-off-by: Sven Van Asbroeck <svendev@arcx.com>
> ---
> .../bindings/mfd/arcx,anybus-bridge.txt | 37 +++++++++++++++++++
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
> 2 files changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/arcx,anybus-bridge.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/arcx,anybus-bridge.txt b/Documentation/devicetree/bindings/mfd/arcx,anybus-bridge.txt
> new file mode 100644
> index 000000000000..3c0399c4ed45
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/arcx,anybus-bridge.txt
> @@ -0,0 +1,37 @@
> +* Arcx anybus bridge
> +
> +This chip communicates with the SoC over the WEIM bus. It is
> +expected that its Device Tree node is specified as the child of a node
> +corresponding to the WEIM bus used for communication.
> +
> +Required properties:
> +
> + - compatible : The following chip-specific string:
> + "arcx,anybus-bridge"
> +
> + - reg :
> + weim memory area where the cpld registers are located, followed by:
> + weim memory area of the first anybus-s slot, followed by:
> + weim memory area of the second anybus-s slot.
> +
> + - enable-gpios : the gpio connected to the bridge's 'enable gpio'.
> +
> + - pwms : the pwm connected to the bridge's 'pwm input'.
> +
> + - irq-gpios : the gpios connected to the bridge's interrupt lines.
> + note that there is no need to provide the 'interrupts' property here.
> +
> +Example of usage:
> +
> +&weim {
> + bridge@0,0 {
I haven't seen this syntax before.
It doesn't mean it's wrong, but will needs Rob et. al to cast an eye.
> + compatible = "arcx,anybus-bridge";
> + reg = <0 0 0x100>, <0 0x400000 0x800>, <1 0x400000 0x800>;
> + fsl,weim-cs-timing = <0x024400b1 0x00001010 0x20081100
> + 0x00000000 0xa0000240 0x00000000>;
This needs to be documented.
> + enable-gpios = <&gpio5 2 GPIO_ACTIVE_HIGH>;
> + pwms = <&pwm3 0 571>;
> + irq-gpios = <&gpio1 1 GPIO_ACTIVE_HIGH>,
> + <&gpio1 5 GPIO_ACTIVE_HIGH>;
Tabbing.
> + };
> +};
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 2c3fc512e746..1bf07b20a8af 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -35,6 +35,7 @@ aptina Aptina Imaging
> arasan Arasan Chip Systems
> archermind ArcherMind Technology (Nanjing) Co., Ltd.
> arctic Arctic Sand
> +arcx Arcx/Archronix Inc.
> aries Aries Embedded GmbH
> arm ARM Ltd.
> armadeus ARMadeus Systems SARL
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-10-25 5:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 14:24 [PATCH anybus v1 0/4] Support HMS Profinet Card over Anybus Sven Van Asbroeck
2018-10-24 14:24 ` [PATCH anybus v1 1/4] mfd: support the Arcx anybus bridge Sven Van Asbroeck
2018-10-24 15:58 ` Randy Dunlap
2018-10-26 8:34 ` Lee Jones
2018-10-26 13:40 ` Sven Van Asbroeck
2018-10-24 14:24 ` [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding Sven Van Asbroeck
2018-10-25 0:06 ` Rob Herring
2018-10-25 5:19 ` Lee Jones [this message]
2018-10-25 10:16 ` Linus Walleij
2018-10-24 14:24 ` [PATCH anybus v1 3/4] bus: support HMS Anybus-S bus Sven Van Asbroeck
2018-10-24 15:58 ` Randy Dunlap
2018-10-25 11:08 ` Linus Walleij
2018-10-24 14:24 ` [PATCH anybus v1 4/4] misc: support HMS Profinet IRT industrial controller Sven Van Asbroeck
2018-10-24 15:58 ` Randy Dunlap
2018-10-25 9:18 ` [PATCH anybus v1 0/4] Support HMS Profinet Card over Anybus Andy Shevchenko
2018-11-05 14:49 ` Sven Van Asbroeck
2018-10-25 13:35 [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding thesven73
2018-10-25 13:55 thesven73
2018-10-25 15:30 ` David Lechner
2018-10-26 11:28 ` Linus Walleij
2018-10-25 15:46 thesven73
2018-10-26 6:39 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025051918.GC4939@dell \
--to=lee.jones@linaro.org \
--cc=afaerber@suse.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bogdan.purcareata@nxp.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=icenowy@aosc.io \
--cc=johan@kernel.org \
--cc=john.garry@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=michal.vokac@ysoft.com \
--cc=monstr@monstr.eu \
--cc=noralf@tronnes.org \
--cc=paul.gortmaker@windriver.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sebastien.bourdelin@savoirfairelinux.com \
--cc=stuyoder@gmail.com \
--cc=svendev@arcx.com \
--cc=treding@nvidia.com \
--cc=yuanzhichang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).