From: Linus Walleij <linus.walleij@linaro.org>
To: svendev@arcx.com
Cc: "Lee Jones" <lee.jones@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Andreas Färber" <afaerber@suse.de>,
"Thierry Reding" <treding@nvidia.com>,
"David Lechner" <david@lechnology.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
"Johan Hovold" <johan@kernel.org>,
"Michal Simek" <monstr@monstr.eu>,
michal.vokac@ysoft.com, "Arnd Bergmann" <arnd@arndb.de>,
"Greg KH" <gregkh@linuxfoundation.org>,
john.garry@huawei.com,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Robin Murphy" <robin.murphy@arm.com>,
"Paul Gortmaker" <paul.gortmaker@windriver.com>,
"Sebastien Bourdelin" <sebastien.bourdelin@savoirfairelinux.com>,
"Icenowy Zheng" <icenowy@aosc.io>,
yuanzhichang@hisilicon.com, "Stuart Yoder" <stuyoder@gmail.com>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
bogdan.purcareata@nxp.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.
Date: Thu, 25 Oct 2018 12:16:32 +0200 [thread overview]
Message-ID: <CACRpkdbXPWH4FS5205ML0UmuATuZf087Y6ueVUdp_Lfc5Nu8Hw@mail.gmail.com> (raw)
In-Reply-To: <20181024142456.10084-3-svendev@arcx.com>
Hi Sven,
thanks for your patch!
On Wed, Oct 24, 2018 at 4:25 PM Sven Van Asbroeck <svendev@arcx.com> wrote:
> + - pwms : the pwm connected to the bridge's 'pwm input'.
That is really unintuitive and needs a detailed explanation. What
is a bridge doing with a PWM? Is it 100% certain this is a PWM,
it's not just a .... clock? A pwm is a pule WIDTH modulator and
I can't for my life understand why a bus bridge needs a signal
with variable pulse width, but surprise me! :D
> + fsl,weim-cs-timing = <0x024400b1 0x00001010 0x20081100
> + 0x00000000 0xa0000240 0x00000000>;
Is it just a copy/paste from
Documentation/devicetree/bindings/bus/imx-weim.txt
leftover?
It was mentioned as undocumented but it is also pretty terse
with these opaque hex numbers. I would never let the
Freescale binding pass if I was reviewing it.
Look at my bindings for Qualcomm EBI in
Documentation/devicetree/bindings/bus/qcom,ebi2.txt
for example.
But maybe it's not even supposed to be there.
Yours,
Linus Walleij
next prev parent reply other threads:[~2018-10-25 10:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 14:24 [PATCH anybus v1 0/4] Support HMS Profinet Card over Anybus Sven Van Asbroeck
2018-10-24 14:24 ` [PATCH anybus v1 1/4] mfd: support the Arcx anybus bridge Sven Van Asbroeck
2018-10-24 15:58 ` Randy Dunlap
2018-10-26 8:34 ` Lee Jones
2018-10-26 13:40 ` Sven Van Asbroeck
2018-10-24 14:24 ` [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding Sven Van Asbroeck
2018-10-25 0:06 ` Rob Herring
2018-10-25 5:19 ` Lee Jones
2018-10-25 10:16 ` Linus Walleij [this message]
2018-10-24 14:24 ` [PATCH anybus v1 3/4] bus: support HMS Anybus-S bus Sven Van Asbroeck
2018-10-24 15:58 ` Randy Dunlap
2018-10-25 11:08 ` Linus Walleij
2018-10-24 14:24 ` [PATCH anybus v1 4/4] misc: support HMS Profinet IRT industrial controller Sven Van Asbroeck
2018-10-24 15:58 ` Randy Dunlap
2018-10-25 9:18 ` [PATCH anybus v1 0/4] Support HMS Profinet Card over Anybus Andy Shevchenko
2018-11-05 14:49 ` Sven Van Asbroeck
2018-10-25 13:35 [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding thesven73
2018-10-25 13:55 thesven73
2018-10-25 15:30 ` David Lechner
2018-10-26 11:28 ` Linus Walleij
2018-10-25 15:46 thesven73
2018-10-26 6:39 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbXPWH4FS5205ML0UmuATuZf087Y6ueVUdp_Lfc5Nu8Hw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=afaerber@suse.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bogdan.purcareata@nxp.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=icenowy@aosc.io \
--cc=johan@kernel.org \
--cc=john.garry@huawei.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=michal.vokac@ysoft.com \
--cc=monstr@monstr.eu \
--cc=noralf@tronnes.org \
--cc=paul.gortmaker@windriver.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sebastien.bourdelin@savoirfairelinux.com \
--cc=stuyoder@gmail.com \
--cc=svendev@arcx.com \
--cc=treding@nvidia.com \
--cc=yuanzhichang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).