From: Wolfram Sang <wsa@the-dreams.de>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove
Date: Wed, 31 Oct 2018 23:35:02 +0000 [thread overview]
Message-ID: <20181031233502.GB8321@kunai> (raw)
In-Reply-To: <20181019085958.32694-2-ckeepax@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
On Fri, Oct 19, 2018 at 09:59:58AM +0100, Charles Keepax wrote:
> The IRQ will be mapped in i2c_device_probe only if client->irq is zero and
> i2c_device_remove does not clear this. When rebinding an I2C device,
> whos IRQ provider has also been rebound this means that an IRQ mapping
> will never be created, causing the I2C device to fail to acquire its
> IRQ. Fix this issue by clearing client->irq in i2c_device_remove,
> forcing i2c_device_probe to lookup the mapping again.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-10-31 23:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 8:59 [PATCH 1/2] i2c: Remove unnecessary call to irq_find_mapping Charles Keepax
2018-10-19 8:59 ` [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove Charles Keepax
2018-10-28 22:31 ` Wolfram Sang
2018-10-29 10:15 ` Benjamin Tissoires
2018-10-30 11:51 ` Charles Keepax
2018-10-30 14:34 ` Benjamin Tissoires
2018-10-30 14:55 ` Wolfram Sang
2018-10-31 9:52 ` Charles Keepax
2018-10-31 9:59 ` Wolfram Sang
2018-10-31 23:35 ` Wolfram Sang [this message]
2019-01-09 21:47 ` Yauhen Kharuzhy
2019-01-10 13:32 ` Charles Keepax
2019-01-10 20:35 ` Yauhen Kharuzhy
2018-10-28 22:30 ` [PATCH 1/2] i2c: Remove unnecessary call to irq_find_mapping Wolfram Sang
2018-10-29 10:13 ` Benjamin Tissoires
2018-10-31 23:34 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031233502.GB8321@kunai \
--to=wsa@the-dreams.de \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).