linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Masayoshi Mizuma <msys.mizuma@gmail.com>,
	Chao Fan <fanc.fnst@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	linux-efi@vger.kernel.org, linux-acpi@vger.kernel.org,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	keescook@chromium.org, bhe@redhat.com,
	indou.takao@jp.fujitsu.com, caoj.fnst@cn.fujitsu.com
Subject: Re: [PATCH v11 3/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdlien from kexec
Date: Tue, 13 Nov 2018 22:51:56 +0100	[thread overview]
Message-ID: <20181113215156.GP10502@zn.tnic> (raw)
In-Reply-To: <20181113200615.7dypqvhimxzlloek@gabell>

On Tue, Nov 13, 2018 at 03:06:16PM -0500, Masayoshi Mizuma wrote:
> I just felt the BOOT_STRING thing in lib/kstrtox.c confuses...
> I'm OK for now if it's applied your below comment.

Well, actually, upon a second look, I don't think that including a .c
file into a header is ok:

diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h
index 3d78e27077f4..0ff3edb888e4 100644
--- a/arch/x86/boot/string.h
+++ b/arch/x86/boot/string.h
@@ -30,3 +30,7 @@ extern unsigned long long simple_strtoull(const char *cp, char **endp,
                                          unsigned int base);

 #endif /* BOOT_STRING_H */
+
+#ifdef BOOT_STRING
+#include "../../../lib/kstrtox.c"
+#endif

Chao, why isn't this part of arch/x86/boot/compressed/misc.c ?

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

  reply	other threads:[~2018-11-13 21:52 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-12  9:46 [PATCH v11 0/5] x86/boot/KASLR: Parse ACPI table and limit kaslr in immovable memory Chao Fan
2018-11-12  9:46 ` [PATCH v11 1/5] x86/boot: Add efi_get_rsdp_addr() to dig out RSDP from EFI table Chao Fan
2018-11-12 14:54   ` Borislav Petkov
2018-11-13  1:57     ` Chao Fan
2018-11-12  9:46 ` [PATCH v11 2/5] x86/boot: Add bios_get_rsdp_addr() to search RSDP in memory Chao Fan
2018-11-12 15:27   ` Borislav Petkov
2018-11-13  2:10     ` Chao Fan
2018-11-13 10:09       ` Borislav Petkov
2018-11-12  9:46 ` [PATCH v11 3/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdlien from kexec Chao Fan
2018-11-12  9:50   ` Chao Fan
2018-11-12 17:43   ` Masayoshi Mizuma
2018-11-13  2:12     ` Chao Fan
2018-11-13 16:11       ` Masayoshi Mizuma
2018-11-13 17:22         ` Borislav Petkov
2018-11-13 17:54         ` Borislav Petkov
2018-11-13 20:06           ` Masayoshi Mizuma
2018-11-13 21:51             ` Borislav Petkov [this message]
2018-11-14  6:12               ` Chao Fan
2018-11-14 18:30                 ` Borislav Petkov
2018-11-19  1:16                   ` Chao Fan
2018-11-13 17:51   ` Borislav Petkov
2018-11-14  1:54     ` Chao Fan
2018-11-14  1:59       ` Chao Fan
2018-11-14 18:33       ` Borislav Petkov
2018-11-12  9:46 ` [PATCH v11 4/5] x86/boot: Dig out SRAT table from RSDP and find immovable memory Chao Fan
2018-11-12 20:52   ` Masayoshi Mizuma
2018-11-13  2:43     ` Chao Fan
2018-11-12 21:51   ` Masayoshi Mizuma
2018-11-13  2:45     ` Chao Fan
2018-11-16 11:16   ` Borislav Petkov
2018-11-19  2:08     ` Chao Fan
2018-11-20  6:18     ` Chao Fan
2018-11-12  9:46 ` [PATCH v11 5/5] x86/boot/KASLR: Walk srat tables to filter " Chao Fan
2018-11-16 13:50   ` Borislav Petkov
2018-11-19  1:31     ` Chao Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181113215156.GP10502@zn.tnic \
    --to=bp@alien8.de \
    --cc=bhe@redhat.com \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=fanc.fnst@cn.fujitsu.com \
    --cc=hpa@zytor.com \
    --cc=indou.takao@jp.fujitsu.com \
    --cc=keescook@chromium.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=msys.mizuma@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).