From: Tom Burkart <tom@aussec.com>
To: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Cc: Tom Burkart <tom@aussec.com>
Subject: [PATCH v7 0/4] PPS: pps-gpio PPS ECHO implementation
Date: Wed, 14 Nov 2018 23:54:28 +1100 [thread overview]
Message-ID: <20181114125432.16044-1-tom@aussec.com> (raw)
Hi all,
please find attached the PPS-GPIO PPS ECHO implementation patch. The
driver claims to have echo functionality in the sysfs interface but this
functionality is not present. This patch provides this functionality.
Parts 1 and 2 of the patch change the original driver from the number
based GPIO ABI to the descriptor based ABI. This has been modified
to not break backward compatibility.
Parts 3 and 4 then add the PPS ECHO functionality. This is enabled if a
"echo-gpios" entry is found in the devicetree.
Changes in v4:
There is a bugfix in part 2 that was returning an uninitialised variable
and juggling some code that speeds up the probe by not running code when
not using PPS ECHO.
Changes in v5:
Meet all requirements of checkpatch
Changes in v6:
Cosmetic changes to code layout
Changes in v7:
Also accept the DEPRECATED "gpios" devicetree entry to ensure backward
compatibility.
On the linuxpps mailing list it was suggested to use a hrtimer for
resetting the GPIO ECHO active state to the inactive state.
Please also comment on whether a hrtimer is necessary/desirable for the
purpose of resetting the echo pin active state. I am happy to implement
it if there is a need.
Please install, test and comment as it is now a quite major change to
the driver.
Please do send suggestions for improvement.
Tom Burkart
Tom Burkart (4):
dt-bindings: pps: descriptor-based gpio, capture-clear addition
pps: descriptor-based gpio, capture-clear addition
dt-bindings: pps: pps-gpio PPS ECHO implementation
pps: pps-gpio pps-echo implementation
Documentation/devicetree/bindings/pps/pps-gpio.txt | 17 +-
drivers/pps/clients/pps-gpio.c | 225 +++++++++++++++++----
include/linux/pps-gpio.h | 6 +-
3 files changed, 203 insertions(+), 45 deletions(-)
--
2.12.3
next reply other threads:[~2018-11-14 12:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 12:54 Tom Burkart [this message]
2018-11-14 12:54 ` [PATCH v7 1/4] dt-bindings: pps: descriptor-based gpio, capture-clear addition Tom Burkart
2018-11-14 12:54 ` [PATCH v7 2/4] " Tom Burkart
2018-11-14 12:54 ` [PATCH 3/4] dt-bindings: pps: pps-gpio PPS ECHO implementation Tom Burkart
2018-11-14 12:54 ` [PATCH v7 4/4] pps: pps-gpio pps-echo implementation Tom Burkart
2018-11-16 22:49 ` [PATCH v7 1/4] dt-bindings: pps: descriptor-based gpio, capture-clear addition Rob Herring
2018-11-17 10:35 ` tom burkart
2018-11-17 14:22 ` Rob Herring
2018-11-18 0:35 ` tom burkart
2018-11-26 19:39 ` Rob Herring
2018-11-27 3:57 ` tom burkart
2018-11-28 17:13 ` Rob Herring
2018-11-29 0:29 ` tom burkart
2018-11-29 2:05 ` tom burkart
2018-11-29 18:00 ` Rob Herring
2018-12-01 22:24 ` tom burkart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114125432.16044-1-tom@aussec.com \
--to=tom@aussec.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).