From: tom burkart <tom@aussec.com>
To: Rob Herring <robh@kernel.org>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v7 1/4] dt-bindings: pps: descriptor-based gpio, capture-clear addition
Date: Sat, 17 Nov 2018 21:35:22 +1100 [thread overview]
Message-ID: <20181117213522.12672utznrvpbn56@www.aussec.com> (raw)
In-Reply-To: <20181116224919.GA18008@bogus>
Quoting Rob Herring <robh@kernel.org>:
> On Wed, Nov 14, 2018 at 11:54:29PM +1100, Tom Burkart wrote:
>> This patch changes the devicetree bindings for the pps-gpio driver
>> from the integer based ABI to the descriptor based ABI.
> ? That has nothing to do with DT.
I believe it does, as the change in ABI forces a rename in the DT
naming convention.
This is due to the descriptor based ABI appending "-gpio" or "-gpios" (see
Documentation/gpio/base.txt.)
Admittedly, I may have called it by the wrong name due to ignorance,
my apologies.
>> It also adds
>> documentation for the device tree capture-clear option. The legacy
>> device tree entry for the GPIO pin is supported.
>>
>> Signed-off-by: Tom Burkart <tom@aussec.com>
>> ---
>> Documentation/devicetree/bindings/pps/pps-gpio.txt | 8 ++++++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.txt
>> b/Documentation/devicetree/bindings/pps/pps-gpio.txt
>> index 3683874832ae..6c9fc0998d94 100644
>> --- a/Documentation/devicetree/bindings/pps/pps-gpio.txt
>> +++ b/Documentation/devicetree/bindings/pps/pps-gpio.txt
>> @@ -5,19 +5,23 @@ a GPIO pin.
>>
>> Required properties:
>> - compatible: should be "pps-gpio"
>> -- gpios: one PPS GPIO in the format described by ../gpio/gpio.txt
>> +- pps-gpios: one PPS GPIO in the format described by ../gpio/gpio.txt
>> +Alternatively (DEPRECATED), instead of pps-gpios above, it may have:
>> +- gpios: one PPS GPIO as above
>>
>> Optional properties:
>> - assert-falling-edge: when present, assert is indicated by a falling edge
>> (instead of by a rising edge)
>> +- capture-clear: when present, also capture the PPS clear event
>
> Is this a h/w thing? or driver configuration?
Driver configuration. Most of the code was present in the driver, yet
it was not documented, or usable due to a two line (code) omission
(the value was not being fetched from DT).
>>
>> Example:
>> pps {
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_pps>;
>>
>> - gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
>> + pps-gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
>> assert-falling-edge;
>> + capture-clear;
>>
>> compatible = "pps-gpio";
>> };
>> --
>> 2.12.3
>>
>
>
next prev parent reply other threads:[~2018-11-17 10:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 12:54 [PATCH v7 0/4] PPS: pps-gpio PPS ECHO implementation Tom Burkart
2018-11-14 12:54 ` [PATCH v7 1/4] dt-bindings: pps: descriptor-based gpio, capture-clear addition Tom Burkart
2018-11-14 12:54 ` [PATCH v7 2/4] " Tom Burkart
2018-11-14 12:54 ` [PATCH 3/4] dt-bindings: pps: pps-gpio PPS ECHO implementation Tom Burkart
2018-11-14 12:54 ` [PATCH v7 4/4] pps: pps-gpio pps-echo implementation Tom Burkart
2018-11-16 22:49 ` [PATCH v7 1/4] dt-bindings: pps: descriptor-based gpio, capture-clear addition Rob Herring
2018-11-17 10:35 ` tom burkart [this message]
2018-11-17 14:22 ` Rob Herring
2018-11-18 0:35 ` tom burkart
2018-11-26 19:39 ` Rob Herring
2018-11-27 3:57 ` tom burkart
2018-11-28 17:13 ` Rob Herring
2018-11-29 0:29 ` tom burkart
2018-11-29 2:05 ` tom burkart
2018-11-29 18:00 ` Rob Herring
2018-12-01 22:24 ` tom burkart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181117213522.12672utznrvpbn56@www.aussec.com \
--to=tom@aussec.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).