linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250
Date: Wed, 14 Nov 2018 21:38:36 -0800	[thread overview]
Message-ID: <20181115053836.GA7606@roeck-us.net> (raw)
In-Reply-To: <29E7A6C0-7829-4650-93C6-7220FECAA6EF@gmail.com>

On Wed, Nov 14, 2018 at 07:56:47PM -0800, Florian Fainelli wrote:
> 
> 
> On November 14, 2018 5:11:25 PM PST, Guenter Roeck <linux@roeck-us.net> wrote:
> >On Thu, Nov 01, 2018 at 11:26:06AM -0700, Florian Fainelli wrote:
> >> It is way too easy to miss enabling SERIAL_OF_PLATFORM which would
> >> result in the inability for the kernel to have a valid console
> >device,
> >> which can be seen with:
> >> 
> >> Warning: unable to open an initial console.
> >> 
> >> and then:
> >> 
> >> Run /init as init process
> >> Kernel panic - not syncing: Attempted to kill init!
> >exitcode=0x00000100
> >> 
> >> Since SERIAL_OF_PLATFORM already depends on SERIAL_8250 && OF there
> >> really is no drawback to defaulting this config to the value of
> >> SERIAL_8250.
> >> 
> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> >> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> >This patch results in situations where CONFIG_SERIAL_OF_PLATFORM is now
> >defined where it was not previously. Example mpc85xx_defconfig. This in
> >turn results in boot failures for those configurations, with an error
> >message of
> >
> >of_serial: probe of e0004500.serial failed with error -22
> >
> >which wasn't seen before.
> 
> Do you know which Device Tree is being used here? The most obvious thing that could be done is to add a !PPC condition but this might be missing other platforms doing their own 8250 registration yet being OF aware (sparc?).
> 
> >
> >Not sure if replacing a potential problem with a real one is really an
> >improvement.`
> 
> That comment is not particularly helpful though I have an appreciation for when a change breaks things in unexpected ways and how frustrating that can be.

Actally, never mind. I dropped the test cases. Sorry for the noise.

Guenter

  parent reply	other threads:[~2018-11-15  5:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  1:11 [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250 Guenter Roeck
2018-11-15  3:56 ` Florian Fainelli
2018-11-15  5:36   ` Guenter Roeck
2018-11-15 17:19     ` Florian Fainelli
2018-11-15  5:38   ` Guenter Roeck [this message]
2018-11-15 17:19     ` Florian Fainelli
2018-11-15 17:25       ` Guenter Roeck
2018-11-15 19:48         ` Florian Fainelli
2018-11-16  1:16           ` Guenter Roeck
2018-11-19 18:44             ` Florian Fainelli
2018-11-19 20:50               ` Guenter Roeck
2018-11-23 18:20                 ` Guenter Roeck
2018-11-27  0:08                   ` Florian Fainelli
2018-12-05  5:47                     ` Michael Ellerman
2018-12-05 22:40                       ` Florian Fainelli
2018-12-20 15:21 ` Greg Kroah-Hartman
2018-12-20 17:38   ` Guenter Roeck
2018-12-21  4:27     ` [PATCH] Revert "serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250" Florian Fainelli
2018-12-21  4:28     ` [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250 Florian Fainelli
  -- strict thread matches above, loose matches on Subject: below --
2018-11-01 18:26 Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181115053836.GA7606@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).