From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-sunxi@googlegroups.com, Hans Verkuil <hverkuil@xs4all.nl>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 08/15] ARM/arm64: sunxi: Move H3/H5 syscon label over to soc-specific nodes
Date: Fri, 16 Nov 2018 10:39:04 +0100 [thread overview]
Message-ID: <20181116093904.4ikn7ldksrm3mp5d@flea> (raw)
In-Reply-To: <20181115145013.3378-9-paul.kocialkowski@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 1760 bytes --]
On Thu, Nov 15, 2018 at 03:50:06PM +0100, Paul Kocialkowski wrote:
> Now that we have specific nodes for the H3 and H5 system-controller
> that allow proper access to the EMAC clock configuration register,
> we no longer need a common dummy syscon node.
>
> Switch the syscon label over to each platform's dtsi file.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> ---
> arch/arm/boot/dts/sun8i-h3.dtsi | 2 +-
> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 ------
> arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 2 +-
> 3 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> index 7157d954fb8c..b337a9282783 100644
> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> @@ -134,7 +134,7 @@
> };
>
> soc {
> - system-control@1c00000 {
> + syscon: system-control@1c00000 {
> compatible = "allwinner,sun8i-h3-system-control";
> reg = <0x01c00000 0x1000>;
> #address-cells = <1>;
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index 4b1530ebe427..9175ff0fb59a 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -152,12 +152,6 @@
> };
> };
>
> - syscon: syscon@1c00000 {
> - compatible = "allwinner,sun8i-h3-system-controller",
> - "syscon";
> - reg = <0x01c00000 0x1000>;
> - };
> -
You're also dropping the syscon compatible there. But I'm not sure how
it could work with the H3 EMAC driver that would overwrite the
compatible already.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2018-11-16 9:39 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 14:49 [PATCH 00/15] Cedrus support for the Allwinner H5 and A64 platforms Paul Kocialkowski
2018-11-15 14:49 ` [PATCH 01/15] ARM: dts: sun8i-a33: Remove heading 0 in video-codec unit address Paul Kocialkowski
2018-11-15 15:50 ` Chen-Yu Tsai
2018-11-16 9:59 ` Paul Kocialkowski
2018-11-15 14:50 ` [PATCH 02/15] ARM: dts: sun8i-h3: " Paul Kocialkowski
2018-11-15 15:50 ` Chen-Yu Tsai
2018-11-15 14:50 ` [PATCH 03/15] ARM: dts: sun8i-h3: Fix the system-control register range Paul Kocialkowski
2018-11-15 15:51 ` Chen-Yu Tsai
2018-11-15 14:50 ` [PATCH 04/15] soc: sunxi: sram: Enable EMAC clock access for H3 variant Paul Kocialkowski
2018-11-15 15:53 ` Chen-Yu Tsai
2018-11-15 14:50 ` [PATCH 05/15] dt-bindings: sram: sunxi: Add bindings for the H5 with SRAM C1 Paul Kocialkowski
2018-12-04 21:46 ` Rob Herring
2018-11-15 14:50 ` [PATCH 06/15] soc: sunxi: sram: Add support for the H5 SoC system control Paul Kocialkowski
2018-11-15 14:50 ` [PATCH 07/15] arm64: dts: allwinner: h5: Add system-control node with SRAM C1 Paul Kocialkowski
2018-11-15 16:52 ` Chen-Yu Tsai
2018-11-30 3:38 ` Chen-Yu Tsai
2018-11-30 13:26 ` Paul Kocialkowski
2018-11-15 14:50 ` [PATCH 08/15] ARM/arm64: sunxi: Move H3/H5 syscon label over to soc-specific nodes Paul Kocialkowski
2018-11-16 9:39 ` Maxime Ripard [this message]
2018-11-16 9:47 ` Chen-Yu Tsai
2018-11-16 9:56 ` Paul Kocialkowski
2018-11-16 16:39 ` Maxime Ripard
2018-11-15 14:50 ` [PATCH 09/15] dt-bindings: sram: sunxi: Add compatible for the A64 SRAM C1 Paul Kocialkowski
2018-12-04 21:47 ` Rob Herring
2018-11-15 14:50 ` [PATCH 10/15] arm64: dts: allwinner: a64: Add support for the SRAM C1 section Paul Kocialkowski
2018-11-15 16:39 ` Chen-Yu Tsai
2018-11-15 14:50 ` [PATCH 11/15] dt-bindings: media: cedrus: Add compatibles for the A64 and H5 Paul Kocialkowski
2018-12-04 21:47 ` Rob Herring
2018-11-15 14:50 ` [PATCH 12/15] media: cedrus: Add device-tree compatible and variant for H5 support Paul Kocialkowski
2018-11-15 14:50 ` [PATCH 13/15] media: cedrus: Add device-tree compatible and variant for A64 support Paul Kocialkowski
2018-11-15 14:50 ` [PATCH 14/15] arm64: dts: allwinner: h5: Add Video Engine and reserved memory node Paul Kocialkowski
2018-11-15 15:35 ` [linux-sunxi] " Chen-Yu Tsai
2018-11-30 13:16 ` Paul Kocialkowski
2018-11-15 14:50 ` [PATCH 15/15] arm64: dts: allwinner: a64: " Paul Kocialkowski
2018-11-16 9:41 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116093904.4ikn7ldksrm3mp5d@flea \
--to=maxime.ripard@bootlin.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).