* [PATCH] dt-bindings: ti-tsc-adc: Add new compatible for AM654 SoCs
@ 2018-11-19 9:45 Vignesh R
2018-12-04 8:30 ` Vignesh R
2018-12-04 23:16 ` Rob Herring
0 siblings, 2 replies; 5+ messages in thread
From: Vignesh R @ 2018-11-19 9:45 UTC (permalink / raw)
To: Dmitry Torokhov, Rob Herring
Cc: Lee Jones, Vignesh R, linux-input, linux-omap, devicetree, linux-kernel
AM654 SoCs has ADC IP which is similar to AM335x. Add new compatible to
handle AM654 SoCs. Also, it seems that existing compatible strings used
in the kernel DTs were never documented. So, document them now.
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
.../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
index b1163bf97146..aad5e34965eb 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
+++ b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
@@ -2,7 +2,12 @@
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Required properties:
+- mfd
+ compatible: Should be
+ "ti,am3359-tscadc" for AM335x/AM437x SoCs
+ "ti,am654-tscadc", "ti,am3359-tscadc" for AM654 SoCs
- child "tsc"
+ compatible: Should be "ti,am3359-tsc".
ti,wires: Wires refer to application modes i.e. 4/5/8 wire touchscreen
support on the platform.
ti,x-plate-resistance: X plate resistance
@@ -25,6 +30,9 @@ Required properties:
AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7.
XP = 0, XN = 1, YP = 2, YN = 3.
- child "adc"
+ compatible: Should be
+ "ti,am3359-adc" for AM335x/AM437x SoCs
+ "ti,am654-adc", "ti,am3359-adc" for AM654 SoCs
ti,adc-channels: List of analog inputs available for ADC.
AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7.
--
2.19.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: ti-tsc-adc: Add new compatible for AM654 SoCs
2018-11-19 9:45 [PATCH] dt-bindings: ti-tsc-adc: Add new compatible for AM654 SoCs Vignesh R
@ 2018-12-04 8:30 ` Vignesh R
2018-12-04 9:52 ` Lee Jones
2018-12-04 23:16 ` Rob Herring
1 sibling, 1 reply; 5+ messages in thread
From: Vignesh R @ 2018-12-04 8:30 UTC (permalink / raw)
To: Dmitry Torokhov, Rob Herring
Cc: Lee Jones, linux-input, linux-omap, devicetree, linux-kernel
Hi,
On 19/11/18 3:15 PM, Vignesh R wrote:
> AM654 SoCs has ADC IP which is similar to AM335x. Add new compatible to
> handle AM654 SoCs. Also, it seems that existing compatible strings used
> in the kernel DTs were never documented. So, document them now.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
Gentle ping on this patch..
> .../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> index b1163bf97146..aad5e34965eb 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> @@ -2,7 +2,12 @@
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Required properties:
> +- mfd
> + compatible: Should be
> + "ti,am3359-tscadc" for AM335x/AM437x SoCs
> + "ti,am654-tscadc", "ti,am3359-tscadc" for AM654 SoCs
> - child "tsc"
> + compatible: Should be "ti,am3359-tsc".
> ti,wires: Wires refer to application modes i.e. 4/5/8 wire touchscreen
> support on the platform.
> ti,x-plate-resistance: X plate resistance
> @@ -25,6 +30,9 @@ Required properties:
> AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7.
> XP = 0, XN = 1, YP = 2, YN = 3.
> - child "adc"
> + compatible: Should be
> + "ti,am3359-adc" for AM335x/AM437x SoCs
> + "ti,am654-adc", "ti,am3359-adc" for AM654 SoCs
> ti,adc-channels: List of analog inputs available for ADC.
> AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7.
>
>
--
Regards
Vignesh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: ti-tsc-adc: Add new compatible for AM654 SoCs
2018-12-04 8:30 ` Vignesh R
@ 2018-12-04 9:52 ` Lee Jones
2018-12-04 9:54 ` Lee Jones
0 siblings, 1 reply; 5+ messages in thread
From: Lee Jones @ 2018-12-04 9:52 UTC (permalink / raw)
To: Vignesh R
Cc: Dmitry Torokhov, Rob Herring, linux-input, linux-omap,
devicetree, linux-kernel
On Tue, 04 Dec 2018, Vignesh R wrote:
> Hi,
>
> On 19/11/18 3:15 PM, Vignesh R wrote:
> > AM654 SoCs has ADC IP which is similar to AM335x. Add new compatible to
> > handle AM654 SoCs. Also, it seems that existing compatible strings used
> > in the kernel DTs were never documented. So, document them now.
> >
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
> > ---
>
> Gentle ping on this patch..
Don't do that.
If you think your patch has been forgotten, please submit a [RESEND].
> > .../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> > index b1163bf97146..aad5e34965eb 100644
> > --- a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> > +++ b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> > @@ -2,7 +2,12 @@
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Required properties:
> > +- mfd
> > + compatible: Should be
> > + "ti,am3359-tscadc" for AM335x/AM437x SoCs
> > + "ti,am654-tscadc", "ti,am3359-tscadc" for AM654 SoCs
> > - child "tsc"
> > + compatible: Should be "ti,am3359-tsc".
> > ti,wires: Wires refer to application modes i.e. 4/5/8 wire touchscreen
> > support on the platform.
> > ti,x-plate-resistance: X plate resistance
> > @@ -25,6 +30,9 @@ Required properties:
> > AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7.
> > XP = 0, XN = 1, YP = 2, YN = 3.
> > - child "adc"
> > + compatible: Should be
> > + "ti,am3359-adc" for AM335x/AM437x SoCs
> > + "ti,am654-adc", "ti,am3359-adc" for AM654 SoCs
> > ti,adc-channels: List of analog inputs available for ADC.
> > AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7.
> >
> >
>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: ti-tsc-adc: Add new compatible for AM654 SoCs
2018-12-04 9:52 ` Lee Jones
@ 2018-12-04 9:54 ` Lee Jones
0 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2018-12-04 9:54 UTC (permalink / raw)
To: Vignesh R
Cc: Dmitry Torokhov, Rob Herring, linux-input, linux-omap,
devicetree, linux-kernel
On Tue, 04 Dec 2018, Lee Jones wrote:
> On Tue, 04 Dec 2018, Vignesh R wrote:
> > On 19/11/18 3:15 PM, Vignesh R wrote:
> > > AM654 SoCs has ADC IP which is similar to AM335x. Add new compatible to
> > > handle AM654 SoCs. Also, it seems that existing compatible strings used
> > > in the kernel DTs were never documented. So, document them now.
> > >
> > > Signed-off-by: Vignesh R <vigneshr@ti.com>
> > > ---
> >
> > Gentle ping on this patch..
>
> Don't do that.
>
> If you think your patch has been forgotten, please submit a [RESEND].
As an aside, the subject line is missing a subsystem, which might be
why it was missed by the subsystem maintainer.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: ti-tsc-adc: Add new compatible for AM654 SoCs
2018-11-19 9:45 [PATCH] dt-bindings: ti-tsc-adc: Add new compatible for AM654 SoCs Vignesh R
2018-12-04 8:30 ` Vignesh R
@ 2018-12-04 23:16 ` Rob Herring
1 sibling, 0 replies; 5+ messages in thread
From: Rob Herring @ 2018-12-04 23:16 UTC (permalink / raw)
To: Vignesh R
Cc: Dmitry Torokhov, Rob Herring, Lee Jones, Vignesh R, linux-input,
linux-omap, devicetree, linux-kernel
On Mon, 19 Nov 2018 15:15:09 +0530, Vignesh R wrote:
> AM654 SoCs has ADC IP which is similar to AM335x. Add new compatible to
> handle AM654 SoCs. Also, it seems that existing compatible strings used
> in the kernel DTs were never documented. So, document them now.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
> .../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-12-04 23:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-19 9:45 [PATCH] dt-bindings: ti-tsc-adc: Add new compatible for AM654 SoCs Vignesh R
2018-12-04 8:30 ` Vignesh R
2018-12-04 9:52 ` Lee Jones
2018-12-04 9:54 ` Lee Jones
2018-12-04 23:16 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).