* [PATCH] pinctrl: Use of_node_name_eq for node name comparisons
@ 2018-12-05 19:50 Rob Herring
2018-12-06 5:25 ` Tomasz Figa
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rob Herring @ 2018-12-05 19:50 UTC (permalink / raw)
To: devicetree, linux-kernel
Cc: Tomasz Figa, Krzysztof Kozlowski, Sylwester Nawrocki,
Linus Walleij, linux-arm-kernel, linux-samsung-soc, linux-gpio
Convert string compares of DT node names to use of_node_name_eq helper
instead. This removes direct access to the node name pointer.
Cc: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
index ee6ee2338606..de0477bb469d 100644
--- a/drivers/pinctrl/samsung/pinctrl-samsung.c
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
@@ -1071,7 +1071,7 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,
continue;
bank = d->pin_banks;
for (i = 0; i < d->nr_banks; ++i, ++bank) {
- if (!strcmp(bank->name, np->name)) {
+ if (of_node_name_eq(np, bank->name)) {
bank->of_node = np;
break;
}
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: Use of_node_name_eq for node name comparisons
2018-12-05 19:50 [PATCH] pinctrl: Use of_node_name_eq for node name comparisons Rob Herring
@ 2018-12-06 5:25 ` Tomasz Figa
2018-12-06 7:07 ` Krzysztof Kozlowski
2018-12-14 15:03 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Tomasz Figa @ 2018-12-06 5:25 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-kernel, Krzysztof Kozlowski,
Sylwester Nawrocki, linus.walleij, linux-arm-kernel,
moderated list:SAMSUNG SOC CLOCK DRIVERS, linux-gpio
2018年12月5日(水) 11:51 Rob Herring <robh@kernel.org>:
>
> Convert string compares of DT node names to use of_node_name_eq helper
> instead. This removes direct access to the node name pointer.
>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
> index ee6ee2338606..de0477bb469d 100644
> --- a/drivers/pinctrl/samsung/pinctrl-samsung.c
> +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
> @@ -1071,7 +1071,7 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,
> continue;
> bank = d->pin_banks;
> for (i = 0; i < d->nr_banks; ++i, ++bank) {
> - if (!strcmp(bank->name, np->name)) {
> + if (of_node_name_eq(np, bank->name)) {
> bank->of_node = np;
> break;
> }
> --
> 2.19.1
>
Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: Use of_node_name_eq for node name comparisons
2018-12-05 19:50 [PATCH] pinctrl: Use of_node_name_eq for node name comparisons Rob Herring
2018-12-06 5:25 ` Tomasz Figa
@ 2018-12-06 7:07 ` Krzysztof Kozlowski
2018-12-14 15:03 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2018-12-06 7:07 UTC (permalink / raw)
To: linus.walleij
Cc: robh, devicetree, linux-kernel, Tomasz Figa, s.nawrocki,
linux-arm-kernel, linux-samsung-soc, linux-gpio
On Wed, 5 Dec 2018 at 20:51, Rob Herring <robh@kernel.org> wrote:
>
> Convert string compares of DT node names to use of_node_name_eq helper
> instead. This removes direct access to the node name pointer.
>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Linus,
I do not have anything queued in pinctrl samsung for next release, so
maybe you could apply this directly?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: Use of_node_name_eq for node name comparisons
2018-12-05 19:50 [PATCH] pinctrl: Use of_node_name_eq for node name comparisons Rob Herring
2018-12-06 5:25 ` Tomasz Figa
2018-12-06 7:07 ` Krzysztof Kozlowski
@ 2018-12-14 15:03 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2018-12-14 15:03 UTC (permalink / raw)
To: Rob Herring
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel, Tomasz Figa, Krzysztof Kozlowski,
Sylwester Nawrocki, Linux ARM, linux-samsung-soc,
open list:GPIO SUBSYSTEM
On Wed, Dec 5, 2018 at 8:51 PM Rob Herring <robh@kernel.org> wrote:
> Convert string compares of DT node names to use of_node_name_eq helper
> instead. This removes direct access to the node name pointer.
>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-14 15:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-05 19:50 [PATCH] pinctrl: Use of_node_name_eq for node name comparisons Rob Herring
2018-12-06 5:25 ` Tomasz Figa
2018-12-06 7:07 ` Krzysztof Kozlowski
2018-12-14 15:03 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).