From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: hch@lst.de, cai@gmx.us, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH v2 4/8] dma-debug: Dynamically expand the dma_debug_entry pool
Date: Thu, 6 Dec 2018 15:24:23 +0100 [thread overview]
Message-ID: <20181206142423.GB24642@lst.de> (raw)
In-Reply-To: <8ba34734842beb3ef72260c4ab822dba7c588e4c.1544037783.git.robin.murphy@arm.com>
> @@ -47,6 +47,8 @@
> #ifndef PREALLOC_DMA_DEBUG_ENTRIES
> #define PREALLOC_DMA_DEBUG_ENTRIES (1 << 16)
> #endif
FYI, I think we should drop the potential arch hook with the ifndef
here once we support the dynamic adjustment.
> + if (dma_debug_create_entries(DMA_DEBUG_DYNAMIC_ENTRIES, GFP_ATOMIC)) {
Overly long line.
next prev parent reply other threads:[~2018-12-06 14:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 19:56 [PATCH v2 0/8] dma-debug cleanup and dynamic allocation Robin Murphy
2018-12-05 19:56 ` [PATCH v2 1/8] dma-debug: Use pr_fmt() Robin Murphy
2018-12-05 19:56 ` [PATCH v2 2/8] dma-debug: Expose nr_total_entries in debugfs Robin Murphy
2018-12-06 14:14 ` Christoph Hellwig
2018-12-05 19:56 ` [PATCH v2 3/8] dma-debug: Refactor dma_debug_entry allocation Robin Murphy
2018-12-06 14:23 ` Christoph Hellwig
2018-12-06 18:10 ` Robin Murphy
2018-12-06 18:46 ` Christoph Hellwig
2018-12-05 19:56 ` [PATCH v2 4/8] dma-debug: Dynamically expand the dma_debug_entry pool Robin Murphy
2018-12-06 14:24 ` Christoph Hellwig [this message]
2018-12-06 18:31 ` Robin Murphy
2018-12-05 19:56 ` [PATCH v2 5/8] dma-debug: Make leak-like behaviour apparent Robin Murphy
2018-12-06 14:24 ` Christoph Hellwig
2018-12-05 19:56 ` [PATCH v2 6/8] x86/dma/amd-gart: Stop resizing dma_debug_entry pool Robin Murphy
2018-12-06 14:25 ` Christoph Hellwig
2018-12-05 19:56 ` [PATCH v2 7/8] dma/debug: Remove dma_debug_resize_entries() Robin Murphy
2018-12-06 14:25 ` Christoph Hellwig
2018-12-05 19:56 ` [PATCH v2 8/8] dma-debug: Batch dma_debug_entry allocation Robin Murphy
2018-12-06 14:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206142423.GB24642@lst.de \
--to=hch@lst.de \
--cc=cai@gmx.us \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).