From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Christoph Hellwig <hch@lst.de>,
m.szyprowski@samsung.com, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, cai@gmx.us, salil.mehta@huawei.com,
john.garry@huawei.com
Subject: Re: [PATCH v2 3/8] dma-debug: Refactor dma_debug_entry allocation
Date: Thu, 6 Dec 2018 19:46:28 +0100 [thread overview]
Message-ID: <20181206184628.GA30345@lst.de> (raw)
In-Reply-To: <9accc5fe-4aae-ff7d-a234-f27167c49614@arm.com>
On Thu, Dec 06, 2018 at 06:10:47PM +0000, Robin Murphy wrote:
> AFAICS the tmp list wasn't about locking as much as meaning that if
> kzalloc() failed at any point, we can free the partial allocation and back
> out without disturbing free_entries at all - that still makes sense to me
> up until patch #8 where we embrace the "never free anything" paradigm and
> rip out the final traces.
>
> That said, maybe I should just drop the refactoring of
> dma_debug_resize_entries() now that I'm deleting it as part of the same
> series anyway - then I guess I squash what's left of this patch into #4 and
> bring forward some of the simplification from #8 to start with. Would that
> be more agreeable?
Yes, I just noticed all this goes away toward the end anyway. We can
either keep it as is, or just drop the intermediate step if that is
easy enough for you.
next prev parent reply other threads:[~2018-12-06 18:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 19:56 [PATCH v2 0/8] dma-debug cleanup and dynamic allocation Robin Murphy
2018-12-05 19:56 ` [PATCH v2 1/8] dma-debug: Use pr_fmt() Robin Murphy
2018-12-05 19:56 ` [PATCH v2 2/8] dma-debug: Expose nr_total_entries in debugfs Robin Murphy
2018-12-06 14:14 ` Christoph Hellwig
2018-12-05 19:56 ` [PATCH v2 3/8] dma-debug: Refactor dma_debug_entry allocation Robin Murphy
2018-12-06 14:23 ` Christoph Hellwig
2018-12-06 18:10 ` Robin Murphy
2018-12-06 18:46 ` Christoph Hellwig [this message]
2018-12-05 19:56 ` [PATCH v2 4/8] dma-debug: Dynamically expand the dma_debug_entry pool Robin Murphy
2018-12-06 14:24 ` Christoph Hellwig
2018-12-06 18:31 ` Robin Murphy
2018-12-05 19:56 ` [PATCH v2 5/8] dma-debug: Make leak-like behaviour apparent Robin Murphy
2018-12-06 14:24 ` Christoph Hellwig
2018-12-05 19:56 ` [PATCH v2 6/8] x86/dma/amd-gart: Stop resizing dma_debug_entry pool Robin Murphy
2018-12-06 14:25 ` Christoph Hellwig
2018-12-05 19:56 ` [PATCH v2 7/8] dma/debug: Remove dma_debug_resize_entries() Robin Murphy
2018-12-06 14:25 ` Christoph Hellwig
2018-12-05 19:56 ` [PATCH v2 8/8] dma-debug: Batch dma_debug_entry allocation Robin Murphy
2018-12-06 14:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206184628.GA30345@lst.de \
--to=hch@lst.de \
--cc=cai@gmx.us \
--cc=iommu@lists.linux-foundation.org \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=salil.mehta@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).