From: Robin Murphy <robin.murphy@arm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: cai@gmx.us, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH v2 4/8] dma-debug: Dynamically expand the dma_debug_entry pool
Date: Thu, 6 Dec 2018 18:31:25 +0000 [thread overview]
Message-ID: <99a5f83b-8362-937e-9e50-116eedb7e593@arm.com> (raw)
In-Reply-To: <20181206142423.GB24642@lst.de>
On 06/12/2018 14:24, Christoph Hellwig wrote:
>> @@ -47,6 +47,8 @@
>> #ifndef PREALLOC_DMA_DEBUG_ENTRIES
>> #define PREALLOC_DMA_DEBUG_ENTRIES (1 << 16)
>> #endif
>
> FYI, I think we should drop the potential arch hook with the ifndef
> here once we support the dynamic adjustment.
Sure - I have a vague feeling that thought did cross my mind at the
time, but it didn't stick.
>
>> + if (dma_debug_create_entries(DMA_DEBUG_DYNAMIC_ENTRIES, GFP_ATOMIC)) {
>
> Overly long line.
Bah, I deliberately didn't bother wrapping this since it gets shorter
again later, but now I realise it also slipped through the s/create/add/
rebase so it's just busted, and due to another last-minute fix I
actually ended up with an even longer line elsewhere.
I'll tidy all of that up for a v3.
Robin.
next prev parent reply other threads:[~2018-12-06 18:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 19:56 [PATCH v2 0/8] dma-debug cleanup and dynamic allocation Robin Murphy
2018-12-05 19:56 ` [PATCH v2 1/8] dma-debug: Use pr_fmt() Robin Murphy
2018-12-05 19:56 ` [PATCH v2 2/8] dma-debug: Expose nr_total_entries in debugfs Robin Murphy
2018-12-06 14:14 ` Christoph Hellwig
2018-12-05 19:56 ` [PATCH v2 3/8] dma-debug: Refactor dma_debug_entry allocation Robin Murphy
2018-12-06 14:23 ` Christoph Hellwig
2018-12-06 18:10 ` Robin Murphy
2018-12-06 18:46 ` Christoph Hellwig
2018-12-05 19:56 ` [PATCH v2 4/8] dma-debug: Dynamically expand the dma_debug_entry pool Robin Murphy
2018-12-06 14:24 ` Christoph Hellwig
2018-12-06 18:31 ` Robin Murphy [this message]
2018-12-05 19:56 ` [PATCH v2 5/8] dma-debug: Make leak-like behaviour apparent Robin Murphy
2018-12-06 14:24 ` Christoph Hellwig
2018-12-05 19:56 ` [PATCH v2 6/8] x86/dma/amd-gart: Stop resizing dma_debug_entry pool Robin Murphy
2018-12-06 14:25 ` Christoph Hellwig
2018-12-05 19:56 ` [PATCH v2 7/8] dma/debug: Remove dma_debug_resize_entries() Robin Murphy
2018-12-06 14:25 ` Christoph Hellwig
2018-12-05 19:56 ` [PATCH v2 8/8] dma-debug: Batch dma_debug_entry allocation Robin Murphy
2018-12-06 14:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99a5f83b-8362-937e-9e50-116eedb7e593@arm.com \
--to=robin.murphy@arm.com \
--cc=cai@gmx.us \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).