* [PATCH] Staging: nvec: nvec: fixed check style issues
@ 2018-12-16 21:43 Amir Mahdi Ghorbanian
2018-12-16 22:30 ` Joe Perches
2018-12-16 23:02 ` Joey Pabalinas
0 siblings, 2 replies; 3+ messages in thread
From: Amir Mahdi Ghorbanian @ 2018-12-16 21:43 UTC (permalink / raw)
To: marvin24; +Cc: devel, linux-kernel, gregkh, ac100, linux-tegra
Replaced udelay() by the preferred usleep_range() function.
Signed-off-by: Amir Mahdi Ghorbanian <indigoomega021@gmail.com>
---
drivers/staging/nvec/nvec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 08027a3..6f35f92 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -626,7 +626,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
break;
case 2: /* first byte after command */
if (status == (I2C_SL_IRQ | RNW | RCVD)) {
- udelay(33);
+ usleep_range(0, 33);
if (nvec->rx->data[0] != 0x01) {
dev_err(nvec->dev,
"Read without prior read command\n");
@@ -713,7 +713,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
* We experience less incomplete messages with this delay than without
* it, but we don't know why. Help is appreciated.
*/
- udelay(100);
+ usleep_range(0, 100);
return IRQ_HANDLED;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: nvec: nvec: fixed check style issues
2018-12-16 21:43 [PATCH] Staging: nvec: nvec: fixed check style issues Amir Mahdi Ghorbanian
@ 2018-12-16 22:30 ` Joe Perches
2018-12-16 23:02 ` Joey Pabalinas
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2018-12-16 22:30 UTC (permalink / raw)
To: Amir Mahdi Ghorbanian, marvin24
Cc: devel, linux-kernel, gregkh, ac100, linux-tegra
On Sun, 2018-12-16 at 13:43 -0800, Amir Mahdi Ghorbanian wrote:
> Replaced udelay() by the preferred usleep_range() function.
[]
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
[]
> @@ -626,7 +626,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> break;
> case 2: /* first byte after command */
> if (status == (I2C_SL_IRQ | RNW | RCVD)) {
> - udelay(33);
> + usleep_range(0, 33);
Umm, this is not the same outcome.
udelay delays a minimum of 33 usecs.
usleep_range delays from min to max usecs.
kernel/time/timer.c: * usleep_range - Sleep for an approximate time
kernel/time/timer.c- * @min: Minimum time in usecs to sleep
kernel/time/timer.c- * @max: Maximum time in usecs to sleep
kernel/time/timer.c- *
kernel/time/timer.c- * In non-atomic context where the exact wakeup time is flexible, use
kernel/time/timer.c: * usleep_range() instead of udelay(). The sleep improves responsiveness
kernel/time/timer.c- * by avoiding the CPU-hogging busy-wait of udelay(), and the range reduces
kernel/time/timer.c- * power usage by allowing hrtimers to take advantage of an already-
kernel/time/timer.c- * scheduled interrupt instead of scheduling a new one just for this sleep.
kernel/time/timer.c- */
> if (nvec->rx->data[0] != 0x01) {
> dev_err(nvec->dev,
> "Read without prior read command\n");
> @@ -713,7 +713,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> * We experience less incomplete messages with this delay than without
> * it, but we don't know why. Help is appreciated.
> */
> - udelay(100);
> + usleep_range(0, 100);
here too.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: nvec: nvec: fixed check style issues
2018-12-16 21:43 [PATCH] Staging: nvec: nvec: fixed check style issues Amir Mahdi Ghorbanian
2018-12-16 22:30 ` Joe Perches
@ 2018-12-16 23:02 ` Joey Pabalinas
1 sibling, 0 replies; 3+ messages in thread
From: Joey Pabalinas @ 2018-12-16 23:02 UTC (permalink / raw)
To: Amir Mahdi Ghorbanian
Cc: marvin24, devel, linux-kernel, gregkh, ac100, linux-tegra,
Joey Pabalinas
[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]
On Sun, Dec 16, 2018 at 01:43:54PM -0800, Amir Mahdi Ghorbanian wrote:
> Replaced udelay() by the preferred usleep_range() function.
>
> Signed-off-by: Amir Mahdi Ghorbanian <indigoomega021@gmail.com>
Nack, usleep_range isn't for atomic contexts like interrupt handlers.
> ---
> drivers/staging/nvec/nvec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 08027a3..6f35f92 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -626,7 +626,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> break;
> case 2: /* first byte after command */
> if (status == (I2C_SL_IRQ | RNW | RCVD)) {
> - udelay(33);
> + usleep_range(0, 33);
> if (nvec->rx->data[0] != 0x01) {
> dev_err(nvec->dev,
> "Read without prior read command\n");
> @@ -713,7 +713,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> * We experience less incomplete messages with this delay than without
> * it, but we don't know why. Help is appreciated.
> */
> - udelay(100);
> + usleep_range(0, 100);
>
> return IRQ_HANDLED;
> }
> --
> 2.7.4
>
--
Cheers,
Joey Pabalinas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-16 23:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-16 21:43 [PATCH] Staging: nvec: nvec: fixed check style issues Amir Mahdi Ghorbanian
2018-12-16 22:30 ` Joe Perches
2018-12-16 23:02 ` Joey Pabalinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).