* [PATCH] firmware/memmap:Modify memblock_alloc to memblock_alloc_nopanic
@ 2018-12-24 8:41 huang.zijiang
2018-12-24 12:14 ` Mike Rapoport
0 siblings, 1 reply; 2+ messages in thread
From: huang.zijiang @ 2018-12-24 8:41 UTC (permalink / raw)
To: akpm
Cc: rppt, mhocko, sfr, mpe, linux-kernel, xue.zhihong, wang.yi59,
huang.zijiang
From: "huang.zijiang" <huang.zijiang@zte.com.cn>
memblock_alloc never returns NULL because panic never returns
Signed-off-by: huang.zijiang <huang.zijiang@zte.com.cn>
---
drivers/firmware/memmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/memmap.c b/drivers/firmware/memmap.c
index d168c87..ec4fd25 100644
--- a/drivers/firmware/memmap.c
+++ b/drivers/firmware/memmap.c
@@ -333,7 +333,7 @@ int __init firmware_map_add_early(u64 start, u64 end, const char *type)
{
struct firmware_map_entry *entry;
- entry = memblock_alloc(sizeof(struct firmware_map_entry),
+ entry = memblock_alloc_nopanic(sizeof(struct firmware_map_entry),
SMP_CACHE_BYTES);
if (WARN_ON(!entry))
return -ENOMEM;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] firmware/memmap:Modify memblock_alloc to memblock_alloc_nopanic
2018-12-24 8:41 [PATCH] firmware/memmap:Modify memblock_alloc to memblock_alloc_nopanic huang.zijiang
@ 2018-12-24 12:14 ` Mike Rapoport
0 siblings, 0 replies; 2+ messages in thread
From: Mike Rapoport @ 2018-12-24 12:14 UTC (permalink / raw)
To: huang.zijiang
Cc: akpm, rppt, mhocko, sfr, mpe, linux-kernel, xue.zhihong, wang.yi59
On Mon, Dec 24, 2018 at 04:41:22PM +0800, huang.zijiang wrote:
> From: "huang.zijiang" <huang.zijiang@zte.com.cn>
>
> memblock_alloc never returns NULL because panic never returns
>
> Signed-off-by: huang.zijiang <huang.zijiang@zte.com.cn>
Acked-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> drivers/firmware/memmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/memmap.c b/drivers/firmware/memmap.c
> index d168c87..ec4fd25 100644
> --- a/drivers/firmware/memmap.c
> +++ b/drivers/firmware/memmap.c
> @@ -333,7 +333,7 @@ int __init firmware_map_add_early(u64 start, u64 end, const char *type)
> {
> struct firmware_map_entry *entry;
>
> - entry = memblock_alloc(sizeof(struct firmware_map_entry),
> + entry = memblock_alloc_nopanic(sizeof(struct firmware_map_entry),
> SMP_CACHE_BYTES);
> if (WARN_ON(!entry))
> return -ENOMEM;
> --
> 1.8.3.1
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-24 12:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-24 8:41 [PATCH] firmware/memmap:Modify memblock_alloc to memblock_alloc_nopanic huang.zijiang
2018-12-24 12:14 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).