* [PATCH] selftests/networking: remove timestamping clean target
@ 2019-01-08 9:25 Anders Roxell
2019-01-31 19:07 ` Anders Roxell
0 siblings, 1 reply; 2+ messages in thread
From: Anders Roxell @ 2019-01-08 9:25 UTC (permalink / raw)
To: davem, shuah; +Cc: linux-kselftest, linux-kernel, Anders Roxell
Commit cda261f421ba ("selftests: add txtimestamp kselftest") introduced
a warning:
Makefile:14: warning: overriding recipe for target 'clean'
../../lib.mk:137: warning: ignoring old recipe for target 'clean'
Theres no need for timestamping to have its own 'clean' target. The
lib.mk file's 'clean' target gets included to the timestamping Makefile
and that should be enough.
Fixes: cda261f421ba ("selftests: add txtimestamp kselftest")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
tools/testing/selftests/networking/timestamping/Makefile | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/networking/timestamping/Makefile b/tools/testing/selftests/networking/timestamping/Makefile
index 9050eeea5f5f..1de8bd8ccf5d 100644
--- a/tools/testing/selftests/networking/timestamping/Makefile
+++ b/tools/testing/selftests/networking/timestamping/Makefile
@@ -9,6 +9,3 @@ all: $(TEST_PROGS)
top_srcdir = ../../../../..
KSFT_KHDR_INSTALL := 1
include ../../lib.mk
-
-clean:
- rm -fr $(TEST_GEN_FILES)
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] selftests/networking: remove timestamping clean target
2019-01-08 9:25 [PATCH] selftests/networking: remove timestamping clean target Anders Roxell
@ 2019-01-31 19:07 ` Anders Roxell
0 siblings, 0 replies; 2+ messages in thread
From: Anders Roxell @ 2019-01-31 19:07 UTC (permalink / raw)
To: David Miller, Shuah Khan
Cc: open list:KERNEL SELFTEST FRAMEWORK, Linux Kernel Mailing List
On Tue, 8 Jan 2019 at 10:25, Anders Roxell <anders.roxell@linaro.org> wrote:
>
> Commit cda261f421ba ("selftests: add txtimestamp kselftest") introduced
> a warning:
>
> Makefile:14: warning: overriding recipe for target 'clean'
> ../../lib.mk:137: warning: ignoring old recipe for target 'clean'
>
> Theres no need for timestamping to have its own 'clean' target. The
> lib.mk file's 'clean' target gets included to the timestamping Makefile
> and that should be enough.
>
> Fixes: cda261f421ba ("selftests: add txtimestamp kselftest")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> tools/testing/selftests/networking/timestamping/Makefile | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/networking/timestamping/Makefile b/tools/testing/selftests/networking/timestamping/Makefile
> index 9050eeea5f5f..1de8bd8ccf5d 100644
> --- a/tools/testing/selftests/networking/timestamping/Makefile
> +++ b/tools/testing/selftests/networking/timestamping/Makefile
> @@ -9,6 +9,3 @@ all: $(TEST_PROGS)
> top_srcdir = ../../../../..
> KSFT_KHDR_INSTALL := 1
> include ../../lib.mk
> -
> -clean:
> - rm -fr $(TEST_GEN_FILES)
> --
> 2.20.1
>
Does this make sense?
Cheers,
Anders
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-31 19:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-08 9:25 [PATCH] selftests/networking: remove timestamping clean target Anders Roxell
2019-01-31 19:07 ` Anders Roxell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).