* [PATCH v2 0/2] Support for eMMC in AM65x-evm
@ 2019-01-10 7:33 Faiz Abbas
2019-01-10 7:33 ` [PATCH v2 1/2] arm64: dts: ti: k3-am654: Add Support for MMC/SD Faiz Abbas
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Faiz Abbas @ 2019-01-10 7:33 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-arm-kernel
Cc: mark.rutland, robh+dt, nm, t-kristo, faiz_abbas
The following patches add eMMC support on TI's AM65x-evm.
v2:
1. The SD card node is under debug for some usecases.
Only upstreaming eMMC support for now.
2. Rebased to latest mainline.
3. Removed status = "disabled" from dtsi patch
4. Fixed node name to not include '_'s
Faiz Abbas (2):
arm64: dts: ti: k3-am654: Add Support for MMC/SD
arm64: dts: ti: k3-am654-base-board: Add MMC/SD support
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 13 ++++++++++
.../arm64/boot/dts/ti/k3-am654-base-board.dts | 25 +++++++++++++++++++
2 files changed, 38 insertions(+)
--
2.19.2
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/2] arm64: dts: ti: k3-am654: Add Support for MMC/SD
2019-01-10 7:33 [PATCH v2 0/2] Support for eMMC in AM65x-evm Faiz Abbas
@ 2019-01-10 7:33 ` Faiz Abbas
2019-01-15 14:27 ` Nishanth Menon
2019-01-10 7:33 ` [PATCH v2 2/2] arm64: dts: ti: k3-am654-base-board: Add MMC support Faiz Abbas
2019-01-15 14:29 ` [PATCH v2 0/2] Support for eMMC in AM65x-evm Nishanth Menon
2 siblings, 1 reply; 7+ messages in thread
From: Faiz Abbas @ 2019-01-10 7:33 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-arm-kernel
Cc: mark.rutland, robh+dt, nm, t-kristo, faiz_abbas
Add support for the Secure Digital Host Controller Interface (SDHCI)
present on TI's AM654 SOCs. It is compatible with eMMC5.1 Host
Specifications and SDHC Standard Specification 4.10.
Enable only upto HS200 speed mode.
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index 272cf8fc8d30..78e1bb56adee 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -191,4 +191,17 @@
#address-cells = <1>;
#size-cells = <0>;
};
+
+ sdhci0: sdhci@4f80000 {
+ compatible = "ti,am654-sdhci-5.1";
+ reg = <0x0 0x4f80000 0x0 0x260>, <0x0 0x4f90000 0x0 0x134>;
+ power-domains = <&k3_pds 47>;
+ clocks = <&k3_clks 47 0>, <&k3_clks 47 1>;
+ clock-names = "clk_ahb", "clk_xin";
+ interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
+ mmc-ddr-1_8v;
+ mmc-hs200-1_8v;
+ ti,otap-del-sel = <0x2>;
+ ti,trm-icp = <0x8>;
+ };
};
--
2.19.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] arm64: dts: ti: k3-am654-base-board: Add MMC support
2019-01-10 7:33 [PATCH v2 0/2] Support for eMMC in AM65x-evm Faiz Abbas
2019-01-10 7:33 ` [PATCH v2 1/2] arm64: dts: ti: k3-am654: Add Support for MMC/SD Faiz Abbas
@ 2019-01-10 7:33 ` Faiz Abbas
2019-01-15 14:28 ` Nishanth Menon
2019-01-15 14:29 ` [PATCH v2 0/2] Support for eMMC in AM65x-evm Nishanth Menon
2 siblings, 1 reply; 7+ messages in thread
From: Faiz Abbas @ 2019-01-10 7:33 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-arm-kernel
Cc: mark.rutland, robh+dt, nm, t-kristo, faiz_abbas
On the am654x-evm, the sdhci0 node is connected to an eMMC. Add node and
pinmux for the same.
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
.../arm64/boot/dts/ti/k3-am654-base-board.dts | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
index e41fc3a5987b..11e9a2a43dfc 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
@@ -69,6 +69,23 @@
AM65X_IOPAD(0x01bc, PIN_OUTPUT, 0) /* (AG13) SPI0_CS0 */
>;
};
+
+ main_mmc0_pins_default: main-mmc0-pins-default {
+ pinctrl-single,pins = <
+ AM65X_IOPAD(0x01a8, PIN_INPUT_PULLDOWN, 0) /* (B25) MMC0_CLK */
+ AM65X_IOPAD(0x01ac, PIN_INPUT_PULLUP, 0) /* (B27) MMC0_CMD */
+ AM65X_IOPAD(0x01a4, PIN_INPUT_PULLUP, 0) /* (A26) MMC0_DAT0 */
+ AM65X_IOPAD(0x01a0, PIN_INPUT_PULLUP, 0) /* (E25) MMC0_DAT1 */
+ AM65X_IOPAD(0x019c, PIN_INPUT_PULLUP, 0) /* (C26) MMC0_DAT2 */
+ AM65X_IOPAD(0x0198, PIN_INPUT_PULLUP, 0) /* (A25) MMC0_DAT3 */
+ AM65X_IOPAD(0x0194, PIN_INPUT_PULLUP, 0) /* (E24) MMC0_DAT4 */
+ AM65X_IOPAD(0x0190, PIN_INPUT_PULLUP, 0) /* (A24) MMC0_DAT5 */
+ AM65X_IOPAD(0x018c, PIN_INPUT_PULLUP, 0) /* (B26) MMC0_DAT6 */
+ AM65X_IOPAD(0x0188, PIN_INPUT_PULLUP, 0) /* (D25) MMC0_DAT7 */
+ AM65X_IOPAD(0x01b4, PIN_INPUT_PULLUP, 0) /* (A23) MMC0_SDCD */
+ AM65X_IOPAD(0x01b0, PIN_INPUT, 0) /* (C25) MMC0_DS */
+ >;
+ };
};
&main_pmx1 {
@@ -163,3 +180,11 @@
#size-cells= <1>;
};
};
+
+&sdhci0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&main_mmc0_pins_default>;
+ bus-width = <8>;
+ non-removable;
+ ti,driver-strength-ohm = <50>;
+};
--
2.19.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: ti: k3-am654: Add Support for MMC/SD
2019-01-10 7:33 ` [PATCH v2 1/2] arm64: dts: ti: k3-am654: Add Support for MMC/SD Faiz Abbas
@ 2019-01-15 14:27 ` Nishanth Menon
0 siblings, 0 replies; 7+ messages in thread
From: Nishanth Menon @ 2019-01-15 14:27 UTC (permalink / raw)
To: Faiz Abbas
Cc: linux-kernel, devicetree, linux-arm-kernel, mark.rutland,
robh+dt, t-kristo
$subject claims MMC/SD, while the patch is specific for emmc and HS200?
could you fix that up please?
On 13:03-20190110, Faiz Abbas wrote:
> Add support for the Secure Digital Host Controller Interface (SDHCI)
> present on TI's AM654 SOCs. It is compatible with eMMC5.1 Host
> Specifications and SDHC Standard Specification 4.10.
>
> Enable only upto HS200 speed mode.
>
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index 272cf8fc8d30..78e1bb56adee 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -191,4 +191,17 @@
> #address-cells = <1>;
> #size-cells = <0>;
> };
> +
> + sdhci0: sdhci@4f80000 {
> + compatible = "ti,am654-sdhci-5.1";
> + reg = <0x0 0x4f80000 0x0 0x260>, <0x0 0x4f90000 0x0 0x134>;
> + power-domains = <&k3_pds 47>;
> + clocks = <&k3_clks 47 0>, <&k3_clks 47 1>;
> + clock-names = "clk_ahb", "clk_xin";
> + interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
> + mmc-ddr-1_8v;
> + mmc-hs200-1_8v;
> + ti,otap-del-sel = <0x2>;
> + ti,trm-icp = <0x8>;
> + };
> };
> --
> 2.19.2
>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: ti: k3-am654-base-board: Add MMC support
2019-01-10 7:33 ` [PATCH v2 2/2] arm64: dts: ti: k3-am654-base-board: Add MMC support Faiz Abbas
@ 2019-01-15 14:28 ` Nishanth Menon
0 siblings, 0 replies; 7+ messages in thread
From: Nishanth Menon @ 2019-01-15 14:28 UTC (permalink / raw)
To: Faiz Abbas
Cc: linux-kernel, devicetree, linux-arm-kernel, mark.rutland,
robh+dt, t-kristo
Similar problem here as well.. $subject probably needs to be explicit
about eMMC?
On 13:03-20190110, Faiz Abbas wrote:
> On the am654x-evm, the sdhci0 node is connected to an eMMC. Add node and
> pinmux for the same.
>
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> ---
> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index e41fc3a5987b..11e9a2a43dfc 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -69,6 +69,23 @@
> AM65X_IOPAD(0x01bc, PIN_OUTPUT, 0) /* (AG13) SPI0_CS0 */
> >;
> };
> +
> + main_mmc0_pins_default: main-mmc0-pins-default {
> + pinctrl-single,pins = <
> + AM65X_IOPAD(0x01a8, PIN_INPUT_PULLDOWN, 0) /* (B25) MMC0_CLK */
> + AM65X_IOPAD(0x01ac, PIN_INPUT_PULLUP, 0) /* (B27) MMC0_CMD */
> + AM65X_IOPAD(0x01a4, PIN_INPUT_PULLUP, 0) /* (A26) MMC0_DAT0 */
> + AM65X_IOPAD(0x01a0, PIN_INPUT_PULLUP, 0) /* (E25) MMC0_DAT1 */
> + AM65X_IOPAD(0x019c, PIN_INPUT_PULLUP, 0) /* (C26) MMC0_DAT2 */
> + AM65X_IOPAD(0x0198, PIN_INPUT_PULLUP, 0) /* (A25) MMC0_DAT3 */
> + AM65X_IOPAD(0x0194, PIN_INPUT_PULLUP, 0) /* (E24) MMC0_DAT4 */
> + AM65X_IOPAD(0x0190, PIN_INPUT_PULLUP, 0) /* (A24) MMC0_DAT5 */
> + AM65X_IOPAD(0x018c, PIN_INPUT_PULLUP, 0) /* (B26) MMC0_DAT6 */
> + AM65X_IOPAD(0x0188, PIN_INPUT_PULLUP, 0) /* (D25) MMC0_DAT7 */
> + AM65X_IOPAD(0x01b4, PIN_INPUT_PULLUP, 0) /* (A23) MMC0_SDCD */
> + AM65X_IOPAD(0x01b0, PIN_INPUT, 0) /* (C25) MMC0_DS */
> + >;
> + };
> };
>
> &main_pmx1 {
> @@ -163,3 +180,11 @@
> #size-cells= <1>;
> };
> };
> +
> +&sdhci0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&main_mmc0_pins_default>;
> + bus-width = <8>;
> + non-removable;
> + ti,driver-strength-ohm = <50>;
> +};
> --
> 2.19.2
>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 0/2] Support for eMMC in AM65x-evm
2019-01-10 7:33 [PATCH v2 0/2] Support for eMMC in AM65x-evm Faiz Abbas
2019-01-10 7:33 ` [PATCH v2 1/2] arm64: dts: ti: k3-am654: Add Support for MMC/SD Faiz Abbas
2019-01-10 7:33 ` [PATCH v2 2/2] arm64: dts: ti: k3-am654-base-board: Add MMC support Faiz Abbas
@ 2019-01-15 14:29 ` Nishanth Menon
2019-01-17 9:05 ` Faiz Abbas
2 siblings, 1 reply; 7+ messages in thread
From: Nishanth Menon @ 2019-01-15 14:29 UTC (permalink / raw)
To: Faiz Abbas
Cc: linux-kernel, devicetree, linux-arm-kernel, mark.rutland,
robh+dt, t-kristo
On 13:03-20190110, Faiz Abbas wrote:
> The following patches add eMMC support on TI's AM65x-evm.
>
> v2:
> 1. The SD card node is under debug for some usecases.
> Only upstreaming eMMC support for now.
> 2. Rebased to latest mainline.
> 3. Removed status = "disabled" from dtsi patch
> 4. Fixed node name to not include '_'s
>
> Faiz Abbas (2):
> arm64: dts: ti: k3-am654: Add Support for MMC/SD
> arm64: dts: ti: k3-am654-base-board: Add MMC/SD support
Once the $subject changes in the above two patches (should be emmc
instead of MMC/SD):
Acked-by: Nishanth Menon <nm@ti.com>
>
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 13 ++++++++++
> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 25 +++++++++++++++++++
> 2 files changed, 38 insertions(+)
>
> --
> 2.19.2
>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 0/2] Support for eMMC in AM65x-evm
2019-01-15 14:29 ` [PATCH v2 0/2] Support for eMMC in AM65x-evm Nishanth Menon
@ 2019-01-17 9:05 ` Faiz Abbas
0 siblings, 0 replies; 7+ messages in thread
From: Faiz Abbas @ 2019-01-17 9:05 UTC (permalink / raw)
To: Nishanth Menon
Cc: linux-kernel, devicetree, linux-arm-kernel, mark.rutland,
robh+dt, t-kristo
Nishanth,
On 15/01/19 7:59 PM, Nishanth Menon wrote:
> On 13:03-20190110, Faiz Abbas wrote:
>> The following patches add eMMC support on TI's AM65x-evm.
>>
>> v2:
>> 1. The SD card node is under debug for some usecases.
>> Only upstreaming eMMC support for now.
>> 2. Rebased to latest mainline.
>> 3. Removed status = "disabled" from dtsi patch
>> 4. Fixed node name to not include '_'s
>>
>> Faiz Abbas (2):
>> arm64: dts: ti: k3-am654: Add Support for MMC/SD
>> arm64: dts: ti: k3-am654-base-board: Add MMC/SD support
>
> Once the $subject changes in the above two patches (should be emmc
> instead of MMC/SD):
>
> Acked-by: Nishanth Menon <nm@ti.com>
>
Ok. Sending next version with fixes.
Thanks,
Faiz
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-01-17 9:02 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10 7:33 [PATCH v2 0/2] Support for eMMC in AM65x-evm Faiz Abbas
2019-01-10 7:33 ` [PATCH v2 1/2] arm64: dts: ti: k3-am654: Add Support for MMC/SD Faiz Abbas
2019-01-15 14:27 ` Nishanth Menon
2019-01-10 7:33 ` [PATCH v2 2/2] arm64: dts: ti: k3-am654-base-board: Add MMC support Faiz Abbas
2019-01-15 14:28 ` Nishanth Menon
2019-01-15 14:29 ` [PATCH v2 0/2] Support for eMMC in AM65x-evm Nishanth Menon
2019-01-17 9:05 ` Faiz Abbas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).