[PATCH] tracing: uprobes: fix typo in pr_fmt string

[PATCH] tracing: uprobes: fix typo in pr_fmt string

[Andreas Ziegler]

The subsystem-specific message prefix for uprobes was also
"trace_kprobe: " instead of "trace_uprobe: " as described in
the original commit message.

Fixes: 7257634135c24 ("tracing/probe: Show subsystem name in messages")
Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
---
 kernel/trace/trace_uprobe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index e335576b9411..19a1a8e19062 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -5,7 +5,7 @@
  * Copyright (C) IBM Corporation, 2010-2012
  * Author:	Srikar Dronamraju <srikar@linux.vnet.ibm.com>
  */
-#define pr_fmt(fmt)	"trace_kprobe: " fmt
+#define pr_fmt(fmt)	"trace_uprobe: " fmt
 
 #include <linux/ctype.h>
 #include <linux/module.h>
-- 
2.17.1

Re: [PATCH] tracing: uprobes: fix typo in pr_fmt string

[Steven Rostedt]

Masami,

Can you give an Acked-by?

Thanks!

-- Steve


On Thu, 17 Jan 2019 14:30:23 +0100
Andreas Ziegler <andreas.ziegler@fau.de> wrote:

> The subsystem-specific message prefix for uprobes was also
> "trace_kprobe: " instead of "trace_uprobe: " as described in
> the original commit message.
> 
> Fixes: 7257634135c24 ("tracing/probe: Show subsystem name in messages")
> Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
> ---
>  kernel/trace/trace_uprobe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index e335576b9411..19a1a8e19062 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -5,7 +5,7 @@
>   * Copyright (C) IBM Corporation, 2010-2012
>   * Author:	Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>   */
> -#define pr_fmt(fmt)	"trace_kprobe: " fmt
> +#define pr_fmt(fmt)	"trace_uprobe: " fmt
>  
>  #include <linux/ctype.h>
>  #include <linux/module.h>

Re: [PATCH] tracing: uprobes: fix typo in pr_fmt string

[Masami Hiramatsu]

On Thu, 17 Jan 2019 09:53:16 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> Masami,
> 
> Can you give an Acked-by?

Of course!

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you Andreas!

> 
> Thanks!
> 
> -- Steve
> 
> 
> On Thu, 17 Jan 2019 14:30:23 +0100
> Andreas Ziegler <andreas.ziegler@fau.de> wrote:
> 
> > The subsystem-specific message prefix for uprobes was also
> > "trace_kprobe: " instead of "trace_uprobe: " as described in
> > the original commit message.
> > 
> > Fixes: 7257634135c24 ("tracing/probe: Show subsystem name in messages")
> > Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
> > ---
> >  kernel/trace/trace_uprobe.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> > index e335576b9411..19a1a8e19062 100644
> > --- a/kernel/trace/trace_uprobe.c
> > +++ b/kernel/trace/trace_uprobe.c
> > @@ -5,7 +5,7 @@
> >   * Copyright (C) IBM Corporation, 2010-2012
> >   * Author:	Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> >   */
> > -#define pr_fmt(fmt)	"trace_kprobe: " fmt
> > +#define pr_fmt(fmt)	"trace_uprobe: " fmt
> >  
> >  #include <linux/ctype.h>
> >  #include <linux/module.h>
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>

Re: [PATCH] tracing: uprobes: fix typo in pr_fmt string

[Joe Perches]

On Thu, 2019-01-17 at 14:30 +0100, Andreas Ziegler wrote:
> The subsystem-specific message prefix for uprobes was also
> "trace_kprobe: " instead of "trace_uprobe: " as described in
> the original commit message.
[]
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
[]
> @@ -5,7 +5,7 @@
>   * Copyright (C) IBM Corporation, 2010-2012
>   * Author:	Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>   */
> -#define pr_fmt(fmt)	"trace_kprobe: " fmt
> +#define pr_fmt(fmt)	"trace_uprobe: " fmt

Perhaps use the more common KBUILD_MODNAME instead

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt