* [PATCH] tracing: uprobes: fix typo in pr_fmt string
@ 2019-01-17 13:30 Andreas Ziegler
2019-01-17 14:53 ` Steven Rostedt
2019-01-17 20:42 ` Joe Perches
0 siblings, 2 replies; 4+ messages in thread
From: Andreas Ziegler @ 2019-01-17 13:30 UTC (permalink / raw)
To: Steven Rostedt
Cc: Ingo Molnar, Masami Hiramatsu, linux-kernel, Andreas Ziegler
The subsystem-specific message prefix for uprobes was also
"trace_kprobe: " instead of "trace_uprobe: " as described in
the original commit message.
Fixes: 7257634135c24 ("tracing/probe: Show subsystem name in messages")
Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
---
kernel/trace/trace_uprobe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index e335576b9411..19a1a8e19062 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -5,7 +5,7 @@
* Copyright (C) IBM Corporation, 2010-2012
* Author: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
*/
-#define pr_fmt(fmt) "trace_kprobe: " fmt
+#define pr_fmt(fmt) "trace_uprobe: " fmt
#include <linux/ctype.h>
#include <linux/module.h>
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tracing: uprobes: fix typo in pr_fmt string
2019-01-17 13:30 [PATCH] tracing: uprobes: fix typo in pr_fmt string Andreas Ziegler
@ 2019-01-17 14:53 ` Steven Rostedt
2019-01-17 23:28 ` Masami Hiramatsu
2019-01-17 20:42 ` Joe Perches
1 sibling, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2019-01-17 14:53 UTC (permalink / raw)
To: Andreas Ziegler; +Cc: Ingo Molnar, Masami Hiramatsu, linux-kernel
Masami,
Can you give an Acked-by?
Thanks!
-- Steve
On Thu, 17 Jan 2019 14:30:23 +0100
Andreas Ziegler <andreas.ziegler@fau.de> wrote:
> The subsystem-specific message prefix for uprobes was also
> "trace_kprobe: " instead of "trace_uprobe: " as described in
> the original commit message.
>
> Fixes: 7257634135c24 ("tracing/probe: Show subsystem name in messages")
> Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
> ---
> kernel/trace/trace_uprobe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index e335576b9411..19a1a8e19062 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -5,7 +5,7 @@
> * Copyright (C) IBM Corporation, 2010-2012
> * Author: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> */
> -#define pr_fmt(fmt) "trace_kprobe: " fmt
> +#define pr_fmt(fmt) "trace_uprobe: " fmt
>
> #include <linux/ctype.h>
> #include <linux/module.h>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tracing: uprobes: fix typo in pr_fmt string
2019-01-17 13:30 [PATCH] tracing: uprobes: fix typo in pr_fmt string Andreas Ziegler
2019-01-17 14:53 ` Steven Rostedt
@ 2019-01-17 20:42 ` Joe Perches
1 sibling, 0 replies; 4+ messages in thread
From: Joe Perches @ 2019-01-17 20:42 UTC (permalink / raw)
To: Andreas Ziegler, Steven Rostedt
Cc: Ingo Molnar, Masami Hiramatsu, linux-kernel
On Thu, 2019-01-17 at 14:30 +0100, Andreas Ziegler wrote:
> The subsystem-specific message prefix for uprobes was also
> "trace_kprobe: " instead of "trace_uprobe: " as described in
> the original commit message.
[]
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
[]
> @@ -5,7 +5,7 @@
> * Copyright (C) IBM Corporation, 2010-2012
> * Author: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> */
> -#define pr_fmt(fmt) "trace_kprobe: " fmt
> +#define pr_fmt(fmt) "trace_uprobe: " fmt
Perhaps use the more common KBUILD_MODNAME instead
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tracing: uprobes: fix typo in pr_fmt string
2019-01-17 14:53 ` Steven Rostedt
@ 2019-01-17 23:28 ` Masami Hiramatsu
0 siblings, 0 replies; 4+ messages in thread
From: Masami Hiramatsu @ 2019-01-17 23:28 UTC (permalink / raw)
To: Steven Rostedt
Cc: Andreas Ziegler, Ingo Molnar, Masami Hiramatsu, linux-kernel
On Thu, 17 Jan 2019 09:53:16 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> Masami,
>
> Can you give an Acked-by?
Of course!
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you Andreas!
>
> Thanks!
>
> -- Steve
>
>
> On Thu, 17 Jan 2019 14:30:23 +0100
> Andreas Ziegler <andreas.ziegler@fau.de> wrote:
>
> > The subsystem-specific message prefix for uprobes was also
> > "trace_kprobe: " instead of "trace_uprobe: " as described in
> > the original commit message.
> >
> > Fixes: 7257634135c24 ("tracing/probe: Show subsystem name in messages")
> > Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
> > ---
> > kernel/trace/trace_uprobe.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> > index e335576b9411..19a1a8e19062 100644
> > --- a/kernel/trace/trace_uprobe.c
> > +++ b/kernel/trace/trace_uprobe.c
> > @@ -5,7 +5,7 @@
> > * Copyright (C) IBM Corporation, 2010-2012
> > * Author: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> > */
> > -#define pr_fmt(fmt) "trace_kprobe: " fmt
> > +#define pr_fmt(fmt) "trace_uprobe: " fmt
> >
> > #include <linux/ctype.h>
> > #include <linux/module.h>
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-17 23:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-17 13:30 [PATCH] tracing: uprobes: fix typo in pr_fmt string Andreas Ziegler
2019-01-17 14:53 ` Steven Rostedt
2019-01-17 23:28 ` Masami Hiramatsu
2019-01-17 20:42 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).