[PATCH] ARM: dts: n900: fix mmc1 card detect gpio polarity

[PATCH] ARM: dts: n900: fix mmc1 card detect gpio polarity

[Arthur Demchenkov]

Wrong polarity of card detect GPIO pin leads to the system not
booting from external mmc, if the back cover of N900 is closed.
When the cover is open the system boots fine.

This wasn't noticed before, because of a bug, which was fixed
by commit e63201f19 (mmc: omap_hsmmc: Delete platform data GPIO
CD and WP).

Kernels up to 4.19 ignored the card detect GPIO from DT.
---
 arch/arm/boot/dts/omap3-n900.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index 182a53991c90..826920e6b878 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -814,7 +814,7 @@
 	/* For debugging, it is often good idea to remove this GPIO.
 	   It means you can remove back cover (to reboot by removing
 	   battery) and still use the MMC card. */
-	cd-gpios = <&gpio6 0 GPIO_ACTIVE_HIGH>; /* 160 */
+	cd-gpios = <&gpio6 0 GPIO_ACTIVE_LOW>; /* 160 */
 };
 
 /* most boards use vaux3, only some old versions use vmmc2 instead */
-- 
2.11.0

Re: [PATCH] ARM: dts: n900: fix mmc1 card detect gpio polarity

[Tony Lindgren]

Hi,

* Arthur Demchenkov <spinal.by@gmail.com> [190121 03:22]:
> Wrong polarity of card detect GPIO pin leads to the system not
> booting from external mmc, if the back cover of N900 is closed.
> When the cover is open the system boots fine.
> 
> This wasn't noticed before, because of a bug, which was fixed
> by commit e63201f19 (mmc: omap_hsmmc: Delete platform data GPIO
> CD and WP).

Aaro, does this work for your test case too?

> Kernels up to 4.19 ignored the card detect GPIO from DT.

Hmm so should this have a Fixes tag or not?

Regards,

Tony

>  arch/arm/boot/dts/omap3-n900.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index 182a53991c90..826920e6b878 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -814,7 +814,7 @@
>  	/* For debugging, it is often good idea to remove this GPIO.
>  	   It means you can remove back cover (to reboot by removing
>  	   battery) and still use the MMC card. */
> -	cd-gpios = <&gpio6 0 GPIO_ACTIVE_HIGH>; /* 160 */
> +	cd-gpios = <&gpio6 0 GPIO_ACTIVE_LOW>; /* 160 */
>  };
>  
>  /* most boards use vaux3, only some old versions use vmmc2 instead */
> -- 
> 2.11.0
> 

Re: [PATCH] ARM: dts: n900: fix mmc1 card detect gpio polarity

[Fabio Estevam]

On Mon, Jan 21, 2019 at 5:43 AM Arthur Demchenkov <spinal.by@gmail.com> wrote:
>
> Wrong polarity of card detect GPIO pin leads to the system not
> booting from external mmc, if the back cover of N900 is closed.
> When the cover is open the system boots fine.
>
> This wasn't noticed before, because of a bug, which was fixed
> by commit e63201f19 (mmc: omap_hsmmc: Delete platform data GPIO
> CD and WP).
>
> Kernels up to 4.19 ignored the card detect GPIO from DT.

Signed-off-by tag is missing.

Re: [PATCH] ARM: dts: n900: fix mmc1 card detect gpio polarity

[Aaro Koskinen]

Hi,

On Mon, Jan 21, 2019 at 09:11:01AM -0800, Tony Lindgren wrote:
> * Arthur Demchenkov <spinal.by@gmail.com> [190121 03:22]:
> > Wrong polarity of card detect GPIO pin leads to the system not
> > booting from external mmc, if the back cover of N900 is closed.
> > When the cover is open the system boots fine.
> > 
> > This wasn't noticed before, because of a bug, which was fixed
> > by commit e63201f19 (mmc: omap_hsmmc: Delete platform data GPIO
> > CD and WP).
> 
> Aaro, does this work for your test case too?

Yeah..

> > Kernels up to 4.19 ignored the card detect GPIO from DT.
> 
> Hmm so should this have a Fixes tag or not?

I think it should as v4.20 is broken.

A.

> Regards,
> 
> Tony
> 
> >  arch/arm/boot/dts/omap3-n900.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> > index 182a53991c90..826920e6b878 100644
> > --- a/arch/arm/boot/dts/omap3-n900.dts
> > +++ b/arch/arm/boot/dts/omap3-n900.dts
> > @@ -814,7 +814,7 @@
> >  	/* For debugging, it is often good idea to remove this GPIO.
> >  	   It means you can remove back cover (to reboot by removing
> >  	   battery) and still use the MMC card. */
> > -	cd-gpios = <&gpio6 0 GPIO_ACTIVE_HIGH>; /* 160 */
> > +	cd-gpios = <&gpio6 0 GPIO_ACTIVE_LOW>; /* 160 */
> >  };
> >  
> >  /* most boards use vaux3, only some old versions use vmmc2 instead */
> > -- 
> > 2.11.0
> > 

Re: [PATCH] ARM: dts: n900: fix mmc1 card detect gpio polarity

[Tony Lindgren]

* Fabio Estevam <festevam@gmail.com> [190121 17:52]:
> On Mon, Jan 21, 2019 at 5:43 AM Arthur Demchenkov <spinal.by@gmail.com> wrote:
> >
> > Wrong polarity of card detect GPIO pin leads to the system not
> > booting from external mmc, if the back cover of N900 is closed.
> > When the cover is open the system boots fine.
> >
> > This wasn't noticed before, because of a bug, which was fixed
> > by commit e63201f19 (mmc: omap_hsmmc: Delete platform data GPIO
> > CD and WP).
> >
> > Kernels up to 4.19 ignored the card detect GPIO from DT.
> 
> Signed-off-by tag is missing.

Arthur, please reply with your Signed-off-by for this
thread so I can apply it. That is unless you want to
repost the patch for updated comments etc.

Regards,

Tony

Re: [PATCH] ARM: dts: n900: fix mmc1 card detect gpio polarity

[Arthur D.]

Signed-off-by: Arthur Demchenkov <spinal.by@gmail.com>

Re: [PATCH] ARM: dts: n900: fix mmc1 card detect gpio polarity

[Tony Lindgren]

* Arthur D. <spinal.by@gmail.com> [190122 04:59]:
> Signed-off-by: Arthur Demchenkov <spinal.by@gmail.com>

Thanks applying into omap-for-v5.0/fixes.

Tony