linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it.
@ 2019-01-22 14:13 Ronald Tschalär
  2019-01-22 21:10 ` Laurent Pinchart
  2019-01-23  8:45 ` Lukas Wunner
  0 siblings, 2 replies; 17+ messages in thread
From: Ronald Tschalär @ 2019-01-22 14:13 UTC (permalink / raw)
  To: Andrzej Hajda, Inki Dae; +Cc: dri-devel, Laurent Pinchart, linux-kernel

commit d6abe6df706c66d803e6dd4fe98c1b6b7f125a56 (drm/bridge:
sil_sii8620: do not have a dependency of RC_CORE) added a dependency on
INPUT. However, this causes problems with other drivers, in particular
an input driver that depends on MFD_INTEL_LPSS_PCI (to be added in a
future commit):

  drivers/clk/Kconfig:9:error: recursive dependency detected!
  drivers/clk/Kconfig:9:        symbol COMMON_CLK is selected by MFD_INTEL_LPSS
  drivers/mfd/Kconfig:566:      symbol MFD_INTEL_LPSS is selected by MFD_INTEL_LPSS_PCI
  drivers/mfd/Kconfig:580:      symbol MFD_INTEL_LPSS_PCI is implied by KEYBOARD_APPLESPI
  drivers/input/keyboard/Kconfig:73:    symbol KEYBOARD_APPLESPI depends on INPUT
  drivers/input/Kconfig:8:      symbol INPUT is selected by DRM_SIL_SII8620
  drivers/gpu/drm/bridge/Kconfig:83:    symbol DRM_SIL_SII8620 depends on DRM_BRIDGE
  drivers/gpu/drm/bridge/Kconfig:1:     symbol DRM_BRIDGE is selected by DRM_PL111
  drivers/gpu/drm/pl111/Kconfig:1:      symbol DRM_PL111 depends on COMMON_CLK

According to the docs, select should only be used for non-visible
symbols. Furthermore almost all other references to INPUT throughout the
kernel config are depends, not selects. Hence this change.

CC: Inki Dae <inki.dae@samsung.com>
CC: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Ronald Tschalär <ronald@innovation.ch>
---
 drivers/gpu/drm/bridge/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 2fee47b0d50b..eabedc83f25c 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -83,9 +83,9 @@ config DRM_PARADE_PS8622
 config DRM_SIL_SII8620
 	tristate "Silicon Image SII8620 HDMI/MHL bridge"
 	depends on OF
+	depends on INPUT
 	select DRM_KMS_HELPER
 	imply EXTCON
-	select INPUT
 	select RC_CORE
 	help
 	  Silicon Image SII8620 HDMI/MHL bridge chip driver.
-- 
2.20.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2019-04-07  1:30 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-22 14:13 [PATCH] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it Ronald Tschalär
2019-01-22 21:10 ` Laurent Pinchart
2019-01-24  7:23   ` Life is hard, and then you die
2019-01-23  8:45 ` Lukas Wunner
2019-01-23 22:03   ` Dmitry Torokhov
2019-01-23 22:17     ` Laurent Pinchart
2019-01-23 22:21       ` Dmitry Torokhov
2019-01-23 22:22         ` Laurent Pinchart
2019-01-24  7:21           ` Life is hard, and then you die
2019-01-24  8:24             ` [PATCH v2] drm/bridge: sil_sii8620: make remote control optional Ronald Tschalär
2019-01-24  9:13             ` [PATCH] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it Lukas Wunner
2019-01-25  1:33             ` [PATCH v2] drm/bridge: sil_sii8620: make remote control optional Ronald Tschalär
2019-01-28 10:53               ` Andrzej Hajda
2019-03-28  1:07                 ` Life is hard, and then you die
2019-03-04  2:13               ` Life is hard, and then you die
2019-03-04  7:13                 ` Andrzej Hajda
2019-04-07  1:30               ` [PATCH v3] " Ronald Tschalär

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).