* [PATCH -next] selftests: bpf: remove duplicated include
@ 2019-01-25 2:46 YueHaibing
2019-01-25 23:01 ` Song Liu
2019-01-28 23:25 ` Daniel Borkmann
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-01-25 2:46 UTC (permalink / raw)
To: ast, daniel, shuah; +Cc: linux-kernel, linux-kselftest, netdev, YueHaibing
Remove duplicated include.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
tools/testing/selftests/bpf/test_flow_dissector.c | 2 --
tools/testing/selftests/bpf/test_maps.c | 1 -
tools/testing/selftests/bpf/test_sockmap.c | 1 -
3 files changed, 4 deletions(-)
diff --git a/tools/testing/selftests/bpf/test_flow_dissector.c b/tools/testing/selftests/bpf/test_flow_dissector.c
index 12b784a..01f0c63 100644
--- a/tools/testing/selftests/bpf/test_flow_dissector.c
+++ b/tools/testing/selftests/bpf/test_flow_dissector.c
@@ -16,7 +16,6 @@
#include <errno.h>
#include <linux/if_packet.h>
#include <linux/if_ether.h>
-#include <linux/if_packet.h>
#include <linux/ipv6.h>
#include <netinet/ip.h>
#include <netinet/in.h>
@@ -25,7 +24,6 @@
#include <stdbool.h>
#include <stdlib.h>
#include <stdio.h>
-#include <stdlib.h>
#include <string.h>
#include <sys/ioctl.h>
#include <sys/socket.h>
diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c
index e2b9eee..1dfef77 100644
--- a/tools/testing/selftests/bpf/test_maps.c
+++ b/tools/testing/selftests/bpf/test_maps.c
@@ -633,7 +633,6 @@ static void test_stackmap(int task, void *data)
close(fd);
}
-#include <sys/socket.h>
#include <sys/ioctl.h>
#include <arpa/inet.h>
#include <sys/select.h>
diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c
index e85a771..3845144 100644
--- a/tools/testing/selftests/bpf/test_sockmap.c
+++ b/tools/testing/selftests/bpf/test_sockmap.c
@@ -10,7 +10,6 @@
#include <unistd.h>
#include <string.h>
#include <errno.h>
-#include <sys/ioctl.h>
#include <stdbool.h>
#include <signal.h>
#include <fcntl.h>
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] selftests: bpf: remove duplicated include
2019-01-25 2:46 [PATCH -next] selftests: bpf: remove duplicated include YueHaibing
@ 2019-01-25 23:01 ` Song Liu
2019-01-28 23:25 ` Daniel Borkmann
1 sibling, 0 replies; 3+ messages in thread
From: Song Liu @ 2019-01-25 23:01 UTC (permalink / raw)
To: YueHaibing
Cc: Alexei Starovoitov, Daniel Borkmann, shuah, open list,
linux-kselftest, Networking
On Thu, Jan 24, 2019 at 6:49 PM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Remove duplicated include.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Song Liu <songliubraving@fb.com>
Thanks!
> ---
> tools/testing/selftests/bpf/test_flow_dissector.c | 2 --
> tools/testing/selftests/bpf/test_maps.c | 1 -
> tools/testing/selftests/bpf/test_sockmap.c | 1 -
> 3 files changed, 4 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/test_flow_dissector.c b/tools/testing/selftests/bpf/test_flow_dissector.c
> index 12b784a..01f0c63 100644
> --- a/tools/testing/selftests/bpf/test_flow_dissector.c
> +++ b/tools/testing/selftests/bpf/test_flow_dissector.c
> @@ -16,7 +16,6 @@
> #include <errno.h>
> #include <linux/if_packet.h>
> #include <linux/if_ether.h>
> -#include <linux/if_packet.h>
> #include <linux/ipv6.h>
> #include <netinet/ip.h>
> #include <netinet/in.h>
> @@ -25,7 +24,6 @@
> #include <stdbool.h>
> #include <stdlib.h>
> #include <stdio.h>
> -#include <stdlib.h>
> #include <string.h>
> #include <sys/ioctl.h>
> #include <sys/socket.h>
> diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c
> index e2b9eee..1dfef77 100644
> --- a/tools/testing/selftests/bpf/test_maps.c
> +++ b/tools/testing/selftests/bpf/test_maps.c
> @@ -633,7 +633,6 @@ static void test_stackmap(int task, void *data)
> close(fd);
> }
>
> -#include <sys/socket.h>
> #include <sys/ioctl.h>
> #include <arpa/inet.h>
> #include <sys/select.h>
> diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c
> index e85a771..3845144 100644
> --- a/tools/testing/selftests/bpf/test_sockmap.c
> +++ b/tools/testing/selftests/bpf/test_sockmap.c
> @@ -10,7 +10,6 @@
> #include <unistd.h>
> #include <string.h>
> #include <errno.h>
> -#include <sys/ioctl.h>
> #include <stdbool.h>
> #include <signal.h>
> #include <fcntl.h>
> --
> 2.7.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] selftests: bpf: remove duplicated include
2019-01-25 2:46 [PATCH -next] selftests: bpf: remove duplicated include YueHaibing
2019-01-25 23:01 ` Song Liu
@ 2019-01-28 23:25 ` Daniel Borkmann
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2019-01-28 23:25 UTC (permalink / raw)
To: YueHaibing, ast, shuah; +Cc: linux-kernel, linux-kselftest, netdev
On 01/25/2019 03:46 AM, YueHaibing wrote:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-28 23:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-25 2:46 [PATCH -next] selftests: bpf: remove duplicated include YueHaibing
2019-01-25 23:01 ` Song Liu
2019-01-28 23:25 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).