linux-next: Fixes tag needs some work in the drm-intel-fixes tree

linux-next: Fixes tag needs some work in the drm-intel-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

Hi all,

In commit

  0f7555121609 ("drm/i915/gvt: release shadow batch buffer and wa_ctx before destroy one workload")

Fixes tag

  Fixes: 0cce2823ed37 ("drm/i915/gvt/kvmgt:Refine error handling for prepare_execlist_workload")

has these problem(s):

  - Subject does not match target commit subject

Just some whitespace.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drm-intel-fixes tree

[Jani Nikula]

On Thu, 24 Jan 2019, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> In commit
>
>   0f7555121609 ("drm/i915/gvt: release shadow batch buffer and wa_ctx before destroy one workload")
>
> Fixes tag
>
>   Fixes: 0cce2823ed37 ("drm/i915/gvt/kvmgt:Refine error handling for prepare_execlist_workload")
>
> has these problem(s):
>
>   - Subject does not match target commit subject
>
> Just some whitespace.

Thanks for the report. The commit being referenced seems to be the right
one, though, so I don't think I'm going to force push to fix this.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center

RE: linux-next: Fixes tag needs some work in the drm-intel-fixes tree

[Li, Weinan Z]

Thank Stephen.
I am not sure about the problem. The commit id "0cce2823ed37" is just for the patch of "drm/i915/gvt: Refine error handling for prepare_execlist_workload". Is there any other problems I missed?

Regards.
-Weinan


> -----Original Message-----
> From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
> Sent: Thursday, January 24, 2019 7:33 PM
> To: Stephen Rothwell <sfr@canb.auug.org.au>; Daniel Vetter
> <daniel.vetter@ffwll.ch>; Joonas Lahtinen <joonas.lahtinen@linux.intel.com>;
> Vivi, Rodrigo <rodrigo.vivi@intel.com>; Intel Graphics
> <intel-gfx@lists.freedesktop.org>; DRI <dri-devel@lists.freedesktop.org>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>; Li, Weinan Z <weinan.z.li@intel.com>; Zhenyu
> Wang <zhenyuw@linux.intel.com>
> Subject: Re: linux-next: Fixes tag needs some work in the drm-intel-fixes tree
> 
> On Thu, 24 Jan 2019, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi all,
> >
> > In commit
> >
> >   0f7555121609 ("drm/i915/gvt: release shadow batch buffer and wa_ctx
> > before destroy one workload")
> >
> > Fixes tag
> >
> >   Fixes: 0cce2823ed37 ("drm/i915/gvt/kvmgt:Refine error handling for
> > prepare_execlist_workload")
> >
> > has these problem(s):
> >
> >   - Subject does not match target commit subject
> >
> > Just some whitespace.
> 
> Thanks for the report. The commit being referenced seems to be the right one,
> though, so I don't think I'm going to force push to fix this.
> 
> BR,
> Jani.
> 
> --
> Jani Nikula, Intel Open Source Graphics Center

Re: linux-next: Fixes tag needs some work in the drm-intel-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

Hi,

On Fri, 25 Jan 2019 01:21:26 +0000 "Li, Weinan Z" <weinan.z.li@intel.com> wrote:
>
> I am not sure about the problem. The commit id "0cce2823ed37" is just
> for the patch of "drm/i915/gvt: Refine error handling for
> prepare_execlist_workload". Is there any other problems I missed?

Its just that the subject line of that commit has a space after the
':', but the copy of that subject line in the Fixes tag omitted that
space.  This is not a big issue, my script just pointed it out.

Its not worth doing anything about it, just take a bit more care in the
future.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]