* [PATCH] wcd9335: Remove unnecessary null checks in wcd9335_set_channel_map
@ 2019-01-29 21:48 Nathan Chancellor
2019-01-31 10:53 ` Srinivas Kandagatla
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2019-01-29 21:48 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood, Srinivas Kandagatla
Cc: Vinod Koul, alsa-devel, linux-kernel, Nathan Chancellor
Clang warns:
sound/soc/codecs/wcd9335.c:2004:11: warning: address of array
'wcd->rx_chs' will always evaluate to 'true' [-Wpointer-bool-conversion]
if (wcd->rx_chs) {
~~ ~~~~~^~~~~~
sound/soc/codecs/wcd9335.c:2012:11: warning: address of array
'wcd->tx_chs' will always evaluate to 'true' [-Wpointer-bool-conversion]
if (wcd->tx_chs) {
~~ ~~~~~^~~~~~
2 warnings generated.
Fixes: 20aedafdf492 ("ASoC: wcd9335: add support to wcd9335 codec")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
sound/soc/codecs/wcd9335.c | 20 ++++++++------------
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
index 3878187bb512..981f88a5f615 100644
--- a/sound/soc/codecs/wcd9335.c
+++ b/sound/soc/codecs/wcd9335.c
@@ -2001,20 +2001,16 @@ static int wcd9335_set_channel_map(struct snd_soc_dai *dai,
return -EINVAL;
}
- if (wcd->rx_chs) {
- wcd->num_rx_port = rx_num;
- for (i = 0; i < rx_num; i++) {
- wcd->rx_chs[i].ch_num = rx_slot[i];
- INIT_LIST_HEAD(&wcd->rx_chs[i].list);
- }
+ wcd->num_rx_port = rx_num;
+ for (i = 0; i < rx_num; i++) {
+ wcd->rx_chs[i].ch_num = rx_slot[i];
+ INIT_LIST_HEAD(&wcd->rx_chs[i].list);
}
- if (wcd->tx_chs) {
- wcd->num_tx_port = tx_num;
- for (i = 0; i < tx_num; i++) {
- wcd->tx_chs[i].ch_num = tx_slot[i];
- INIT_LIST_HEAD(&wcd->tx_chs[i].list);
- }
+ wcd->num_tx_port = tx_num;
+ for (i = 0; i < tx_num; i++) {
+ wcd->tx_chs[i].ch_num = tx_slot[i];
+ INIT_LIST_HEAD(&wcd->tx_chs[i].list);
}
return 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wcd9335: Remove unnecessary null checks in wcd9335_set_channel_map
2019-01-29 21:48 [PATCH] wcd9335: Remove unnecessary null checks in wcd9335_set_channel_map Nathan Chancellor
@ 2019-01-31 10:53 ` Srinivas Kandagatla
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Kandagatla @ 2019-01-31 10:53 UTC (permalink / raw)
To: Nathan Chancellor, Mark Brown, Liam Girdwood
Cc: Vinod Koul, alsa-devel, linux-kernel
Thanks for the patch!
On 29/01/2019 21:48, Nathan Chancellor wrote:
> Clang warns:
>
> sound/soc/codecs/wcd9335.c:2004:11: warning: address of array
> 'wcd->rx_chs' will always evaluate to 'true' [-Wpointer-bool-conversion]
> if (wcd->rx_chs) {
> ~~ ~~~~~^~~~~~
> sound/soc/codecs/wcd9335.c:2012:11: warning: address of array
> 'wcd->tx_chs' will always evaluate to 'true' [-Wpointer-bool-conversion]
> if (wcd->tx_chs) {
> ~~ ~~~~~^~~~~~
> 2 warnings generated.
>
> Fixes: 20aedafdf492 ("ASoC: wcd9335: add support to wcd9335 codec")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-31 10:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29 21:48 [PATCH] wcd9335: Remove unnecessary null checks in wcd9335_set_channel_map Nathan Chancellor
2019-01-31 10:53 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).