* [PATCH] selftests: net: fix "from" match test in fib_rule_tests.sh
@ 2019-01-30 18:19 Marcelo Henrique Cerri
2019-01-30 23:19 ` David Ahern
0 siblings, 1 reply; 2+ messages in thread
From: Marcelo Henrique Cerri @ 2019-01-30 18:19 UTC (permalink / raw)
To: David S. Miller, Shuah Khan, netdev, linux-kselftest, linux-kernel
Cc: Marcelo Henrique Cerri
Fix the IPv4 address of the dummy0 interface and ensure that ip_forward
is enabled in the network space to get a valid response when checking
for routes between the gateway and other hosts.
Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
---
tools/testing/selftests/net/fib_rule_tests.sh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh
index d4cfb6a7a086..552a9784e759 100755
--- a/tools/testing/selftests/net/fib_rule_tests.sh
+++ b/tools/testing/selftests/net/fib_rule_tests.sh
@@ -54,9 +54,11 @@ setup()
$IP link add dummy0 type dummy
$IP link set dev dummy0 up
- $IP address add 198.51.100.1/24 dev dummy0
+ $IP address add 192.51.100.1/24 dev dummy0
$IP -6 address add 2001:db8:1::1/64 dev dummy0
+ ip netns exec testns sysctl -w net.ipv4.ip_forward=1
+
set +e
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests: net: fix "from" match test in fib_rule_tests.sh
2019-01-30 18:19 [PATCH] selftests: net: fix "from" match test in fib_rule_tests.sh Marcelo Henrique Cerri
@ 2019-01-30 23:19 ` David Ahern
0 siblings, 0 replies; 2+ messages in thread
From: David Ahern @ 2019-01-30 23:19 UTC (permalink / raw)
To: Marcelo Henrique Cerri, David S. Miller, Shuah Khan, netdev,
linux-kselftest, linux-kernel
On 1/30/19 11:19 AM, Marcelo Henrique Cerri wrote:
> Fix the IPv4 address of the dummy0 interface and ensure that ip_forward
> is enabled in the network space to get a valid response when checking
> for routes between the gateway and other hosts.
you need a Fixes tag and to cc the author of said commit.
>
> Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
> ---
> tools/testing/selftests/net/fib_rule_tests.sh | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh
> index d4cfb6a7a086..552a9784e759 100755
> --- a/tools/testing/selftests/net/fib_rule_tests.sh
> +++ b/tools/testing/selftests/net/fib_rule_tests.sh
> @@ -54,9 +54,11 @@ setup()
>
> $IP link add dummy0 type dummy
> $IP link set dev dummy0 up
> - $IP address add 198.51.100.1/24 dev dummy0
> + $IP address add 192.51.100.1/24 dev dummy0
> $IP -6 address add 2001:db8:1::1/64 dev dummy0
>
> + ip netns exec testns sysctl -w net.ipv4.ip_forward=1
ip_forward is not relevant for this test. It just adds routes and rules
and uses ip route get to verify; no traffic is actually genrated.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-30 23:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-30 18:19 [PATCH] selftests: net: fix "from" match test in fib_rule_tests.sh Marcelo Henrique Cerri
2019-01-30 23:19 ` David Ahern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).