From: Wolfram Sang <wsa@the-dreams.de>
To: Sowjanya Komatineni <skomatineni@nvidia.com>
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
mkarthik@nvidia.com, smohammed@nvidia.com, talho@nvidia.com,
peda@axentia.se, digetx@gmail.com, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH V18 6/6] i2c: tegra: add i2c interface timing support
Date: Mon, 11 Feb 2019 14:03:22 +0100 [thread overview]
Message-ID: <20190211130322.2kpoky3scnqnxulw@ninjato> (raw)
In-Reply-To: <1549652382-5476-6-git-send-email-skomatineni@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]
On Fri, Feb 08, 2019 at 10:59:42AM -0800, Sowjanya Komatineni wrote:
> This patch adds I2C interface timing registers support for
> proper bus rate configuration along with meeting the I2C spec
> setup and hold times based on the tuning performed on Tegra210,
> Tegra186 and Tegra194 platforms.
>
> I2C_INTERFACE_TIMING_0 register contains TLOW and THIGH field
> and Tegra I2C controller design uses them as a part of internal
> clock divisor.
>
> I2C_INTERFACE_TIMING_1 register contains the setup and hold times
> for start and stop conditions.
>
> Acked-by: Thierry Reding <treding@nvidia.com>
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> Tested-by: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
Are you aware that we also have DT bindings for various I2C timing
values? They are usually board dependent and not so much SoC dependent.
Please check here:
Documentation/devicetree/bindings/i2c/i2c.txt
(Oops, I noticed 'i2c-sda-hold-time-ns' is missing from the docs. Will
fix that ASAP)
Just saying. The patch here is fine for me. DT support could be added
later, if you want that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-11 13:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 18:59 [PATCH V18 1/6] i2c: tegra: sort all the include headers alphabetically Sowjanya Komatineni
2019-02-08 18:59 ` [PATCH V18 2/6] i2c: tegra: add bus clear Master Support Sowjanya Komatineni
2019-02-11 12:44 ` Wolfram Sang
2019-02-11 20:18 ` Sowjanya Komatineni
2019-02-08 18:59 ` [PATCH V18 3/6] i2c: tegra: fix maximum transfer size Sowjanya Komatineni
2019-02-08 18:59 ` [PATCH V18 4/6] i2c: tegra: Add DMA support Sowjanya Komatineni
2019-02-11 12:55 ` Wolfram Sang
2019-02-11 13:22 ` Dmitry Osipenko
2019-02-11 13:28 ` Wolfram Sang
2019-02-11 16:26 ` Sowjanya Komatineni
2019-02-08 18:59 ` [PATCH V18 5/6] i2c: tegra: update transfer timeout Sowjanya Komatineni
2019-02-08 18:59 ` [PATCH V18 6/6] i2c: tegra: add i2c interface timing support Sowjanya Komatineni
2019-02-11 13:03 ` Wolfram Sang [this message]
2019-02-11 16:23 ` Sowjanya Komatineni
2019-02-11 12:45 ` [PATCH V18 1/6] i2c: tegra: sort all the include headers alphabetically Wolfram Sang
2019-02-11 13:06 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211130322.2kpoky3scnqnxulw@ninjato \
--to=wsa@the-dreams.de \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkarthik@nvidia.com \
--cc=peda@axentia.se \
--cc=skomatineni@nvidia.com \
--cc=smohammed@nvidia.com \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).