* [PATCH] drm/bridge: ti-sn65dsi86: make const array static
@ 2019-02-26 16:59 ` Colin King
2019-02-27 12:20 ` Andrzej Hajda
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-02-26 16:59 UTC (permalink / raw)
To: Andrzej Hajda, Laurent Pinchart, David Airlie, Daniel Vetter, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Don't populate the const array ti_sn_bridge_supply_names on the
stack but instead make it static.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index f72ee137e5f1..4c2ca4e39be5 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -211,7 +211,7 @@ static struct ti_sn_bridge *bridge_to_ti_sn_bridge(struct drm_bridge *bridge)
static int ti_sn_bridge_parse_regulators(struct ti_sn_bridge *pdata)
{
unsigned int i;
- const char * const ti_sn_bridge_supply_names[] = {
+ static const char * const ti_sn_bridge_supply_names[] = {
"vcca", "vcc", "vccio", "vpll",
};
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/bridge: ti-sn65dsi86: make const array static
2019-02-26 16:59 ` [PATCH] drm/bridge: ti-sn65dsi86: make const array static Colin King
@ 2019-02-27 12:20 ` Andrzej Hajda
0 siblings, 0 replies; 2+ messages in thread
From: Andrzej Hajda @ 2019-02-27 12:20 UTC (permalink / raw)
To: Colin King, Laurent Pinchart, David Airlie, Daniel Vetter, dri-devel
Cc: kernel-janitors, linux-kernel
On 26.02.2019 17:59, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array ti_sn_bridge_supply_names on the
> stack but instead make it static.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index f72ee137e5f1..4c2ca4e39be5 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -211,7 +211,7 @@ static struct ti_sn_bridge *bridge_to_ti_sn_bridge(struct drm_bridge *bridge)
> static int ti_sn_bridge_parse_regulators(struct ti_sn_bridge *pdata)
> {
> unsigned int i;
> - const char * const ti_sn_bridge_supply_names[] = {
> + static const char * const ti_sn_bridge_supply_names[] = {
> "vcca", "vcc", "vccio", "vpll",
> };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-27 12:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190226165938epcas2p2aba05bf0a7b1b992ff2f71c0bfcffb6a@epcas2p2.samsung.com>
2019-02-26 16:59 ` [PATCH] drm/bridge: ti-sn65dsi86: make const array static Colin King
2019-02-27 12:20 ` Andrzej Hajda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).