linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 02/10] perf record: implement -f,--mmap-flush=<threshold> option
Date: Tue, 5 Mar 2019 13:25:41 +0100	[thread overview]
Message-ID: <20190305122541.GC16615@krava> (raw)
In-Reply-To: <3600e56e-0431-080e-9df8-e376cdea1aad@linux.intel.com>

On Fri, Mar 01, 2019 at 06:41:44PM +0300, Alexey Budankov wrote:

SNIP

> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index f3f7f3100336..9b02a68e8c23 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -334,6 +334,29 @@ static int record__aio_enabled(struct record *rec)
>  	return rec->opts.nr_cblocks > 0;
>  }
>  
> +#define MMAP_FLUSH_DEFAULT 1
> +static int record__mmap_flush_parse(const struct option *opt,
> +				    const char *str,
> +				    int unset)
> +{
> +	int mmap_len;
> +	struct record_opts *opts = (struct record_opts *)opt->value;
> +
> +	if (unset)
> +		return 0;
> +
> +	if (str)
> +		opts->mmap_flush = strtol(str, NULL, 0);
> +	if (!opts->mmap_flush)
> +		opts->mmap_flush = MMAP_FLUSH_DEFAULT;
> +
> +	mmap_len = perf_evlist__mmap_size(opts->mmap_pages);
> +	if (opts->mmap_flush > mmap_len / 4)
> +		opts->mmap_flush = mmap_len / 4;
> +

if there's point in this config option, pelase make it
configurable as the other size options we have with
the B/K/M suffixes

jirka

  reply	other threads:[~2019-03-05 12:25 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-01 15:27 [PATCH v5 00/10] perf: enable compression of record mode trace to save storage space Alexey Budankov
2019-03-01 15:41 ` [PATCH v5 02/10] perf record: implement -f,--mmap-flush=<threshold> option Alexey Budankov
2019-03-05 12:25   ` Jiri Olsa [this message]
2019-03-07  8:28     ` Alexey Budankov
2019-03-05 12:25   ` Jiri Olsa
2019-03-07  8:28     ` Alexey Budankov
2019-03-05 12:26   ` Jiri Olsa
2019-03-07  8:42     ` Alexey Budankov
2019-03-07  8:54     ` Alexey Budankov
2019-03-01 15:43 ` [PATCH v5 03/10] perf session: define bytes_transferred and bytes_compressed metrics Alexey Budankov
2019-03-05 12:26   ` Jiri Olsa
2019-03-07  8:29     ` Alexey Budankov
2019-03-11  8:19       ` Alexey Budankov
2019-03-11 12:33         ` Jiri Olsa
2019-03-11 13:41           ` Alexey Budankov
2019-03-01 15:46 ` [PATCH v5 04/10] perf record: implement COMPRESSED event record and its attributes Alexey Budankov
2019-03-01 15:52 ` [PATCH v5 06/10] perf util: introduce Zstd based streaming compression API Alexey Budankov
2019-03-05 12:26   ` Jiri Olsa
2019-03-07  8:29     ` Alexey Budankov
2019-03-01 15:58 ` [PATCH v5 07/10] perf record: implement -z,--compression_level=n option and compression Alexey Budankov
2019-03-05  0:01   ` Andi Kleen
2019-03-05  9:19     ` Alexey Budankov
2019-03-05 12:25   ` Jiri Olsa
2019-03-07  8:39     ` Alexey Budankov
2019-03-07 12:14       ` Jiri Olsa
2019-03-07 15:26         ` Alexey Budankov
2019-03-07 15:56           ` Alexey Budankov
2019-03-08 10:46           ` Jiri Olsa
2019-03-10 15:55             ` Alexey Budankov
2019-03-10 16:17             ` Alexey Budankov
2019-03-11 10:56               ` Jiri Olsa
2019-03-05 12:25   ` Jiri Olsa
2019-03-07  8:26     ` Alexey Budankov
2019-03-05 12:26   ` Jiri Olsa
2019-03-07  8:26     ` Alexey Budankov
2019-03-07 11:59       ` Jiri Olsa
2019-03-07 14:51         ` Alexey Budankov
2019-03-05 12:26   ` Jiri Olsa
2019-03-07  8:26     ` Alexey Budankov
2019-03-05 12:26   ` Jiri Olsa
2019-03-07  8:26     ` Alexey Budankov
2019-03-01 16:06 ` [PATCH v5 08/10] perf report: implement record trace decompression Alexey Budankov
2019-03-05 12:25   ` Jiri Olsa
2019-03-07  8:27     ` Alexey Budankov
2019-03-01 16:07 ` [PATCH v5 09/10] perf inject: enable COMPRESSED records decompression Alexey Budankov
2019-03-05 12:26   ` Jiri Olsa
2019-03-07  8:28     ` Alexey Budankov
2019-03-01 16:09 ` [PATCH v5 10/10] perf tests: implement Zstd comp/decomp integration test Alexey Budankov
2019-03-05 12:25   ` Jiri Olsa
2019-03-07  8:29     ` Alexey Budankov
2019-03-01 16:37 ` [PATCH v5 05/10] perf mmap: implement dedicated memory buffer for data compression Alexey Budankov
2019-03-01 16:38 ` [PATCH v5 01/10] feature: implement libzstd check, LIBZSTD_DIR and NO_LIBZSTD defines Alexey Budankov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190305122541.GC16615@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexey.budankov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).