From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 02/10] perf record: implement -f,--mmap-flush=<threshold> option
Date: Thu, 7 Mar 2019 11:28:32 +0300 [thread overview]
Message-ID: <2df92343-57d0-8e07-f637-d2415da0e52d@linux.intel.com> (raw)
In-Reply-To: <20190305122557.GF16615@krava>
On 05.03.2019 15:25, Jiri Olsa wrote:
> On Fri, Mar 01, 2019 at 06:41:44PM +0300, Alexey Budankov wrote:
>
> SNIP
>
>> static int process_synthesized_event(struct perf_tool *tool,
>> union perf_event *event,
>> struct perf_sample *sample __maybe_unused,
>> @@ -543,7 +566,8 @@ static int record__mmap_evlist(struct record *rec,
>> if (perf_evlist__mmap_ex(evlist, opts->mmap_pages,
>> opts->auxtrace_mmap_pages,
>> opts->auxtrace_snapshot_mode,
>> - opts->nr_cblocks, opts->affinity) < 0) {
>> + opts->nr_cblocks, opts->affinity,
>> + opts->mmap_flush) < 0) {
>> if (errno == EPERM) {
>> pr_err("Permission error mapping pages.\n"
>> "Consider increasing "
>> @@ -733,7 +757,7 @@ static void record__adjust_affinity(struct record *rec, struct perf_mmap *map)
>> }
>>
>> static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evlist,
>> - bool overwrite)
>> + bool overwrite, bool sync)
>> {
>> u64 bytes_written = rec->bytes_written;
>> int i;
>> @@ -756,12 +780,19 @@ static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evli
>> off = record__aio_get_pos(trace_fd);
>>
>> for (i = 0; i < evlist->nr_mmaps; i++) {
>> + u64 flush = MMAP_FLUSH_DEFAULT;
>
> hum, why does this need the initial value?
Compiler reported some warning or even error so staying on the safe side.
>
>> struct perf_mmap *map = &maps[i];
>>
>> if (map->base) {
>> record__adjust_affinity(rec, map);
>> + if (sync) {
>> + flush = map->flush;
>> + map->flush = MMAP_FLUSH_DEFAULT;
>> + }
>> if (!record__aio_enabled(rec)) {
>> if (perf_mmap__push(map, rec, record__pushfn) != 0) {
>> + if (sync)
>> + map->flush = flush;
>> rc = -1;
>> goto out;
>> }
>> @@ -774,10 +805,14 @@ static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evli
>> idx = record__aio_sync(map, false);
>> if (perf_mmap__aio_push(map, rec, idx, record__aio_pushfn, &off) != 0) {
>> record__aio_set_pos(trace_fd, off);
>> + if (sync)
>> + map->flush = flush;
>> rc = -1;
>> goto out;
>> }
>> }
>> + if (sync)
>> + map->flush = flush;
>
> is there a point to set this back in case of sync == true?
> we are going out at this point, right?
Right, but function should work independently of any external assumption.
~Alexey
>
> jirka
>
next prev parent reply other threads:[~2019-03-07 8:28 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 15:27 [PATCH v5 00/10] perf: enable compression of record mode trace to save storage space Alexey Budankov
2019-03-01 15:41 ` [PATCH v5 02/10] perf record: implement -f,--mmap-flush=<threshold> option Alexey Budankov
2019-03-05 12:25 ` Jiri Olsa
2019-03-07 8:28 ` Alexey Budankov
2019-03-05 12:25 ` Jiri Olsa
2019-03-07 8:28 ` Alexey Budankov [this message]
2019-03-05 12:26 ` Jiri Olsa
2019-03-07 8:42 ` Alexey Budankov
2019-03-07 8:54 ` Alexey Budankov
2019-03-01 15:43 ` [PATCH v5 03/10] perf session: define bytes_transferred and bytes_compressed metrics Alexey Budankov
2019-03-05 12:26 ` Jiri Olsa
2019-03-07 8:29 ` Alexey Budankov
2019-03-11 8:19 ` Alexey Budankov
2019-03-11 12:33 ` Jiri Olsa
2019-03-11 13:41 ` Alexey Budankov
2019-03-01 15:46 ` [PATCH v5 04/10] perf record: implement COMPRESSED event record and its attributes Alexey Budankov
2019-03-01 15:52 ` [PATCH v5 06/10] perf util: introduce Zstd based streaming compression API Alexey Budankov
2019-03-05 12:26 ` Jiri Olsa
2019-03-07 8:29 ` Alexey Budankov
2019-03-01 15:58 ` [PATCH v5 07/10] perf record: implement -z,--compression_level=n option and compression Alexey Budankov
2019-03-05 0:01 ` Andi Kleen
2019-03-05 9:19 ` Alexey Budankov
2019-03-05 12:25 ` Jiri Olsa
2019-03-07 8:39 ` Alexey Budankov
2019-03-07 12:14 ` Jiri Olsa
2019-03-07 15:26 ` Alexey Budankov
2019-03-07 15:56 ` Alexey Budankov
2019-03-08 10:46 ` Jiri Olsa
2019-03-10 15:55 ` Alexey Budankov
2019-03-10 16:17 ` Alexey Budankov
2019-03-11 10:56 ` Jiri Olsa
2019-03-05 12:25 ` Jiri Olsa
2019-03-07 8:26 ` Alexey Budankov
2019-03-05 12:26 ` Jiri Olsa
2019-03-07 8:26 ` Alexey Budankov
2019-03-07 11:59 ` Jiri Olsa
2019-03-07 14:51 ` Alexey Budankov
2019-03-05 12:26 ` Jiri Olsa
2019-03-07 8:26 ` Alexey Budankov
2019-03-05 12:26 ` Jiri Olsa
2019-03-07 8:26 ` Alexey Budankov
2019-03-01 16:06 ` [PATCH v5 08/10] perf report: implement record trace decompression Alexey Budankov
2019-03-05 12:25 ` Jiri Olsa
2019-03-07 8:27 ` Alexey Budankov
2019-03-01 16:07 ` [PATCH v5 09/10] perf inject: enable COMPRESSED records decompression Alexey Budankov
2019-03-05 12:26 ` Jiri Olsa
2019-03-07 8:28 ` Alexey Budankov
2019-03-01 16:09 ` [PATCH v5 10/10] perf tests: implement Zstd comp/decomp integration test Alexey Budankov
2019-03-05 12:25 ` Jiri Olsa
2019-03-07 8:29 ` Alexey Budankov
2019-03-01 16:37 ` [PATCH v5 05/10] perf mmap: implement dedicated memory buffer for data compression Alexey Budankov
2019-03-01 16:38 ` [PATCH v5 01/10] feature: implement libzstd check, LIBZSTD_DIR and NO_LIBZSTD defines Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2df92343-57d0-8e07-f637-d2415da0e52d@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).