From: Jiri Olsa <jolsa@redhat.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 03/10] perf session: define bytes_transferred and bytes_compressed metrics
Date: Mon, 11 Mar 2019 13:33:45 +0100 [thread overview]
Message-ID: <20190311123345.GD26829@krava> (raw)
In-Reply-To: <92831c18-865b-50bf-1f03-b38b63099703@linux.intel.com>
On Mon, Mar 11, 2019 at 11:19:03AM +0300, Alexey Budankov wrote:
> On 07.03.2019 11:29, Alexey Budankov wrote:
> >
> > On 05.03.2019 15:26, Jiri Olsa wrote:
> >> On Fri, Mar 01, 2019 at 06:43:28PM +0300, Alexey Budankov wrote:
> >>>
> >>> Define bytes_transferred and bytes_compressed metrics to calculate
> >>> comp_ratio=transferred/compressed in the end of the data collection.
> >>>
> >>> bytes_transferred accumulates the amount of bytes that was extracted from
> >>> the mmaped kernel buffers for compression. bytes_compressed accumulates
> >>> the amount of bytes that was received after applying compression to
> >>> move to a storage.
> >>>
> >>> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
> >>> ---
> >>> tools/perf/builtin-record.c | 8 ++++++++
> >>> tools/perf/util/env.h | 1 +
> >>> tools/perf/util/session.h | 2 ++
> >>> 3 files changed, 11 insertions(+)
> >>>
> >>> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> >>> index 9b02a68e8c23..ab121bc27c6d 100644
> >>> --- a/tools/perf/builtin-record.c
> >>> +++ b/tools/perf/builtin-record.c
> >>> @@ -1449,6 +1449,14 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
> >>> record__mmap_read_all(rec, true);
> >>> record__aio_mmap_read_sync(rec);
> >>>
> >>> + if (!quiet && rec->session->bytes_transferred && rec->session->bytes_compressed) {
> >>> + float ratio = (float)rec->session->bytes_transferred/(float)rec->session->bytes_compressed;
> >>> +
> >>> + session->header.env.comp_ratio = ratio + 0.5;
> >>
> >> what's the + 0.5 for?
> >
> > Arithmetic rounding before type cast.
> >
> >>
> >>> + fprintf(stderr, "[ perf record: Compressed %.3f MB to %.3f MB, ratio is %.3f ]\n",
> >>> + rec->session->bytes_transferred / 1024.0 / 1024.0, rec->session->bytes_compressed / 1024.0 / 1024.0, ratio);
> >>> + }
> >>> +
> >>
> >> could this be below together with the current:
> >>
> >> fprintf(stderr, "[ perf record: Captured and wrote %.3f MB %s%s%s ]\n",
> >
> > Please provide an example of what you exactly mean.
>
> It could look like this:
>
> [ perf record: Woken up 101 times to write data ]
> [ perf record: Captured and wrote 5.173 MB perf.data (714077 samples), compressed 27.241 MB to 5.160 MB, ratio is 5.279 ]
yes, maybe we don't need to repeat the original size twice:
[ perf record: Captured and wrote 5.173 MB perf.data (714077 samples), compressed (original 27.241 MB, ratio 5.279) ]
jirka
next prev parent reply other threads:[~2019-03-11 12:33 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 15:27 [PATCH v5 00/10] perf: enable compression of record mode trace to save storage space Alexey Budankov
2019-03-01 15:41 ` [PATCH v5 02/10] perf record: implement -f,--mmap-flush=<threshold> option Alexey Budankov
2019-03-05 12:25 ` Jiri Olsa
2019-03-07 8:28 ` Alexey Budankov
2019-03-05 12:25 ` Jiri Olsa
2019-03-07 8:28 ` Alexey Budankov
2019-03-05 12:26 ` Jiri Olsa
2019-03-07 8:42 ` Alexey Budankov
2019-03-07 8:54 ` Alexey Budankov
2019-03-01 15:43 ` [PATCH v5 03/10] perf session: define bytes_transferred and bytes_compressed metrics Alexey Budankov
2019-03-05 12:26 ` Jiri Olsa
2019-03-07 8:29 ` Alexey Budankov
2019-03-11 8:19 ` Alexey Budankov
2019-03-11 12:33 ` Jiri Olsa [this message]
2019-03-11 13:41 ` Alexey Budankov
2019-03-01 15:46 ` [PATCH v5 04/10] perf record: implement COMPRESSED event record and its attributes Alexey Budankov
2019-03-01 15:52 ` [PATCH v5 06/10] perf util: introduce Zstd based streaming compression API Alexey Budankov
2019-03-05 12:26 ` Jiri Olsa
2019-03-07 8:29 ` Alexey Budankov
2019-03-01 15:58 ` [PATCH v5 07/10] perf record: implement -z,--compression_level=n option and compression Alexey Budankov
2019-03-05 0:01 ` Andi Kleen
2019-03-05 9:19 ` Alexey Budankov
2019-03-05 12:25 ` Jiri Olsa
2019-03-07 8:39 ` Alexey Budankov
2019-03-07 12:14 ` Jiri Olsa
2019-03-07 15:26 ` Alexey Budankov
2019-03-07 15:56 ` Alexey Budankov
2019-03-08 10:46 ` Jiri Olsa
2019-03-10 15:55 ` Alexey Budankov
2019-03-10 16:17 ` Alexey Budankov
2019-03-11 10:56 ` Jiri Olsa
2019-03-05 12:25 ` Jiri Olsa
2019-03-07 8:26 ` Alexey Budankov
2019-03-05 12:26 ` Jiri Olsa
2019-03-07 8:26 ` Alexey Budankov
2019-03-07 11:59 ` Jiri Olsa
2019-03-07 14:51 ` Alexey Budankov
2019-03-05 12:26 ` Jiri Olsa
2019-03-07 8:26 ` Alexey Budankov
2019-03-05 12:26 ` Jiri Olsa
2019-03-07 8:26 ` Alexey Budankov
2019-03-01 16:06 ` [PATCH v5 08/10] perf report: implement record trace decompression Alexey Budankov
2019-03-05 12:25 ` Jiri Olsa
2019-03-07 8:27 ` Alexey Budankov
2019-03-01 16:07 ` [PATCH v5 09/10] perf inject: enable COMPRESSED records decompression Alexey Budankov
2019-03-05 12:26 ` Jiri Olsa
2019-03-07 8:28 ` Alexey Budankov
2019-03-01 16:09 ` [PATCH v5 10/10] perf tests: implement Zstd comp/decomp integration test Alexey Budankov
2019-03-05 12:25 ` Jiri Olsa
2019-03-07 8:29 ` Alexey Budankov
2019-03-01 16:37 ` [PATCH v5 05/10] perf mmap: implement dedicated memory buffer for data compression Alexey Budankov
2019-03-01 16:38 ` [PATCH v5 01/10] feature: implement libzstd check, LIBZSTD_DIR and NO_LIBZSTD defines Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311123345.GD26829@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).