* [PATCH] ide: hpt366: mark expected switch fall-throughs
@ 2019-01-10 16:34 Gustavo A. R. Silva
2019-03-10 18:13 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-10 16:34 UTC (permalink / raw)
To: David S. Miller; +Cc: linux-ide, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that, in this particular case, I removed the "else: "
part from the comment. As we are now using Warning level 3:
-Wimplicit-fallthrough=3, this is what GCC is expecting to
find.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/ide/hpt366.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ide/hpt366.c b/drivers/ide/hpt366.c
index 4d565b0c5a6e..0a3f9bcc8b04 100644
--- a/drivers/ide/hpt366.c
+++ b/drivers/ide/hpt366.c
@@ -574,7 +574,7 @@ static u8 hpt3xx_udma_filter(ide_drive_t *drive)
if (!HPT370_ALLOW_ATA100_5 ||
check_in_drive_list(drive, bad_ata100_5))
return ATA_UDMA4;
- /* else: fall through */
+ /* fall through */
case HPT372 :
case HPT372A:
case HPT372N:
@@ -601,7 +601,7 @@ static u8 hpt3xx_mdma_filter(ide_drive_t *drive)
case HPT374 :
if (ata_id_is_sata(drive->id))
return 0x00;
- /* else: fall through */
+ /* fall through */
default:
return 0x07;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ide: hpt366: mark expected switch fall-throughs
2019-01-10 16:34 [PATCH] ide: hpt366: mark expected switch fall-throughs Gustavo A. R. Silva
@ 2019-03-10 18:13 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2019-03-10 18:13 UTC (permalink / raw)
To: gustavo; +Cc: linux-ide, linux-kernel
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Thu, 10 Jan 2019 10:34:23 -0600
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that, in this particular case, I removed the "else: "
> part from the comment. As we are now using Warning level 3:
> -Wimplicit-fallthrough=3, this is what GCC is expecting to
> find.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ide: hpt366: mark expected switch fall-throughs
@ 2019-02-12 21:46 Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-12 21:46 UTC (permalink / raw)
To: David S. Miller; +Cc: linux-ide, linux-kernel, Gustavo A. R. Silva, Kees Cook
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/ide/hpt366.c: In function ‘hpt3xx_udma_filter’:
drivers/ide/hpt366.c:574:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (!HPT370_ALLOW_ATA100_5 ||
^
drivers/ide/hpt366.c:578:2: note: here
case HPT372 :
^~~~
drivers/ide/hpt366.c: In function ‘hpt3xx_mdma_filter’:
drivers/ide/hpt366.c:602:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (ata_id_is_sata(drive->id))
^
drivers/ide/hpt366.c:605:2: note: here
default:
^~~~~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/ide/hpt366.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ide/hpt366.c b/drivers/ide/hpt366.c
index 4d565b0c5a6e..0a3f9bcc8b04 100644
--- a/drivers/ide/hpt366.c
+++ b/drivers/ide/hpt366.c
@@ -574,7 +574,7 @@ static u8 hpt3xx_udma_filter(ide_drive_t *drive)
if (!HPT370_ALLOW_ATA100_5 ||
check_in_drive_list(drive, bad_ata100_5))
return ATA_UDMA4;
- /* else: fall through */
+ /* fall through */
case HPT372 :
case HPT372A:
case HPT372N:
@@ -601,7 +601,7 @@ static u8 hpt3xx_mdma_filter(ide_drive_t *drive)
case HPT374 :
if (ata_id_is_sata(drive->id))
return 0x00;
- /* else: fall through */
+ /* fall through */
default:
return 0x07;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-10 18:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10 16:34 [PATCH] ide: hpt366: mark expected switch fall-throughs Gustavo A. R. Silva
2019-03-10 18:13 ` David Miller
2019-02-12 21:46 Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).