* [PATCH v2 0/1] spi: spi-fsl-qspi: call spi_unregister_controller
@ 2019-03-12 10:12 Volker Haspel
2019-03-12 10:12 ` [PATCH v2 1/1] spi: spi-fsl-qspi: use devm_spi_register_controller Volker Haspel
2019-03-12 12:24 ` [PATCH v2 0/1] spi: spi-fsl-qspi: call spi_unregister_controller Mark Brown
0 siblings, 2 replies; 5+ messages in thread
From: Volker Haspel @ 2019-03-12 10:12 UTC (permalink / raw)
To: broonie, linux-kernel; +Cc: linux-spi, han.xu, volker.haspel, john.ogness
Changes since v1:
* use devm_spi_register_controller() instead of calling
spi_unregister_controller() in the remove function
Thanks
Volker
Volker Haspel (1):
spi: spi-fsl-qspi: use devm_spi_register_controller
drivers/spi/spi-fsl-qspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.11.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/1] spi: spi-fsl-qspi: use devm_spi_register_controller
2019-03-12 10:12 [PATCH v2 0/1] spi: spi-fsl-qspi: call spi_unregister_controller Volker Haspel
@ 2019-03-12 10:12 ` Volker Haspel
2019-03-13 15:39 ` Applied "spi: spi-fsl-qspi: use devm_spi_register_controller" to the spi tree Mark Brown
2019-03-14 15:54 ` Mark Brown
2019-03-12 12:24 ` [PATCH v2 0/1] spi: spi-fsl-qspi: call spi_unregister_controller Mark Brown
1 sibling, 2 replies; 5+ messages in thread
From: Volker Haspel @ 2019-03-12 10:12 UTC (permalink / raw)
To: broonie, linux-kernel; +Cc: linux-spi, han.xu, volker.haspel, john.ogness
The driver does not clearly unregister the spi controller.
Therefore calling an unbind and bind again will end up in a
Kernel crash.
The function devm_spi_register_controller will automatically
be unregister the SPI device.
Signed-off-by: Volker Haspel <volker.haspel@linutronix.de>
Signed-off-by: John Ogness <john.ogness@linutronix.de>
---
drivers/spi/spi-fsl-qspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-fsl-qspi.c b/drivers/spi/spi-fsl-qspi.c
index 6a713f78a62e..41a49b93ca60 100644
--- a/drivers/spi/spi-fsl-qspi.c
+++ b/drivers/spi/spi-fsl-qspi.c
@@ -882,7 +882,7 @@ static int fsl_qspi_probe(struct platform_device *pdev)
ctlr->dev.of_node = np;
- ret = spi_register_controller(ctlr);
+ ret = devm_spi_register_controller(dev, ctlr);
if (ret)
goto err_destroy_mutex;
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Applied "spi: spi-fsl-qspi: use devm_spi_register_controller" to the spi tree
2019-03-12 10:12 ` [PATCH v2 1/1] spi: spi-fsl-qspi: use devm_spi_register_controller Volker Haspel
@ 2019-03-13 15:39 ` Mark Brown
2019-03-14 15:54 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2019-03-13 15:39 UTC (permalink / raw)
To: Volker Haspel
Cc: John Ogness, Mark Brown, broonie, linux-kernel, linux-spi,
han.xu, volker.haspel, john.ogness, linux-spi
The patch
spi: spi-fsl-qspi: use devm_spi_register_controller
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 8fcb830a00f0980ffe38d223cdd9a4d2d24da476 Mon Sep 17 00:00:00 2001
From: Volker Haspel <volker.haspel@linutronix.de>
Date: Tue, 12 Mar 2019 11:12:03 +0100
Subject: [PATCH] spi: spi-fsl-qspi: use devm_spi_register_controller
The driver does not clearly unregister the spi controller.
Therefore calling an unbind and bind again will end up in a
Kernel crash.
The function devm_spi_register_controller will automatically
be unregister the SPI device.
Signed-off-by: Volker Haspel <volker.haspel@linutronix.de>
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-fsl-qspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-fsl-qspi.c b/drivers/spi/spi-fsl-qspi.c
index 6a713f78a62e..41a49b93ca60 100644
--- a/drivers/spi/spi-fsl-qspi.c
+++ b/drivers/spi/spi-fsl-qspi.c
@@ -882,7 +882,7 @@ static int fsl_qspi_probe(struct platform_device *pdev)
ctlr->dev.of_node = np;
- ret = spi_register_controller(ctlr);
+ ret = devm_spi_register_controller(dev, ctlr);
if (ret)
goto err_destroy_mutex;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Applied "spi: spi-fsl-qspi: use devm_spi_register_controller" to the spi tree
2019-03-12 10:12 ` [PATCH v2 1/1] spi: spi-fsl-qspi: use devm_spi_register_controller Volker Haspel
2019-03-13 15:39 ` Applied "spi: spi-fsl-qspi: use devm_spi_register_controller" to the spi tree Mark Brown
@ 2019-03-14 15:54 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2019-03-14 15:54 UTC (permalink / raw)
To: Volker Haspel
Cc: John Ogness, Mark Brown, broonie, linux-kernel, linux-spi,
han.xu, volker.haspel, john.ogness, linux-spi
The patch
spi: spi-fsl-qspi: use devm_spi_register_controller
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 8fcb830a00f0980ffe38d223cdd9a4d2d24da476 Mon Sep 17 00:00:00 2001
From: Volker Haspel <volker.haspel@linutronix.de>
Date: Tue, 12 Mar 2019 11:12:03 +0100
Subject: [PATCH] spi: spi-fsl-qspi: use devm_spi_register_controller
The driver does not clearly unregister the spi controller.
Therefore calling an unbind and bind again will end up in a
Kernel crash.
The function devm_spi_register_controller will automatically
be unregister the SPI device.
Signed-off-by: Volker Haspel <volker.haspel@linutronix.de>
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-fsl-qspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-fsl-qspi.c b/drivers/spi/spi-fsl-qspi.c
index 6a713f78a62e..41a49b93ca60 100644
--- a/drivers/spi/spi-fsl-qspi.c
+++ b/drivers/spi/spi-fsl-qspi.c
@@ -882,7 +882,7 @@ static int fsl_qspi_probe(struct platform_device *pdev)
ctlr->dev.of_node = np;
- ret = spi_register_controller(ctlr);
+ ret = devm_spi_register_controller(dev, ctlr);
if (ret)
goto err_destroy_mutex;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 0/1] spi: spi-fsl-qspi: call spi_unregister_controller
2019-03-12 10:12 [PATCH v2 0/1] spi: spi-fsl-qspi: call spi_unregister_controller Volker Haspel
2019-03-12 10:12 ` [PATCH v2 1/1] spi: spi-fsl-qspi: use devm_spi_register_controller Volker Haspel
@ 2019-03-12 12:24 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2019-03-12 12:24 UTC (permalink / raw)
To: Volker Haspel; +Cc: linux-kernel, linux-spi, han.xu, john.ogness
[-- Attachment #1: Type: text/plain, Size: 508 bytes --]
On Tue, Mar 12, 2019 at 11:12:02AM +0100, Volker Haspel wrote:
> Changes since v1:
> * use devm_spi_register_controller() instead of calling
> spi_unregister_controller() in the remove function
Please don't send cover letters for single patches, if there is anything
that needs saying put it in the changelog of the patch or after the ---
if it's administrative stuff. This reduces mail volume and ensures that
any important information is recorded in the changelog rather than being
lost.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-14 15:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-12 10:12 [PATCH v2 0/1] spi: spi-fsl-qspi: call spi_unregister_controller Volker Haspel
2019-03-12 10:12 ` [PATCH v2 1/1] spi: spi-fsl-qspi: use devm_spi_register_controller Volker Haspel
2019-03-13 15:39 ` Applied "spi: spi-fsl-qspi: use devm_spi_register_controller" to the spi tree Mark Brown
2019-03-14 15:54 ` Mark Brown
2019-03-12 12:24 ` [PATCH v2 0/1] spi: spi-fsl-qspi: call spi_unregister_controller Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).