From: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
To: Rajat Jain <rajatja@google.com>
Cc: Vishwanath Somayaji <vishwanath.somayaji@intel.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, furquan@google.com,
evgreen@google.com, rajatxjain@gmail.com,
rajneesh.bhardwaj@linux.intel.com,
srinivas.pandruvada@linux.intel.com, david.e.box@intel.com
Subject: Re: [PATCH 2/2] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure
Date: Sat, 16 Mar 2019 14:00:24 +0530 [thread overview]
Message-ID: <20190316083024.GB21812@raj-desk2.iind.intel.com> (raw)
In-Reply-To: <20190313222124.229371-2-rajatja@google.com>
On Wed, Mar 13, 2019 at 03:21:24PM -0700, Rajat Jain wrote:
> Add a module parameter which when enabled, will check on resume, if the
> last S0ix attempt was successful. If not, the driver would provide
> helpful debug information (which gets latched during the failed suspend
> attempt) to debug the S0ix failure.
+ Srinivas and David.
>
> This information is very useful to debug S0ix failures. Specially since
> the latched debug information will be lost (over-written) if the system
> attempts to go into runtime (or imminent) S0ix again after that failed
> suspend attempt.
>
> Signed-off-by: Rajat Jain <rajatja@google.com>
> ---
> drivers/platform/x86/intel_pmc_core.c | 86 +++++++++++++++++++++++++++
> drivers/platform/x86/intel_pmc_core.h | 7 +++
> 2 files changed, 93 insertions(+)
>
> diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
> index 55578d07610c..b1f4405a27ce 100644
> --- a/drivers/platform/x86/intel_pmc_core.c
> +++ b/drivers/platform/x86/intel_pmc_core.c
> @@ -20,6 +20,7 @@
> #include <linux/module.h>
> #include <linux/pci.h>
> #include <linux/platform_device.h>
> +#include <linux/suspend.h>
> #include <linux/uaccess.h>
>
> #include <asm/cpu_device_id.h>
> @@ -890,9 +891,94 @@ static int pmc_core_remove(struct platform_device *pdev)
> return 0;
> }
>
> +#ifdef CONFIG_PM_SLEEP
> +
> +static bool warn_on_s0ix_failures;
> +module_param(warn_on_s0ix_failures, bool, 0644);
> +MODULE_PARM_DESC(warn_on_s0ix_failures, "Check and warn for S0ix failures");
> +
> +static int pmc_core_suspend(struct device *dev)
> +{
> + struct pmc_dev *pmcdev = dev_get_drvdata(dev);
> +
> + /* Save PC10 and S0ix residency for checking later */
> + if (warn_on_s0ix_failures &&
> + !rdmsrl_safe(MSR_PKG_C10_RESIDENCY, &pmcdev->pc10_counter) &&
> + !pmc_core_dev_state_get(pmcdev, &pmcdev->s0ix_counter))
> + pmcdev->check_counters = true;
> + else
> + pmcdev->check_counters = false;
> +
> + return 0;
> +}
> +
> +static inline bool pc10_failed(struct pmc_dev *pmcdev)
> +{
> + u64 pc10_counter;
> +
> + if (!rdmsrl_safe(MSR_PKG_C10_RESIDENCY, &pc10_counter) &&
> + pc10_counter == pmcdev->pc10_counter)
> + return true;
> + else
> + return false;
> +}
> +
> +static inline bool s0ix_failed(struct pmc_dev *pmcdev)
> +{
> + u64 s0ix_counter;
> +
> + if (!pmc_core_dev_state_get(pmcdev, &s0ix_counter) &&
> + s0ix_counter == pmcdev->s0ix_counter)
> + return true;
> + else
> + return false;
> +}
> +
> +static int pmc_core_resume(struct device *dev)
> +{
> + struct pmc_dev *pmcdev = dev_get_drvdata(dev);
> +
> + if (!pmcdev->check_counters)
> + return 0;
> +
> + if (pc10_failed(pmcdev)) {
> + dev_info(dev, "PC10 entry had failed (PC10 cnt=0x%llx)\n",
> + pmcdev->pc10_counter);
> + } else if (s0ix_failed(pmcdev)) {
> +
> + const struct pmc_bit_map **maps = pmcdev->map->slps0_dbg_maps;
slps0_dbg feature is not available on Skylake and Kabylake. PCH IP power
gating status is available on all.
> + const struct pmc_bit_map *map;
> + int offset = pmcdev->map->slps0_dbg_offset;
> + u32 data;
> +
> + dev_warn(dev, "S0ix entry had failed (S0ix cnt=%llu)\n",
> + pmcdev->s0ix_counter);
I feel this dev_warn may be frowned upon and should be possible kept behind
something like pm_debug_messages_on though module param helps mitigate it.
> + while (*maps) {
> + map = *maps;
> + data = pmc_core_reg_read(pmcdev, offset);
> + offset += 4;
> + while (map->name) {
> + dev_warn(dev, "SLP_S0_DBG: %-32s\tState: %s\n",
> + map->name,
> + data & map->bit_mask ? "Yes" : "No");
> + ++map;
> + }
> + ++maps;
> + }
> + }
> + return 0;
> +}
> +
> +#endif
> +
> +const struct dev_pm_ops pmc_core_pm_ops = {
> + SET_LATE_SYSTEM_SLEEP_PM_OPS(pmc_core_suspend, pmc_core_resume)
> +};
> +
> static struct platform_driver pmc_core_driver = {
> .driver = {
> .name = "pmc_core",
> + .pm = &pmc_core_pm_ops
> },
> .probe = pmc_core_probe,
> .remove = pmc_core_remove,
> diff --git a/drivers/platform/x86/intel_pmc_core.h b/drivers/platform/x86/intel_pmc_core.h
> index 88d9c0653a5f..fdee5772e532 100644
> --- a/drivers/platform/x86/intel_pmc_core.h
> +++ b/drivers/platform/x86/intel_pmc_core.h
> @@ -241,6 +241,9 @@ struct pmc_reg_map {
> * @pmc_xram_read_bit: flag to indicate whether PMC XRAM shadow registers
> * used to read MPHY PG and PLL status are available
> * @mutex_lock: mutex to complete one transcation
> + * @check_counters: On resume, check if counters are getting incremented
> + * @pc10_counter: PC10 residency counter
> + * @s0ix_counter: S0ix residency (step adjusted)
> *
> * pmc_dev contains info about power management controller device.
> */
> @@ -253,6 +256,10 @@ struct pmc_dev {
> #endif /* CONFIG_DEBUG_FS */
> int pmc_xram_read_bit;
> struct mutex lock; /* generic mutex lock for PMC Core */
> +
> + bool check_counters; /* Check for counter increments on resume */
> + u64 pc10_counter;
> + u64 s0ix_counter;
> };
>
> #endif /* PMC_CORE_H */
> --
> 2.21.0.360.g471c308f928-goog
>
--
Best Regards,
Rajneesh
next prev parent reply other threads:[~2019-03-16 8:43 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 22:21 [PATCH 1/2] platform/x86: intel_pmc_core: Convert to a platform_driver Rajat Jain
2019-03-13 22:21 ` [PATCH 2/2] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-03-16 8:30 ` Rajneesh Bhardwaj [this message]
2019-03-18 15:13 ` Rajat Jain
2019-03-18 9:31 ` Somayaji, Vishwanath
2019-03-18 15:18 ` Rajat Jain
2019-03-18 16:01 ` Rajneesh Bhardwaj
2019-03-20 10:35 ` Rafael J. Wysocki
2019-03-20 19:04 ` Rajat Jain
2019-03-16 8:17 ` [PATCH 1/2] platform/x86: intel_pmc_core: Convert to a platform_driver Rajneesh Bhardwaj
2019-03-18 15:06 ` Rajat Jain
[not found] ` <3fc03e60-492a-e9b5-ac9b-caa17f8a8e27@linux.intel.com>
2019-03-23 0:30 ` Rajat Jain
2019-03-25 10:23 ` Bhardwaj, Rajneesh
2019-03-26 1:41 ` Rajat Jain
2019-03-29 3:41 ` Srinivas Pandruvada
2019-03-29 5:29 ` Rajat Jain
2019-03-29 15:53 ` Srinivas Pandruvada
2019-04-04 0:59 ` Rajat Jain
2019-03-20 1:04 ` Rajat Jain
2019-03-20 1:04 ` [PATCH 2/2] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-04-05 20:35 ` [PATCH v3 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver Rajat Jain
2019-04-05 20:35 ` [PATCH v3 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-04-08 17:02 ` Andy Shevchenko
2019-04-08 18:36 ` Rajat Jain
2019-04-08 18:41 ` Andy Shevchenko
2019-04-08 18:58 ` Rajat Jain
2019-04-08 19:33 ` Andy Shevchenko
2019-04-09 19:38 ` Rajat Jain
2019-04-05 20:35 ` [PATCH v3 3/3] platform/x86: intel_pmc_core: Instantiate pmc_core device on legacy platforms Rajat Jain
2019-04-08 17:07 ` Andy Shevchenko
2019-04-08 18:25 ` Rajat Jain
2019-04-08 18:02 ` Rajneesh Bhardwaj
2019-04-08 18:24 ` Rajat Jain
2019-04-08 16:51 ` [PATCH v3 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver Andy Shevchenko
2019-04-08 18:42 ` Rajat Jain
2019-04-08 18:44 ` Andy Shevchenko
2019-04-08 18:47 ` Rajat Jain
2019-04-11 0:31 ` [PATCH v4 " Rajat Jain
2019-04-11 0:31 ` [PATCH v4 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-04-11 0:31 ` [PATCH v4 3/3] platform/x86: intel_pmc_core: Instantiate pmc_core device on legacy platforms Rajat Jain
2019-04-11 0:37 ` [PATCH v5 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver Rajat Jain
2019-04-11 0:37 ` [PATCH v5 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-04-11 13:40 ` Andy Shevchenko
2019-04-17 23:04 ` Rajat Jain
2019-04-11 0:37 ` [PATCH v5 3/3] platform/x86: intel_pmc_core: Instantiate pmc_core device on legacy platforms Rajat Jain
2019-04-11 13:46 ` Andy Shevchenko
2019-04-17 23:05 ` Rajat Jain
2019-04-11 13:44 ` [PATCH v5 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver Andy Shevchenko
2019-04-17 23:03 ` Rajat Jain
2019-04-17 23:01 ` [PATCH v6 " Rajat Jain
2019-04-17 23:01 ` [PATCH v6 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-04-17 23:01 ` [PATCH v6 3/3] platform/x86: intel_pmc_core: Attach using APCI HID "INT33A1" Rajat Jain
2019-05-06 9:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190316083024.GB21812@raj-desk2.iind.intel.com \
--to=rajneesh.bhardwaj@intel.com \
--cc=andy@infradead.org \
--cc=david.e.box@intel.com \
--cc=dvhart@infradead.org \
--cc=evgreen@google.com \
--cc=furquan@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rajatja@google.com \
--cc=rajatxjain@gmail.com \
--cc=rajneesh.bhardwaj@linux.intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=vishwanath.somayaji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).