From: Rajat Jain <rajatja@google.com>
To: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>,
Vishwanath Somayaji <vishwanath.somayaji@intel.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Rafael J Wysocki <rafael.j.wysocki@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Rajat Jain <rajatja@google.com>,
furquan@google.com, evgreen@google.com, rajatxjain@gmail.com
Subject: [PATCH v6 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver
Date: Wed, 17 Apr 2019 16:01:53 -0700 [thread overview]
Message-ID: <20190417230155.5282-1-rajatja@google.com> (raw)
In-Reply-To: <20190313222124.229371-1-rajatja@google.com>
Convert the intel_pmc_core driver to a platform driver. There is no
functional change to the driver, or to the way the devices are
instantiated.
Signed-off-by: Rajat Jain <rajatja@google.com>
---
v6: Let the way devices are instantiated exactly the same as before this
patch (so no functional change other than converting to a platform
device). Use "intel_pmc_core" platform device (no ACPI
instantiation)
v5: Remove the gerrit ID from commit log
v4: put back the x86_match_cpu() method.
v3: Don't instantiate the platform_device. Use ACPI enumeration.
v2: Rephrase the commit log. No code changes.
drivers/platform/x86/intel_pmc_core.c | 65 +++++++++++++++++++++++----
1 file changed, 57 insertions(+), 8 deletions(-)
diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
index 9908d233305e..153e79cc4d5b 100644
--- a/drivers/platform/x86/intel_pmc_core.c
+++ b/drivers/platform/x86/intel_pmc_core.c
@@ -19,6 +19,7 @@
#include <linux/io.h>
#include <linux/module.h>
#include <linux/pci.h>
+#include <linux/platform_device.h>
#include <linux/uaccess.h>
#include <asm/cpu_device_id.h>
@@ -854,13 +855,17 @@ static const struct dmi_system_id pmc_core_dmi_table[] = {
{}
};
-static int __init pmc_core_probe(void)
+static int pmc_core_probe(struct platform_device *pdev)
{
+ static bool device_initialized;
struct pmc_dev *pmcdev = &pmc;
const struct x86_cpu_id *cpu_id;
u64 slp_s0_addr;
int err;
+ if (device_initialized)
+ return -ENODEV;
+
cpu_id = x86_match_cpu(intel_pmc_core_ids);
if (!cpu_id)
return -ENODEV;
@@ -886,30 +891,74 @@ static int __init pmc_core_probe(void)
return -ENOMEM;
mutex_init(&pmcdev->lock);
+ platform_set_drvdata(pdev, pmcdev);
pmcdev->pmc_xram_read_bit = pmc_core_check_read_lock_bit();
+ dmi_check_system(pmc_core_dmi_table);
err = pmc_core_dbgfs_register(pmcdev);
if (err < 0) {
- pr_warn(" debugfs register failed.\n");
+ dev_warn(&pdev->dev, "debugfs register failed.\n");
iounmap(pmcdev->regbase);
return err;
}
- dmi_check_system(pmc_core_dmi_table);
- pr_info(" initialized\n");
+ device_initialized = true;
+ dev_info(&pdev->dev, " initialized\n");
+
return 0;
}
-module_init(pmc_core_probe)
-static void __exit pmc_core_remove(void)
+static int pmc_core_remove(struct platform_device *pdev)
{
- struct pmc_dev *pmcdev = &pmc;
+ struct pmc_dev *pmcdev = platform_get_drvdata(pdev);
pmc_core_dbgfs_unregister(pmcdev);
+ platform_set_drvdata(pdev, NULL);
mutex_destroy(&pmcdev->lock);
iounmap(pmcdev->regbase);
+ return 0;
+}
+
+static struct platform_driver pmc_core_driver = {
+ .driver = {
+ .name = "intel_pmc_core",
+ },
+ .probe = pmc_core_probe,
+ .remove = pmc_core_remove,
+};
+
+static struct platform_device pmc_core_device = {
+ .name = "intel_pmc_core",
+};
+
+static int __init pmc_core_init(void)
+{
+ int ret;
+
+ if (!x86_match_cpu(intel_pmc_core_ids))
+ return -ENODEV;
+
+ ret = platform_driver_register(&pmc_core_driver);
+ if (ret)
+ return ret;
+
+ ret = platform_device_register(&pmc_core_device);
+ if (ret) {
+ platform_driver_unregister(&pmc_core_driver);
+ return ret;
+ }
+
+ return 0;
+}
+
+static void __exit pmc_core_exit(void)
+{
+ platform_device_unregister(&pmc_core_device);
+ platform_driver_unregister(&pmc_core_driver);
}
-module_exit(pmc_core_remove)
+
+module_init(pmc_core_init)
+module_exit(pmc_core_exit)
MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("Intel PMC Core Driver");
--
2.21.0.392.gf8f6787159e-goog
next prev parent reply other threads:[~2019-04-17 23:02 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 22:21 [PATCH 1/2] platform/x86: intel_pmc_core: Convert to a platform_driver Rajat Jain
2019-03-13 22:21 ` [PATCH 2/2] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-03-16 8:30 ` Rajneesh Bhardwaj
2019-03-18 15:13 ` Rajat Jain
2019-03-18 9:31 ` Somayaji, Vishwanath
2019-03-18 15:18 ` Rajat Jain
2019-03-18 16:01 ` Rajneesh Bhardwaj
2019-03-20 10:35 ` Rafael J. Wysocki
2019-03-20 19:04 ` Rajat Jain
2019-03-16 8:17 ` [PATCH 1/2] platform/x86: intel_pmc_core: Convert to a platform_driver Rajneesh Bhardwaj
2019-03-18 15:06 ` Rajat Jain
[not found] ` <3fc03e60-492a-e9b5-ac9b-caa17f8a8e27@linux.intel.com>
2019-03-23 0:30 ` Rajat Jain
2019-03-25 10:23 ` Bhardwaj, Rajneesh
2019-03-26 1:41 ` Rajat Jain
2019-03-29 3:41 ` Srinivas Pandruvada
2019-03-29 5:29 ` Rajat Jain
2019-03-29 15:53 ` Srinivas Pandruvada
2019-04-04 0:59 ` Rajat Jain
2019-03-20 1:04 ` Rajat Jain
2019-03-20 1:04 ` [PATCH 2/2] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-04-05 20:35 ` [PATCH v3 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver Rajat Jain
2019-04-05 20:35 ` [PATCH v3 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-04-08 17:02 ` Andy Shevchenko
2019-04-08 18:36 ` Rajat Jain
2019-04-08 18:41 ` Andy Shevchenko
2019-04-08 18:58 ` Rajat Jain
2019-04-08 19:33 ` Andy Shevchenko
2019-04-09 19:38 ` Rajat Jain
2019-04-05 20:35 ` [PATCH v3 3/3] platform/x86: intel_pmc_core: Instantiate pmc_core device on legacy platforms Rajat Jain
2019-04-08 17:07 ` Andy Shevchenko
2019-04-08 18:25 ` Rajat Jain
2019-04-08 18:02 ` Rajneesh Bhardwaj
2019-04-08 18:24 ` Rajat Jain
2019-04-08 16:51 ` [PATCH v3 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver Andy Shevchenko
2019-04-08 18:42 ` Rajat Jain
2019-04-08 18:44 ` Andy Shevchenko
2019-04-08 18:47 ` Rajat Jain
2019-04-11 0:31 ` [PATCH v4 " Rajat Jain
2019-04-11 0:31 ` [PATCH v4 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-04-11 0:31 ` [PATCH v4 3/3] platform/x86: intel_pmc_core: Instantiate pmc_core device on legacy platforms Rajat Jain
2019-04-11 0:37 ` [PATCH v5 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver Rajat Jain
2019-04-11 0:37 ` [PATCH v5 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-04-11 13:40 ` Andy Shevchenko
2019-04-17 23:04 ` Rajat Jain
2019-04-11 0:37 ` [PATCH v5 3/3] platform/x86: intel_pmc_core: Instantiate pmc_core device on legacy platforms Rajat Jain
2019-04-11 13:46 ` Andy Shevchenko
2019-04-17 23:05 ` Rajat Jain
2019-04-11 13:44 ` [PATCH v5 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver Andy Shevchenko
2019-04-17 23:03 ` Rajat Jain
2019-04-17 23:01 ` Rajat Jain [this message]
2019-04-17 23:01 ` [PATCH v6 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-04-17 23:01 ` [PATCH v6 3/3] platform/x86: intel_pmc_core: Attach using APCI HID "INT33A1" Rajat Jain
2019-05-06 9:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417230155.5282-1-rajatja@google.com \
--to=rajatja@google.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=evgreen@google.com \
--cc=furquan@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rajatxjain@gmail.com \
--cc=rajneesh.bhardwaj@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=vishwanath.somayaji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).