From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Rajat Jain <rajatja@google.com>
Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>,
Vishwanath Somayaji <vishwanath.somayaji@intel.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tomasz Wysocki <Wysocki@google.com>,
Rafael J <rafael.j.wysocki@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Furquan Shaikh <furquan@google.com>,
Evan Green <evgreen@google.com>,
Rajat Jain <rajatxjain@gmail.com>
Subject: Re: [PATCH v3 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure
Date: Mon, 8 Apr 2019 22:33:54 +0300 [thread overview]
Message-ID: <CAHp75VcU9VvV3M5jVxE6ezii7d4JtFXPG7D-0zRF_amW+bEGdQ@mail.gmail.com> (raw)
In-Reply-To: <CACK8Z6Fb603NV-CreX6mxgj=JF0VmfP0kORHZg5T8L5vOeTsQA@mail.gmail.com>
On Mon, Apr 8, 2019 at 9:58 PM Rajat Jain <rajatja@google.com> wrote:
> On Mon, Apr 8, 2019 at 11:41 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Mon, Apr 8, 2019 at 9:36 PM Rajat Jain <rajatja@google.com> wrote:
> > Instead of adding module parameter and doing these prints, perhaps
> > introduce another debugfs node.
>
> Uh, I actually did wanted to print them at the resume time in kernel
> logs, because I think this is something kernel developers would be
> responsible for debugging and thus would be great to have this
> included within the kernel logs. User space tools may differ on
> different distros and may or may not be looking for S0ix failures, and
> particularly may not dump this new debugfs attribute.
>
> The other thing is that seemingly this could also help in situations
> where debugfs is not configured?
The keywords above "developers", "debugging", so, the concept of this
driver is almost all about debugging, debugfs is not for users or esp.
user space tools.
So, I don't see any issue here with creating another node and use it
for *debugging* whenever it's needed.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-04-08 19:34 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 22:21 [PATCH 1/2] platform/x86: intel_pmc_core: Convert to a platform_driver Rajat Jain
2019-03-13 22:21 ` [PATCH 2/2] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-03-16 8:30 ` Rajneesh Bhardwaj
2019-03-18 15:13 ` Rajat Jain
2019-03-18 9:31 ` Somayaji, Vishwanath
2019-03-18 15:18 ` Rajat Jain
2019-03-18 16:01 ` Rajneesh Bhardwaj
2019-03-20 10:35 ` Rafael J. Wysocki
2019-03-20 19:04 ` Rajat Jain
2019-03-16 8:17 ` [PATCH 1/2] platform/x86: intel_pmc_core: Convert to a platform_driver Rajneesh Bhardwaj
2019-03-18 15:06 ` Rajat Jain
[not found] ` <3fc03e60-492a-e9b5-ac9b-caa17f8a8e27@linux.intel.com>
2019-03-23 0:30 ` Rajat Jain
2019-03-25 10:23 ` Bhardwaj, Rajneesh
2019-03-26 1:41 ` Rajat Jain
2019-03-29 3:41 ` Srinivas Pandruvada
2019-03-29 5:29 ` Rajat Jain
2019-03-29 15:53 ` Srinivas Pandruvada
2019-04-04 0:59 ` Rajat Jain
2019-03-20 1:04 ` Rajat Jain
2019-03-20 1:04 ` [PATCH 2/2] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-04-05 20:35 ` [PATCH v3 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver Rajat Jain
2019-04-05 20:35 ` [PATCH v3 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-04-08 17:02 ` Andy Shevchenko
2019-04-08 18:36 ` Rajat Jain
2019-04-08 18:41 ` Andy Shevchenko
2019-04-08 18:58 ` Rajat Jain
2019-04-08 19:33 ` Andy Shevchenko [this message]
2019-04-09 19:38 ` Rajat Jain
2019-04-05 20:35 ` [PATCH v3 3/3] platform/x86: intel_pmc_core: Instantiate pmc_core device on legacy platforms Rajat Jain
2019-04-08 17:07 ` Andy Shevchenko
2019-04-08 18:25 ` Rajat Jain
2019-04-08 18:02 ` Rajneesh Bhardwaj
2019-04-08 18:24 ` Rajat Jain
2019-04-08 16:51 ` [PATCH v3 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver Andy Shevchenko
2019-04-08 18:42 ` Rajat Jain
2019-04-08 18:44 ` Andy Shevchenko
2019-04-08 18:47 ` Rajat Jain
2019-04-11 0:31 ` [PATCH v4 " Rajat Jain
2019-04-11 0:31 ` [PATCH v4 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-04-11 0:31 ` [PATCH v4 3/3] platform/x86: intel_pmc_core: Instantiate pmc_core device on legacy platforms Rajat Jain
2019-04-11 0:37 ` [PATCH v5 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver Rajat Jain
2019-04-11 0:37 ` [PATCH v5 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-04-11 13:40 ` Andy Shevchenko
2019-04-17 23:04 ` Rajat Jain
2019-04-11 0:37 ` [PATCH v5 3/3] platform/x86: intel_pmc_core: Instantiate pmc_core device on legacy platforms Rajat Jain
2019-04-11 13:46 ` Andy Shevchenko
2019-04-17 23:05 ` Rajat Jain
2019-04-11 13:44 ` [PATCH v5 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver Andy Shevchenko
2019-04-17 23:03 ` Rajat Jain
2019-04-17 23:01 ` [PATCH v6 " Rajat Jain
2019-04-17 23:01 ` [PATCH v6 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure Rajat Jain
2019-04-17 23:01 ` [PATCH v6 3/3] platform/x86: intel_pmc_core: Attach using APCI HID "INT33A1" Rajat Jain
2019-05-06 9:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcU9VvV3M5jVxE6ezii7d4JtFXPG7D-0zRF_amW+bEGdQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=Wysocki@google.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=evgreen@google.com \
--cc=furquan@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rajatja@google.com \
--cc=rajatxjain@gmail.com \
--cc=rajneesh.bhardwaj@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=vishwanath.somayaji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).