* [PATCH 1/6] regulator: da9063: remove platform_data support
2019-03-18 15:47 [PATCH 0/6] mfd: da9063: remove platform_data Wolfram Sang
@ 2019-03-18 15:47 ` Wolfram Sang
2019-03-19 12:49 ` Simon Horman
2019-03-29 10:57 ` Steve Twiss
2019-03-18 15:47 ` [PATCH 2/6] input: da9063_onkey: " Wolfram Sang
` (6 subsequent siblings)
7 siblings, 2 replies; 33+ messages in thread
From: Wolfram Sang @ 2019-03-18 15:47 UTC (permalink / raw)
To: linux-kernel
Cc: linux-renesas-soc, Lee Jones, Mark Brown, Support Opensource,
Wolfram Sang, Liam Girdwood
There are no in-kernel users anymore, so remove this outdated interface.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/regulator/da9063-regulator.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
index 2b0c7a85306a..73c85039d0cf 100644
--- a/drivers/regulator/da9063-regulator.c
+++ b/drivers/regulator/da9063-regulator.c
@@ -730,7 +730,6 @@ static struct da9063_regulators_pdata *da9063_parse_regulators_dt(
static int da9063_regulator_probe(struct platform_device *pdev)
{
struct da9063 *da9063 = dev_get_drvdata(pdev->dev.parent);
- struct da9063_pdata *da9063_pdata = dev_get_platdata(da9063->dev);
struct of_regulator_match *da9063_reg_matches = NULL;
struct da9063_regulators_pdata *regl_pdata;
const struct da9063_dev_model *model;
@@ -740,11 +739,7 @@ static int da9063_regulator_probe(struct platform_device *pdev)
bool bcores_merged, bmem_bio_merged;
int id, irq, n, n_regulators, ret, val;
- regl_pdata = da9063_pdata ? da9063_pdata->regulators_pdata : NULL;
-
- if (!regl_pdata)
- regl_pdata = da9063_parse_regulators_dt(pdev,
- &da9063_reg_matches);
+ regl_pdata = da9063_parse_regulators_dt(pdev, &da9063_reg_matches);
if (IS_ERR(regl_pdata) || regl_pdata->n_regulators == 0) {
dev_err(&pdev->dev,
--
2.11.0
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [PATCH 1/6] regulator: da9063: remove platform_data support
2019-03-18 15:47 ` [PATCH 1/6] regulator: da9063: remove platform_data support Wolfram Sang
@ 2019-03-19 12:49 ` Simon Horman
2019-03-29 10:57 ` Steve Twiss
1 sibling, 0 replies; 33+ messages in thread
From: Simon Horman @ 2019-03-19 12:49 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, linux-renesas-soc, Lee Jones, Mark Brown,
Support Opensource, Liam Girdwood
On Mon, Mar 18, 2019 at 04:47:53PM +0100, Wolfram Sang wrote:
> There are no in-kernel users anymore, so remove this outdated interface.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/regulator/da9063-regulator.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
> index 2b0c7a85306a..73c85039d0cf 100644
> --- a/drivers/regulator/da9063-regulator.c
> +++ b/drivers/regulator/da9063-regulator.c
> @@ -730,7 +730,6 @@ static struct da9063_regulators_pdata *da9063_parse_regulators_dt(
> static int da9063_regulator_probe(struct platform_device *pdev)
> {
> struct da9063 *da9063 = dev_get_drvdata(pdev->dev.parent);
> - struct da9063_pdata *da9063_pdata = dev_get_platdata(da9063->dev);
> struct of_regulator_match *da9063_reg_matches = NULL;
> struct da9063_regulators_pdata *regl_pdata;
> const struct da9063_dev_model *model;
> @@ -740,11 +739,7 @@ static int da9063_regulator_probe(struct platform_device *pdev)
> bool bcores_merged, bmem_bio_merged;
> int id, irq, n, n_regulators, ret, val;
>
> - regl_pdata = da9063_pdata ? da9063_pdata->regulators_pdata : NULL;
> -
> - if (!regl_pdata)
> - regl_pdata = da9063_parse_regulators_dt(pdev,
> - &da9063_reg_matches);
> + regl_pdata = da9063_parse_regulators_dt(pdev, &da9063_reg_matches);
>
> if (IS_ERR(regl_pdata) || regl_pdata->n_regulators == 0) {
> dev_err(&pdev->dev,
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: [PATCH 1/6] regulator: da9063: remove platform_data support
2019-03-18 15:47 ` [PATCH 1/6] regulator: da9063: remove platform_data support Wolfram Sang
2019-03-19 12:49 ` Simon Horman
@ 2019-03-29 10:57 ` Steve Twiss
1 sibling, 0 replies; 33+ messages in thread
From: Steve Twiss @ 2019-03-29 10:57 UTC (permalink / raw)
To: Wolfram Sang, Mark Brown
Cc: LKML, linux-renesas-soc, Lee Jones, Support Opensource, Liam Girdwood
Hi,
On 18 March 2019 15:48, Wolfram Sang wrote:
> Subject: [PATCH 1/6] regulator: da9063: remove platform_data support
>
> There are no in-kernel users anymore, so remove this outdated interface.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/regulator/da9063-regulator.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Thanks!
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>
Regards,
Steve
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 2/6] input: da9063_onkey: remove platform_data support
2019-03-18 15:47 [PATCH 0/6] mfd: da9063: remove platform_data Wolfram Sang
2019-03-18 15:47 ` [PATCH 1/6] regulator: da9063: remove platform_data support Wolfram Sang
@ 2019-03-18 15:47 ` Wolfram Sang
2019-03-19 12:49 ` Simon Horman
2019-03-29 10:58 ` Steve Twiss
2019-03-18 15:47 ` [PATCH 3/6] mfd: da9063: " Wolfram Sang
` (5 subsequent siblings)
7 siblings, 2 replies; 33+ messages in thread
From: Wolfram Sang @ 2019-03-18 15:47 UTC (permalink / raw)
To: linux-kernel
Cc: linux-renesas-soc, Lee Jones, Mark Brown, Support Opensource,
Wolfram Sang, Dmitry Torokhov, linux-input
There are no in-kernel users anymore, so remove this outdated interface.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/input/misc/da9063_onkey.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c
index 3e9c353d82ef..e3a273c74123 100644
--- a/drivers/input/misc/da9063_onkey.c
+++ b/drivers/input/misc/da9063_onkey.c
@@ -22,7 +22,6 @@
#include <linux/regmap.h>
#include <linux/of.h>
#include <linux/mfd/da9063/core.h>
-#include <linux/mfd/da9063/pdata.h>
#include <linux/mfd/da9063/registers.h>
#include <linux/mfd/da9062/core.h>
#include <linux/mfd/da9062/registers.h>
@@ -201,8 +200,6 @@ static void da9063_cancel_poll(void *data)
static int da9063_onkey_probe(struct platform_device *pdev)
{
- struct da9063 *da9063 = dev_get_drvdata(pdev->dev.parent);
- struct da9063_pdata *pdata = dev_get_platdata(da9063->dev);
struct da9063_onkey *onkey;
const struct of_device_id *match;
int irq;
@@ -229,12 +226,8 @@ static int da9063_onkey_probe(struct platform_device *pdev)
return -ENXIO;
}
- if (pdata)
- onkey->key_power = pdata->key_power;
- else
- onkey->key_power =
- !of_property_read_bool(pdev->dev.of_node,
- "dlg,disable-key-power");
+ onkey->key_power = !of_property_read_bool(pdev->dev.of_node,
+ "dlg,disable-key-power");
onkey->input = devm_input_allocate_device(&pdev->dev);
if (!onkey->input) {
--
2.11.0
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [PATCH 2/6] input: da9063_onkey: remove platform_data support
2019-03-18 15:47 ` [PATCH 2/6] input: da9063_onkey: " Wolfram Sang
@ 2019-03-19 12:49 ` Simon Horman
2019-03-29 10:58 ` Steve Twiss
1 sibling, 0 replies; 33+ messages in thread
From: Simon Horman @ 2019-03-19 12:49 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, linux-renesas-soc, Lee Jones, Mark Brown,
Support Opensource, Dmitry Torokhov, linux-input
On Mon, Mar 18, 2019 at 04:47:54PM +0100, Wolfram Sang wrote:
> There are no in-kernel users anymore, so remove this outdated interface.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/input/misc/da9063_onkey.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c
> index 3e9c353d82ef..e3a273c74123 100644
> --- a/drivers/input/misc/da9063_onkey.c
> +++ b/drivers/input/misc/da9063_onkey.c
> @@ -22,7 +22,6 @@
> #include <linux/regmap.h>
> #include <linux/of.h>
> #include <linux/mfd/da9063/core.h>
> -#include <linux/mfd/da9063/pdata.h>
> #include <linux/mfd/da9063/registers.h>
> #include <linux/mfd/da9062/core.h>
> #include <linux/mfd/da9062/registers.h>
> @@ -201,8 +200,6 @@ static void da9063_cancel_poll(void *data)
>
> static int da9063_onkey_probe(struct platform_device *pdev)
> {
> - struct da9063 *da9063 = dev_get_drvdata(pdev->dev.parent);
> - struct da9063_pdata *pdata = dev_get_platdata(da9063->dev);
> struct da9063_onkey *onkey;
> const struct of_device_id *match;
> int irq;
> @@ -229,12 +226,8 @@ static int da9063_onkey_probe(struct platform_device *pdev)
> return -ENXIO;
> }
>
> - if (pdata)
> - onkey->key_power = pdata->key_power;
> - else
> - onkey->key_power =
> - !of_property_read_bool(pdev->dev.of_node,
> - "dlg,disable-key-power");
> + onkey->key_power = !of_property_read_bool(pdev->dev.of_node,
> + "dlg,disable-key-power");
>
> onkey->input = devm_input_allocate_device(&pdev->dev);
> if (!onkey->input) {
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: [PATCH 2/6] input: da9063_onkey: remove platform_data support
2019-03-18 15:47 ` [PATCH 2/6] input: da9063_onkey: " Wolfram Sang
2019-03-19 12:49 ` Simon Horman
@ 2019-03-29 10:58 ` Steve Twiss
2019-04-03 9:24 ` Wolfram Sang
1 sibling, 1 reply; 33+ messages in thread
From: Steve Twiss @ 2019-03-29 10:58 UTC (permalink / raw)
To: Wolfram Sang, Dmitry Torokhov
Cc: LKML, linux-renesas-soc, Lee Jones, Mark Brown,
Support Opensource, linux-input
Hi,
On 18 March 2019 15:48, Wolfram Sang wrote:
> Subject: [PATCH 2/6] input: da9063_onkey: remove platform_data support
>
> There are no in-kernel users anymore, so remove this outdated interface.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/input/misc/da9063_onkey.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
Thanks!
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>
Regards,
Steve
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/6] input: da9063_onkey: remove platform_data support
2019-03-29 10:58 ` Steve Twiss
@ 2019-04-03 9:24 ` Wolfram Sang
0 siblings, 0 replies; 33+ messages in thread
From: Wolfram Sang @ 2019-04-03 9:24 UTC (permalink / raw)
To: Steve Twiss
Cc: Wolfram Sang, Dmitry Torokhov, LKML, linux-renesas-soc,
Lee Jones, Mark Brown, Support Opensource, linux-input
[-- Attachment #1: Type: text/plain, Size: 635 bytes --]
> > Subject: [PATCH 2/6] input: da9063_onkey: remove platform_data support
> >
> > There are no in-kernel users anymore, so remove this outdated interface.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > ---
> > drivers/input/misc/da9063_onkey.c | 11 ++---------
> > 1 file changed, 2 insertions(+), 9 deletions(-)
>
> Thanks!
> Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
> Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>
Dmitry, if you are OK with the series going in via MFD, could you ack
this patch? As you see, Steve is fine with the patch and tested it, too.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 3/6] mfd: da9063: remove platform_data support
2019-03-18 15:47 [PATCH 0/6] mfd: da9063: remove platform_data Wolfram Sang
2019-03-18 15:47 ` [PATCH 1/6] regulator: da9063: remove platform_data support Wolfram Sang
2019-03-18 15:47 ` [PATCH 2/6] input: da9063_onkey: " Wolfram Sang
@ 2019-03-18 15:47 ` Wolfram Sang
2019-03-19 12:25 ` Simon Horman
` (3 more replies)
2019-03-18 15:47 ` [PATCH 4/6] regulator: da9063: move definitions out of a header into the driver Wolfram Sang
` (4 subsequent siblings)
7 siblings, 4 replies; 33+ messages in thread
From: Wolfram Sang @ 2019-03-18 15:47 UTC (permalink / raw)
To: linux-kernel
Cc: linux-renesas-soc, Lee Jones, Mark Brown, Support Opensource,
Wolfram Sang
There are no in-kernel users anymore, so remove this outdated interface.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/mfd/da9063-core.c | 20 ++------------------
drivers/mfd/da9063-i2c.c | 1 -
drivers/mfd/da9063-irq.c | 1 -
3 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/drivers/mfd/da9063-core.c b/drivers/mfd/da9063-core.c
index 6e4ce49b4405..65ca288b0c90 100644
--- a/drivers/mfd/da9063-core.c
+++ b/drivers/mfd/da9063-core.c
@@ -26,7 +26,6 @@
#include <linux/regmap.h>
#include <linux/mfd/da9063/core.h>
-#include <linux/mfd/da9063/pdata.h>
#include <linux/mfd/da9063/registers.h>
#include <linux/proc_fs.h>
@@ -165,7 +164,6 @@ static int da9063_clear_fault_log(struct da9063 *da9063)
int da9063_device_init(struct da9063 *da9063, unsigned int irq)
{
- struct da9063_pdata *pdata = da9063->dev->platform_data;
int model, variant_id, variant_code;
int ret;
@@ -173,24 +171,10 @@ int da9063_device_init(struct da9063 *da9063, unsigned int irq)
if (ret < 0)
dev_err(da9063->dev, "Cannot clear fault log\n");
- if (pdata) {
- da9063->flags = pdata->flags;
- da9063->irq_base = pdata->irq_base;
- } else {
- da9063->flags = 0;
- da9063->irq_base = -1;
- }
+ da9063->flags = 0;
+ da9063->irq_base = -1;
da9063->chip_irq = irq;
- if (pdata && pdata->init != NULL) {
- ret = pdata->init(da9063);
- if (ret != 0) {
- dev_err(da9063->dev,
- "Platform initialization failed.\n");
- return ret;
- }
- }
-
ret = regmap_read(da9063->regmap, DA9063_REG_CHIP_ID, &model);
if (ret < 0) {
dev_err(da9063->dev, "Cannot read chip model id.\n");
diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c
index 50a24b1921d0..5f707b100e69 100644
--- a/drivers/mfd/da9063-i2c.c
+++ b/drivers/mfd/da9063-i2c.c
@@ -22,7 +22,6 @@
#include <linux/mfd/core.h>
#include <linux/mfd/da9063/core.h>
-#include <linux/mfd/da9063/pdata.h>
#include <linux/mfd/da9063/registers.h>
#include <linux/of.h>
diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
index ecc0c8ce6c58..ac02c31c5802 100644
--- a/drivers/mfd/da9063-irq.c
+++ b/drivers/mfd/da9063-irq.c
@@ -19,7 +19,6 @@
#include <linux/interrupt.h>
#include <linux/regmap.h>
#include <linux/mfd/da9063/core.h>
-#include <linux/mfd/da9063/pdata.h>
#define DA9063_REG_EVENT_A_OFFSET 0
#define DA9063_REG_EVENT_B_OFFSET 1
--
2.11.0
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [PATCH 3/6] mfd: da9063: remove platform_data support
2019-03-18 15:47 ` [PATCH 3/6] mfd: da9063: " Wolfram Sang
@ 2019-03-19 12:25 ` Simon Horman
2019-03-25 20:22 ` Wolfram Sang
2019-03-19 12:49 ` Simon Horman
` (2 subsequent siblings)
3 siblings, 1 reply; 33+ messages in thread
From: Simon Horman @ 2019-03-19 12:25 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, linux-renesas-soc, Lee Jones, Mark Brown,
Support Opensource
On Mon, Mar 18, 2019 at 04:47:55PM +0100, Wolfram Sang wrote:
> There are no in-kernel users anymore, so remove this outdated interface.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/mfd/da9063-core.c | 20 ++------------------
> drivers/mfd/da9063-i2c.c | 1 -
> drivers/mfd/da9063-irq.c | 1 -
> 3 files changed, 2 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/mfd/da9063-core.c b/drivers/mfd/da9063-core.c
> index 6e4ce49b4405..65ca288b0c90 100644
> --- a/drivers/mfd/da9063-core.c
> +++ b/drivers/mfd/da9063-core.c
> @@ -26,7 +26,6 @@
> #include <linux/regmap.h>
>
> #include <linux/mfd/da9063/core.h>
> -#include <linux/mfd/da9063/pdata.h>
> #include <linux/mfd/da9063/registers.h>
>
> #include <linux/proc_fs.h>
> @@ -165,7 +164,6 @@ static int da9063_clear_fault_log(struct da9063 *da9063)
>
> int da9063_device_init(struct da9063 *da9063, unsigned int irq)
> {
> - struct da9063_pdata *pdata = da9063->dev->platform_data;
> int model, variant_id, variant_code;
> int ret;
>
> @@ -173,24 +171,10 @@ int da9063_device_init(struct da9063 *da9063, unsigned int irq)
> if (ret < 0)
> dev_err(da9063->dev, "Cannot clear fault log\n");
>
> - if (pdata) {
> - da9063->flags = pdata->flags;
> - da9063->irq_base = pdata->irq_base;
> - } else {
> - da9063->flags = 0;
> - da9063->irq_base = -1;
> - }
> + da9063->flags = 0;
> + da9063->irq_base = -1;
If the flag and irq_base fields have fixed values can
they be removed? As a follow-up?
> da9063->chip_irq = irq;
>
> - if (pdata && pdata->init != NULL) {
> - ret = pdata->init(da9063);
> - if (ret != 0) {
> - dev_err(da9063->dev,
> - "Platform initialization failed.\n");
> - return ret;
> - }
> - }
> -
> ret = regmap_read(da9063->regmap, DA9063_REG_CHIP_ID, &model);
> if (ret < 0) {
> dev_err(da9063->dev, "Cannot read chip model id.\n");
> diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c
> index 50a24b1921d0..5f707b100e69 100644
> --- a/drivers/mfd/da9063-i2c.c
> +++ b/drivers/mfd/da9063-i2c.c
> @@ -22,7 +22,6 @@
>
> #include <linux/mfd/core.h>
> #include <linux/mfd/da9063/core.h>
> -#include <linux/mfd/da9063/pdata.h>
> #include <linux/mfd/da9063/registers.h>
>
> #include <linux/of.h>
> diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
> index ecc0c8ce6c58..ac02c31c5802 100644
> --- a/drivers/mfd/da9063-irq.c
> +++ b/drivers/mfd/da9063-irq.c
> @@ -19,7 +19,6 @@
> #include <linux/interrupt.h>
> #include <linux/regmap.h>
> #include <linux/mfd/da9063/core.h>
> -#include <linux/mfd/da9063/pdata.h>
>
> #define DA9063_REG_EVENT_A_OFFSET 0
> #define DA9063_REG_EVENT_B_OFFSET 1
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 3/6] mfd: da9063: remove platform_data support
2019-03-19 12:25 ` Simon Horman
@ 2019-03-25 20:22 ` Wolfram Sang
0 siblings, 0 replies; 33+ messages in thread
From: Wolfram Sang @ 2019-03-25 20:22 UTC (permalink / raw)
To: Simon Horman
Cc: Wolfram Sang, linux-kernel, linux-renesas-soc, Lee Jones,
Mark Brown, Support Opensource
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
> > - if (pdata) {
> > - da9063->flags = pdata->flags;
> > - da9063->irq_base = pdata->irq_base;
> > - } else {
> > - da9063->flags = 0;
> > - da9063->irq_base = -1;
> > - }
> > + da9063->flags = 0;
> > + da9063->irq_base = -1;
>
> If the flag and irq_base fields have fixed values can
> they be removed? As a follow-up?
There is likely more simplification possible. But yes, it should be a
follow up patch, I think.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 3/6] mfd: da9063: remove platform_data support
2019-03-18 15:47 ` [PATCH 3/6] mfd: da9063: " Wolfram Sang
2019-03-19 12:25 ` Simon Horman
@ 2019-03-19 12:49 ` Simon Horman
2019-03-29 10:58 ` Steve Twiss
2019-04-03 8:02 ` Lee Jones
3 siblings, 0 replies; 33+ messages in thread
From: Simon Horman @ 2019-03-19 12:49 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, linux-renesas-soc, Lee Jones, Mark Brown,
Support Opensource
On Mon, Mar 18, 2019 at 04:47:55PM +0100, Wolfram Sang wrote:
> There are no in-kernel users anymore, so remove this outdated interface.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/mfd/da9063-core.c | 20 ++------------------
> drivers/mfd/da9063-i2c.c | 1 -
> drivers/mfd/da9063-irq.c | 1 -
> 3 files changed, 2 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/mfd/da9063-core.c b/drivers/mfd/da9063-core.c
> index 6e4ce49b4405..65ca288b0c90 100644
> --- a/drivers/mfd/da9063-core.c
> +++ b/drivers/mfd/da9063-core.c
> @@ -26,7 +26,6 @@
> #include <linux/regmap.h>
>
> #include <linux/mfd/da9063/core.h>
> -#include <linux/mfd/da9063/pdata.h>
> #include <linux/mfd/da9063/registers.h>
>
> #include <linux/proc_fs.h>
> @@ -165,7 +164,6 @@ static int da9063_clear_fault_log(struct da9063 *da9063)
>
> int da9063_device_init(struct da9063 *da9063, unsigned int irq)
> {
> - struct da9063_pdata *pdata = da9063->dev->platform_data;
> int model, variant_id, variant_code;
> int ret;
>
> @@ -173,24 +171,10 @@ int da9063_device_init(struct da9063 *da9063, unsigned int irq)
> if (ret < 0)
> dev_err(da9063->dev, "Cannot clear fault log\n");
>
> - if (pdata) {
> - da9063->flags = pdata->flags;
> - da9063->irq_base = pdata->irq_base;
> - } else {
> - da9063->flags = 0;
> - da9063->irq_base = -1;
> - }
> + da9063->flags = 0;
> + da9063->irq_base = -1;
> da9063->chip_irq = irq;
>
> - if (pdata && pdata->init != NULL) {
> - ret = pdata->init(da9063);
> - if (ret != 0) {
> - dev_err(da9063->dev,
> - "Platform initialization failed.\n");
> - return ret;
> - }
> - }
> -
> ret = regmap_read(da9063->regmap, DA9063_REG_CHIP_ID, &model);
> if (ret < 0) {
> dev_err(da9063->dev, "Cannot read chip model id.\n");
> diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c
> index 50a24b1921d0..5f707b100e69 100644
> --- a/drivers/mfd/da9063-i2c.c
> +++ b/drivers/mfd/da9063-i2c.c
> @@ -22,7 +22,6 @@
>
> #include <linux/mfd/core.h>
> #include <linux/mfd/da9063/core.h>
> -#include <linux/mfd/da9063/pdata.h>
> #include <linux/mfd/da9063/registers.h>
>
> #include <linux/of.h>
> diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
> index ecc0c8ce6c58..ac02c31c5802 100644
> --- a/drivers/mfd/da9063-irq.c
> +++ b/drivers/mfd/da9063-irq.c
> @@ -19,7 +19,6 @@
> #include <linux/interrupt.h>
> #include <linux/regmap.h>
> #include <linux/mfd/da9063/core.h>
> -#include <linux/mfd/da9063/pdata.h>
>
> #define DA9063_REG_EVENT_A_OFFSET 0
> #define DA9063_REG_EVENT_B_OFFSET 1
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: [PATCH 3/6] mfd: da9063: remove platform_data support
2019-03-18 15:47 ` [PATCH 3/6] mfd: da9063: " Wolfram Sang
2019-03-19 12:25 ` Simon Horman
2019-03-19 12:49 ` Simon Horman
@ 2019-03-29 10:58 ` Steve Twiss
2019-04-03 8:02 ` Lee Jones
3 siblings, 0 replies; 33+ messages in thread
From: Steve Twiss @ 2019-03-29 10:58 UTC (permalink / raw)
To: Wolfram Sang, Lee Jones
Cc: LKMLK, linux-renesas-soc, Mark Brown, Support Opensource
Hi,
On 18 March 2019 15:48, Wolfram Sang wrote:
> Subject: [PATCH 3/6] mfd: da9063: remove platform_data support
>
> There are no in-kernel users anymore, so remove this outdated interface.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/mfd/da9063-core.c | 20 ++------------------
> drivers/mfd/da9063-i2c.c | 1 -
> drivers/mfd/da9063-irq.c | 1 -
> 3 files changed, 2 insertions(+), 20 deletions(-)
Thanks!
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>
Regards,
Steve
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 3/6] mfd: da9063: remove platform_data support
2019-03-18 15:47 ` [PATCH 3/6] mfd: da9063: " Wolfram Sang
` (2 preceding siblings ...)
2019-03-29 10:58 ` Steve Twiss
@ 2019-04-03 8:02 ` Lee Jones
3 siblings, 0 replies; 33+ messages in thread
From: Lee Jones @ 2019-04-03 8:02 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, linux-renesas-soc, Mark Brown, Support Opensource
On Mon, 18 Mar 2019, Wolfram Sang wrote:
> There are no in-kernel users anymore, so remove this outdated interface.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/mfd/da9063-core.c | 20 ++------------------
> drivers/mfd/da9063-i2c.c | 1 -
> drivers/mfd/da9063-irq.c | 1 -
> 3 files changed, 2 insertions(+), 20 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 4/6] regulator: da9063: move definitions out of a header into the driver
2019-03-18 15:47 [PATCH 0/6] mfd: da9063: remove platform_data Wolfram Sang
` (2 preceding siblings ...)
2019-03-18 15:47 ` [PATCH 3/6] mfd: da9063: " Wolfram Sang
@ 2019-03-18 15:47 ` Wolfram Sang
2019-03-19 12:49 ` Simon Horman
` (2 more replies)
2019-03-18 15:47 ` [PATCH 5/6] mfd: da9063: remove leftover platform_data definitions Wolfram Sang
` (3 subsequent siblings)
7 siblings, 3 replies; 33+ messages in thread
From: Wolfram Sang @ 2019-03-18 15:47 UTC (permalink / raw)
To: linux-kernel
Cc: linux-renesas-soc, Lee Jones, Mark Brown, Support Opensource,
Wolfram Sang, Liam Girdwood
Those definitions are only used within the driver meanwhile, so put them
there.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/regulator/da9063-regulator.c | 44 +++++++++++++++++++++++++++++++-
include/linux/mfd/da9063/pdata.h | 49 ------------------------------------
2 files changed, 43 insertions(+), 50 deletions(-)
diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
index 73c85039d0cf..c05859ad63d8 100644
--- a/drivers/regulator/da9063-regulator.c
+++ b/drivers/regulator/da9063-regulator.c
@@ -25,7 +25,6 @@
#include <linux/regulator/machine.h>
#include <linux/regulator/of_regulator.h>
#include <linux/mfd/da9063/core.h>
-#include <linux/mfd/da9063/pdata.h>
#include <linux/mfd/da9063/registers.h>
@@ -34,6 +33,49 @@
REG_FIELD(_reg, __builtin_ffs((int)_mask) - 1, \
sizeof(unsigned int) * 8 - __builtin_clz((_mask)) - 1)
+/* DA9063 and DA9063L regulator IDs */
+enum {
+ /* BUCKs */
+ DA9063_ID_BCORE1,
+ DA9063_ID_BCORE2,
+ DA9063_ID_BPRO,
+ DA9063_ID_BMEM,
+ DA9063_ID_BIO,
+ DA9063_ID_BPERI,
+
+ /* BCORE1 and BCORE2 in merged mode */
+ DA9063_ID_BCORES_MERGED,
+ /* BMEM and BIO in merged mode */
+ DA9063_ID_BMEM_BIO_MERGED,
+ /* When two BUCKs are merged, they cannot be reused separately */
+
+ /* LDOs on both DA9063 and DA9063L */
+ DA9063_ID_LDO3,
+ DA9063_ID_LDO7,
+ DA9063_ID_LDO8,
+ DA9063_ID_LDO9,
+ DA9063_ID_LDO11,
+
+ /* DA9063-only LDOs */
+ DA9063_ID_LDO1,
+ DA9063_ID_LDO2,
+ DA9063_ID_LDO4,
+ DA9063_ID_LDO5,
+ DA9063_ID_LDO6,
+ DA9063_ID_LDO10,
+};
+
+/* Old regulator platform data */
+struct da9063_regulator_data {
+ int id;
+ struct regulator_init_data *initdata;
+};
+
+struct da9063_regulators_pdata {
+ unsigned int n_regulators;
+ struct da9063_regulator_data *regulator_data;
+};
+
/* Regulator capabilities and registers description */
struct da9063_regulator_info {
struct regulator_desc desc;
diff --git a/include/linux/mfd/da9063/pdata.h b/include/linux/mfd/da9063/pdata.h
index 50bed4f89c1a..21a2d107f0cf 100644
--- a/include/linux/mfd/da9063/pdata.h
+++ b/include/linux/mfd/da9063/pdata.h
@@ -16,55 +16,6 @@
#ifndef __MFD_DA9063_PDATA_H__
#define __MFD_DA9063_PDATA_H__
-#include <linux/regulator/machine.h>
-
-/*
- * Regulator configuration
- */
-/* DA9063 and DA9063L regulator IDs */
-enum {
- /* BUCKs */
- DA9063_ID_BCORE1,
- DA9063_ID_BCORE2,
- DA9063_ID_BPRO,
- DA9063_ID_BMEM,
- DA9063_ID_BIO,
- DA9063_ID_BPERI,
-
- /* BCORE1 and BCORE2 in merged mode */
- DA9063_ID_BCORES_MERGED,
- /* BMEM and BIO in merged mode */
- DA9063_ID_BMEM_BIO_MERGED,
- /* When two BUCKs are merged, they cannot be reused separately */
-
- /* LDOs on both DA9063 and DA9063L */
- DA9063_ID_LDO3,
- DA9063_ID_LDO7,
- DA9063_ID_LDO8,
- DA9063_ID_LDO9,
- DA9063_ID_LDO11,
-
- /* DA9063-only LDOs */
- DA9063_ID_LDO1,
- DA9063_ID_LDO2,
- DA9063_ID_LDO4,
- DA9063_ID_LDO5,
- DA9063_ID_LDO6,
- DA9063_ID_LDO10,
-};
-
-/* Regulators platform data */
-struct da9063_regulator_data {
- int id;
- struct regulator_init_data *initdata;
-};
-
-struct da9063_regulators_pdata {
- unsigned n_regulators;
- struct da9063_regulator_data *regulator_data;
-};
-
-
/*
* RGB LED configuration
*/
--
2.11.0
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [PATCH 4/6] regulator: da9063: move definitions out of a header into the driver
2019-03-18 15:47 ` [PATCH 4/6] regulator: da9063: move definitions out of a header into the driver Wolfram Sang
@ 2019-03-19 12:49 ` Simon Horman
2019-03-19 13:01 ` Mark Brown
2019-03-29 11:00 ` Steve Twiss
2 siblings, 0 replies; 33+ messages in thread
From: Simon Horman @ 2019-03-19 12:49 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, linux-renesas-soc, Lee Jones, Mark Brown,
Support Opensource, Liam Girdwood
On Mon, Mar 18, 2019 at 04:47:56PM +0100, Wolfram Sang wrote:
> Those definitions are only used within the driver meanwhile, so put them
> there.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/regulator/da9063-regulator.c | 44 +++++++++++++++++++++++++++++++-
> include/linux/mfd/da9063/pdata.h | 49 ------------------------------------
> 2 files changed, 43 insertions(+), 50 deletions(-)
>
> diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
> index 73c85039d0cf..c05859ad63d8 100644
> --- a/drivers/regulator/da9063-regulator.c
> +++ b/drivers/regulator/da9063-regulator.c
> @@ -25,7 +25,6 @@
> #include <linux/regulator/machine.h>
> #include <linux/regulator/of_regulator.h>
> #include <linux/mfd/da9063/core.h>
> -#include <linux/mfd/da9063/pdata.h>
> #include <linux/mfd/da9063/registers.h>
>
>
> @@ -34,6 +33,49 @@
> REG_FIELD(_reg, __builtin_ffs((int)_mask) - 1, \
> sizeof(unsigned int) * 8 - __builtin_clz((_mask)) - 1)
>
> +/* DA9063 and DA9063L regulator IDs */
> +enum {
> + /* BUCKs */
> + DA9063_ID_BCORE1,
> + DA9063_ID_BCORE2,
> + DA9063_ID_BPRO,
> + DA9063_ID_BMEM,
> + DA9063_ID_BIO,
> + DA9063_ID_BPERI,
> +
> + /* BCORE1 and BCORE2 in merged mode */
> + DA9063_ID_BCORES_MERGED,
> + /* BMEM and BIO in merged mode */
> + DA9063_ID_BMEM_BIO_MERGED,
> + /* When two BUCKs are merged, they cannot be reused separately */
> +
> + /* LDOs on both DA9063 and DA9063L */
> + DA9063_ID_LDO3,
> + DA9063_ID_LDO7,
> + DA9063_ID_LDO8,
> + DA9063_ID_LDO9,
> + DA9063_ID_LDO11,
> +
> + /* DA9063-only LDOs */
> + DA9063_ID_LDO1,
> + DA9063_ID_LDO2,
> + DA9063_ID_LDO4,
> + DA9063_ID_LDO5,
> + DA9063_ID_LDO6,
> + DA9063_ID_LDO10,
> +};
> +
> +/* Old regulator platform data */
> +struct da9063_regulator_data {
> + int id;
> + struct regulator_init_data *initdata;
> +};
> +
> +struct da9063_regulators_pdata {
> + unsigned int n_regulators;
> + struct da9063_regulator_data *regulator_data;
> +};
> +
> /* Regulator capabilities and registers description */
> struct da9063_regulator_info {
> struct regulator_desc desc;
> diff --git a/include/linux/mfd/da9063/pdata.h b/include/linux/mfd/da9063/pdata.h
> index 50bed4f89c1a..21a2d107f0cf 100644
> --- a/include/linux/mfd/da9063/pdata.h
> +++ b/include/linux/mfd/da9063/pdata.h
> @@ -16,55 +16,6 @@
> #ifndef __MFD_DA9063_PDATA_H__
> #define __MFD_DA9063_PDATA_H__
>
> -#include <linux/regulator/machine.h>
> -
> -/*
> - * Regulator configuration
> - */
> -/* DA9063 and DA9063L regulator IDs */
> -enum {
> - /* BUCKs */
> - DA9063_ID_BCORE1,
> - DA9063_ID_BCORE2,
> - DA9063_ID_BPRO,
> - DA9063_ID_BMEM,
> - DA9063_ID_BIO,
> - DA9063_ID_BPERI,
> -
> - /* BCORE1 and BCORE2 in merged mode */
> - DA9063_ID_BCORES_MERGED,
> - /* BMEM and BIO in merged mode */
> - DA9063_ID_BMEM_BIO_MERGED,
> - /* When two BUCKs are merged, they cannot be reused separately */
> -
> - /* LDOs on both DA9063 and DA9063L */
> - DA9063_ID_LDO3,
> - DA9063_ID_LDO7,
> - DA9063_ID_LDO8,
> - DA9063_ID_LDO9,
> - DA9063_ID_LDO11,
> -
> - /* DA9063-only LDOs */
> - DA9063_ID_LDO1,
> - DA9063_ID_LDO2,
> - DA9063_ID_LDO4,
> - DA9063_ID_LDO5,
> - DA9063_ID_LDO6,
> - DA9063_ID_LDO10,
> -};
> -
> -/* Regulators platform data */
> -struct da9063_regulator_data {
> - int id;
> - struct regulator_init_data *initdata;
> -};
> -
> -struct da9063_regulators_pdata {
> - unsigned n_regulators;
> - struct da9063_regulator_data *regulator_data;
> -};
> -
> -
> /*
> * RGB LED configuration
> */
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 4/6] regulator: da9063: move definitions out of a header into the driver
2019-03-18 15:47 ` [PATCH 4/6] regulator: da9063: move definitions out of a header into the driver Wolfram Sang
2019-03-19 12:49 ` Simon Horman
@ 2019-03-19 13:01 ` Mark Brown
2019-04-03 9:22 ` Wolfram Sang
2019-03-29 11:00 ` Steve Twiss
2 siblings, 1 reply; 33+ messages in thread
From: Mark Brown @ 2019-03-19 13:01 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, linux-renesas-soc, Lee Jones, Support Opensource,
Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
On Mon, Mar 18, 2019 at 04:47:56PM +0100, Wolfram Sang wrote:
> Those definitions are only used within the driver meanwhile, so put them
> there.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 4/6] regulator: da9063: move definitions out of a header into the driver
2019-03-19 13:01 ` Mark Brown
@ 2019-04-03 9:22 ` Wolfram Sang
2019-04-03 10:07 ` Mark Brown
0 siblings, 1 reply; 33+ messages in thread
From: Wolfram Sang @ 2019-04-03 9:22 UTC (permalink / raw)
To: Mark Brown
Cc: Wolfram Sang, linux-kernel, linux-renesas-soc, Lee Jones,
Support Opensource, Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
On Tue, Mar 19, 2019 at 01:01:34PM +0000, Mark Brown wrote:
> On Mon, Mar 18, 2019 at 04:47:56PM +0100, Wolfram Sang wrote:
> > Those definitions are only used within the driver meanwhile, so put them
> > there.
>
> Acked-by: Mark Brown <broonie@kernel.org>
Mark, if you are OK with all the patches going in via MFD, could you ack
the other regulator patches, too? Steve is fine with the patches and
tested them, too.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 4/6] regulator: da9063: move definitions out of a header into the driver
2019-04-03 9:22 ` Wolfram Sang
@ 2019-04-03 10:07 ` Mark Brown
0 siblings, 0 replies; 33+ messages in thread
From: Mark Brown @ 2019-04-03 10:07 UTC (permalink / raw)
To: Wolfram Sang
Cc: Wolfram Sang, linux-kernel, linux-renesas-soc, Lee Jones,
Support Opensource, Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 403 bytes --]
On Wed, Apr 03, 2019 at 11:22:30AM +0200, Wolfram Sang wrote:
> Mark, if you are OK with all the patches going in via MFD, could you ack
> the other regulator patches, too? Steve is fine with the patches and
> tested them, too.
I don't recall any more patches, sorry. Probably they're fine because
the whole series looked straightforward enough so I guess.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: [PATCH 4/6] regulator: da9063: move definitions out of a header into the driver
2019-03-18 15:47 ` [PATCH 4/6] regulator: da9063: move definitions out of a header into the driver Wolfram Sang
2019-03-19 12:49 ` Simon Horman
2019-03-19 13:01 ` Mark Brown
@ 2019-03-29 11:00 ` Steve Twiss
2 siblings, 0 replies; 33+ messages in thread
From: Steve Twiss @ 2019-03-29 11:00 UTC (permalink / raw)
To: Wolfram Sang, Mark Brown, Lee Jones
Cc: LKML, linux-renesas-soc, Support Opensource, Liam Girdwood
Hi,
On 18 March 2019 15:48, Wolfram Sang wrote:
> Subject: [PATCH 4/6] regulator: da9063: move definitions out of a header into the driver
>
> Those definitions are only used within the driver meanwhile, so put them
> there.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/regulator/da9063-regulator.c | 44
> +++++++++++++++++++++++++++++++-
> include/linux/mfd/da9063/pdata.h | 49 ------------------------------------
> 2 files changed, 43 insertions(+), 50 deletions(-)
>
> diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
Thanks!
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>
Regards,
Steve
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 5/6] mfd: da9063: remove leftover platform_data definitions
2019-03-18 15:47 [PATCH 0/6] mfd: da9063: remove platform_data Wolfram Sang
` (3 preceding siblings ...)
2019-03-18 15:47 ` [PATCH 4/6] regulator: da9063: move definitions out of a header into the driver Wolfram Sang
@ 2019-03-18 15:47 ` Wolfram Sang
2019-03-19 12:49 ` Simon Horman
` (2 more replies)
2019-03-18 15:47 ` [PATCH 6/6] regulator: da9063: platform_data is gone, depend on OF Wolfram Sang
` (2 subsequent siblings)
7 siblings, 3 replies; 33+ messages in thread
From: Wolfram Sang @ 2019-03-18 15:47 UTC (permalink / raw)
To: linux-kernel
Cc: linux-renesas-soc, Lee Jones, Mark Brown, Support Opensource,
Wolfram Sang
Not used, not needed, remove them.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
include/linux/mfd/da9063/pdata.h | 65 ----------------------------------------
1 file changed, 65 deletions(-)
delete mode 100644 include/linux/mfd/da9063/pdata.h
diff --git a/include/linux/mfd/da9063/pdata.h b/include/linux/mfd/da9063/pdata.h
deleted file mode 100644
index 21a2d107f0cf..000000000000
--- a/include/linux/mfd/da9063/pdata.h
+++ /dev/null
@@ -1,65 +0,0 @@
-/*
- * Platform configuration options for DA9063
- *
- * Copyright 2012 Dialog Semiconductor Ltd.
- *
- * Author: Michal Hajduk, Dialog Semiconductor
- * Author: Krystian Garbaciak, Dialog Semiconductor
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License as published by the
- * Free Software Foundation; either version 2 of the License, or (at your
- * option) any later version.
- *
- */
-
-#ifndef __MFD_DA9063_PDATA_H__
-#define __MFD_DA9063_PDATA_H__
-
-/*
- * RGB LED configuration
- */
-/* LED IDs for flags in struct led_info. */
-enum {
- DA9063_GPIO11_LED,
- DA9063_GPIO14_LED,
- DA9063_GPIO15_LED,
-
- DA9063_LED_NUM
-};
-#define DA9063_LED_ID_MASK 0x3
-
-/* LED polarity for flags in struct led_info. */
-#define DA9063_LED_HIGH_LEVEL_ACTIVE 0x0
-#define DA9063_LED_LOW_LEVEL_ACTIVE 0x4
-
-
-/*
- * General PMIC configuration
- */
-/* HWMON ADC channels configuration */
-#define DA9063_FLG_FORCE_IN0_MANUAL_MODE 0x0010
-#define DA9063_FLG_FORCE_IN0_AUTO_MODE 0x0020
-#define DA9063_FLG_FORCE_IN1_MANUAL_MODE 0x0040
-#define DA9063_FLG_FORCE_IN1_AUTO_MODE 0x0080
-#define DA9063_FLG_FORCE_IN2_MANUAL_MODE 0x0100
-#define DA9063_FLG_FORCE_IN2_AUTO_MODE 0x0200
-#define DA9063_FLG_FORCE_IN3_MANUAL_MODE 0x0400
-#define DA9063_FLG_FORCE_IN3_AUTO_MODE 0x0800
-
-/* Disable register caching. */
-#define DA9063_FLG_NO_CACHE 0x0008
-
-struct da9063;
-
-/* DA9063 platform data */
-struct da9063_pdata {
- int (*init)(struct da9063 *da9063);
- int irq_base;
- bool key_power;
- unsigned flags;
- struct da9063_regulators_pdata *regulators_pdata;
- struct led_platform_data *leds_pdata;
-};
-
-#endif /* __MFD_DA9063_PDATA_H__ */
--
2.11.0
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [PATCH 5/6] mfd: da9063: remove leftover platform_data definitions
2019-03-18 15:47 ` [PATCH 5/6] mfd: da9063: remove leftover platform_data definitions Wolfram Sang
@ 2019-03-19 12:49 ` Simon Horman
2019-03-29 11:00 ` Steve Twiss
2019-04-03 8:07 ` Lee Jones
2 siblings, 0 replies; 33+ messages in thread
From: Simon Horman @ 2019-03-19 12:49 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, linux-renesas-soc, Lee Jones, Mark Brown,
Support Opensource
On Mon, Mar 18, 2019 at 04:47:57PM +0100, Wolfram Sang wrote:
> Not used, not needed, remove them.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> include/linux/mfd/da9063/pdata.h | 65 ----------------------------------------
> 1 file changed, 65 deletions(-)
> delete mode 100644 include/linux/mfd/da9063/pdata.h
>
> diff --git a/include/linux/mfd/da9063/pdata.h b/include/linux/mfd/da9063/pdata.h
> deleted file mode 100644
> index 21a2d107f0cf..000000000000
> --- a/include/linux/mfd/da9063/pdata.h
> +++ /dev/null
> @@ -1,65 +0,0 @@
> -/*
> - * Platform configuration options for DA9063
> - *
> - * Copyright 2012 Dialog Semiconductor Ltd.
> - *
> - * Author: Michal Hajduk, Dialog Semiconductor
> - * Author: Krystian Garbaciak, Dialog Semiconductor
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of the GNU General Public License as published by the
> - * Free Software Foundation; either version 2 of the License, or (at your
> - * option) any later version.
> - *
> - */
> -
> -#ifndef __MFD_DA9063_PDATA_H__
> -#define __MFD_DA9063_PDATA_H__
> -
> -/*
> - * RGB LED configuration
> - */
> -/* LED IDs for flags in struct led_info. */
> -enum {
> - DA9063_GPIO11_LED,
> - DA9063_GPIO14_LED,
> - DA9063_GPIO15_LED,
> -
> - DA9063_LED_NUM
> -};
> -#define DA9063_LED_ID_MASK 0x3
> -
> -/* LED polarity for flags in struct led_info. */
> -#define DA9063_LED_HIGH_LEVEL_ACTIVE 0x0
> -#define DA9063_LED_LOW_LEVEL_ACTIVE 0x4
> -
> -
> -/*
> - * General PMIC configuration
> - */
> -/* HWMON ADC channels configuration */
> -#define DA9063_FLG_FORCE_IN0_MANUAL_MODE 0x0010
> -#define DA9063_FLG_FORCE_IN0_AUTO_MODE 0x0020
> -#define DA9063_FLG_FORCE_IN1_MANUAL_MODE 0x0040
> -#define DA9063_FLG_FORCE_IN1_AUTO_MODE 0x0080
> -#define DA9063_FLG_FORCE_IN2_MANUAL_MODE 0x0100
> -#define DA9063_FLG_FORCE_IN2_AUTO_MODE 0x0200
> -#define DA9063_FLG_FORCE_IN3_MANUAL_MODE 0x0400
> -#define DA9063_FLG_FORCE_IN3_AUTO_MODE 0x0800
> -
> -/* Disable register caching. */
> -#define DA9063_FLG_NO_CACHE 0x0008
> -
> -struct da9063;
> -
> -/* DA9063 platform data */
> -struct da9063_pdata {
> - int (*init)(struct da9063 *da9063);
> - int irq_base;
> - bool key_power;
> - unsigned flags;
> - struct da9063_regulators_pdata *regulators_pdata;
> - struct led_platform_data *leds_pdata;
> -};
> -
> -#endif /* __MFD_DA9063_PDATA_H__ */
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: [PATCH 5/6] mfd: da9063: remove leftover platform_data definitions
2019-03-18 15:47 ` [PATCH 5/6] mfd: da9063: remove leftover platform_data definitions Wolfram Sang
2019-03-19 12:49 ` Simon Horman
@ 2019-03-29 11:00 ` Steve Twiss
2019-04-03 8:07 ` Lee Jones
2 siblings, 0 replies; 33+ messages in thread
From: Steve Twiss @ 2019-03-29 11:00 UTC (permalink / raw)
To: Wolfram Sang, Lee Jones
Cc: LKML, linux-renesas-soc, Mark Brown, Support Opensource
Hi,
On 18 March 2019 15:48 Wolfram Sang wrote:
> Subject: [PATCH 5/6] mfd: da9063: remove leftover platform_data definitions
>
> Not used, not needed, remove them.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> include/linux/mfd/da9063/pdata.h | 65 ----------------------------------------
> 1 file changed, 65 deletions(-)
> delete mode 100644 include/linux/mfd/da9063/pdata.h
>
> diff --git a/include/linux/mfd/da9063/pdata.h
Thanks!
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>
Regards,
Steve
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 5/6] mfd: da9063: remove leftover platform_data definitions
2019-03-18 15:47 ` [PATCH 5/6] mfd: da9063: remove leftover platform_data definitions Wolfram Sang
2019-03-19 12:49 ` Simon Horman
2019-03-29 11:00 ` Steve Twiss
@ 2019-04-03 8:07 ` Lee Jones
2019-04-03 8:50 ` Wolfram Sang
2 siblings, 1 reply; 33+ messages in thread
From: Lee Jones @ 2019-04-03 8:07 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, linux-renesas-soc, Mark Brown, Support Opensource
On Mon, 18 Mar 2019, Wolfram Sang wrote:
> Not used, not needed, remove them.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> include/linux/mfd/da9063/pdata.h | 65 ----------------------------------------
> 1 file changed, 65 deletions(-)
> delete mode 100644 include/linux/mfd/da9063/pdata.h
Can't take this until the last user has been removed.
But for now:
For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 5/6] mfd: da9063: remove leftover platform_data definitions
2019-04-03 8:07 ` Lee Jones
@ 2019-04-03 8:50 ` Wolfram Sang
2019-04-03 9:03 ` Lee Jones
0 siblings, 1 reply; 33+ messages in thread
From: Wolfram Sang @ 2019-04-03 8:50 UTC (permalink / raw)
To: Lee Jones
Cc: Wolfram Sang, linux-kernel, linux-renesas-soc, Mark Brown,
Support Opensource
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
On Wed, Apr 03, 2019 at 09:07:58AM +0100, Lee Jones wrote:
> On Mon, 18 Mar 2019, Wolfram Sang wrote:
>
> > Not used, not needed, remove them.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > ---
> > include/linux/mfd/da9063/pdata.h | 65 ----------------------------------------
> > 1 file changed, 65 deletions(-)
> > delete mode 100644 include/linux/mfd/da9063/pdata.h
>
> Can't take this until the last user has been removed.
>
> But for now:
>
> For my own reference:
> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
As I wrote in the cover-letter, I'd vote for all patches going in via
MFD. Is that fine with you? Then I'll ping other maintainers for acks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 5/6] mfd: da9063: remove leftover platform_data definitions
2019-04-03 8:50 ` Wolfram Sang
@ 2019-04-03 9:03 ` Lee Jones
0 siblings, 0 replies; 33+ messages in thread
From: Lee Jones @ 2019-04-03 9:03 UTC (permalink / raw)
To: Wolfram Sang
Cc: Wolfram Sang, linux-kernel, linux-renesas-soc, Mark Brown,
Support Opensource
On Wed, 03 Apr 2019, Wolfram Sang wrote:
> On Wed, Apr 03, 2019 at 09:07:58AM +0100, Lee Jones wrote:
> > On Mon, 18 Mar 2019, Wolfram Sang wrote:
> >
> > > Not used, not needed, remove them.
> > >
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > ---
> > > include/linux/mfd/da9063/pdata.h | 65 ----------------------------------------
> > > 1 file changed, 65 deletions(-)
> > > delete mode 100644 include/linux/mfd/da9063/pdata.h
> >
> > Can't take this until the last user has been removed.
> >
> > But for now:
> >
> > For my own reference:
> > Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
>
> As I wrote in the cover-letter, I'd vote for all patches going in via
> MFD. Is that fine with you? Then I'll ping other maintainers for acks.
That's fine by me too.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 6/6] regulator: da9063: platform_data is gone, depend on OF
2019-03-18 15:47 [PATCH 0/6] mfd: da9063: remove platform_data Wolfram Sang
` (4 preceding siblings ...)
2019-03-18 15:47 ` [PATCH 5/6] mfd: da9063: remove leftover platform_data definitions Wolfram Sang
@ 2019-03-18 15:47 ` Wolfram Sang
2019-03-19 12:50 ` Simon Horman
2019-03-29 11:01 ` Steve Twiss
2019-03-18 16:34 ` [PATCH 0/6] mfd: da9063: remove platform_data Steve Twiss
2019-03-29 11:02 ` Steve Twiss
7 siblings, 2 replies; 33+ messages in thread
From: Wolfram Sang @ 2019-03-18 15:47 UTC (permalink / raw)
To: linux-kernel
Cc: linux-renesas-soc, Lee Jones, Mark Brown, Support Opensource,
Wolfram Sang, Liam Girdwood
With OF being the only configuration possibility left, depend on it to
simplify some code.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/regulator/Kconfig | 2 +-
drivers/regulator/da9063-regulator.c | 10 ----------
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index b7f249ee5e68..6663cd6cb96c 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -256,7 +256,7 @@ config REGULATOR_DA9062
config REGULATOR_DA9063
tristate "Dialog Semiconductor DA9063 regulators"
- depends on MFD_DA9063
+ depends on MFD_DA9063 && OF
help
Say y here to support the BUCKs and LDOs regulators found on
DA9063 PMICs.
diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
index c05859ad63d8..2eda8d985756 100644
--- a/drivers/regulator/da9063-regulator.c
+++ b/drivers/regulator/da9063-regulator.c
@@ -681,7 +681,6 @@ static const struct regulator_init_data *da9063_get_regulator_initdata(
return NULL;
}
-#ifdef CONFIG_OF
static struct of_regulator_match da9063_matches[] = {
[DA9063_ID_BCORE1] = { .name = "bcore1" },
[DA9063_ID_BCORE2] = { .name = "bcore2" },
@@ -759,15 +758,6 @@ static struct da9063_regulators_pdata *da9063_parse_regulators_dt(
*da9063_reg_matches = da9063_matches;
return pdata;
}
-#else
-static struct da9063_regulators_pdata *da9063_parse_regulators_dt(
- struct platform_device *pdev,
- struct of_regulator_match **da9063_reg_matches)
-{
- *da9063_reg_matches = NULL;
- return ERR_PTR(-ENODEV);
-}
-#endif
static int da9063_regulator_probe(struct platform_device *pdev)
{
--
2.11.0
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [PATCH 6/6] regulator: da9063: platform_data is gone, depend on OF
2019-03-18 15:47 ` [PATCH 6/6] regulator: da9063: platform_data is gone, depend on OF Wolfram Sang
@ 2019-03-19 12:50 ` Simon Horman
2019-03-29 11:01 ` Steve Twiss
1 sibling, 0 replies; 33+ messages in thread
From: Simon Horman @ 2019-03-19 12:50 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, linux-renesas-soc, Lee Jones, Mark Brown,
Support Opensource, Liam Girdwood
On Mon, Mar 18, 2019 at 04:47:58PM +0100, Wolfram Sang wrote:
> With OF being the only configuration possibility left, depend on it to
> simplify some code.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/regulator/Kconfig | 2 +-
> drivers/regulator/da9063-regulator.c | 10 ----------
> 2 files changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index b7f249ee5e68..6663cd6cb96c 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -256,7 +256,7 @@ config REGULATOR_DA9062
>
> config REGULATOR_DA9063
> tristate "Dialog Semiconductor DA9063 regulators"
> - depends on MFD_DA9063
> + depends on MFD_DA9063 && OF
> help
> Say y here to support the BUCKs and LDOs regulators found on
> DA9063 PMICs.
> diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
> index c05859ad63d8..2eda8d985756 100644
> --- a/drivers/regulator/da9063-regulator.c
> +++ b/drivers/regulator/da9063-regulator.c
> @@ -681,7 +681,6 @@ static const struct regulator_init_data *da9063_get_regulator_initdata(
> return NULL;
> }
>
> -#ifdef CONFIG_OF
> static struct of_regulator_match da9063_matches[] = {
> [DA9063_ID_BCORE1] = { .name = "bcore1" },
> [DA9063_ID_BCORE2] = { .name = "bcore2" },
> @@ -759,15 +758,6 @@ static struct da9063_regulators_pdata *da9063_parse_regulators_dt(
> *da9063_reg_matches = da9063_matches;
> return pdata;
> }
> -#else
> -static struct da9063_regulators_pdata *da9063_parse_regulators_dt(
> - struct platform_device *pdev,
> - struct of_regulator_match **da9063_reg_matches)
> -{
> - *da9063_reg_matches = NULL;
> - return ERR_PTR(-ENODEV);
> -}
> -#endif
>
> static int da9063_regulator_probe(struct platform_device *pdev)
> {
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: [PATCH 6/6] regulator: da9063: platform_data is gone, depend on OF
2019-03-18 15:47 ` [PATCH 6/6] regulator: da9063: platform_data is gone, depend on OF Wolfram Sang
2019-03-19 12:50 ` Simon Horman
@ 2019-03-29 11:01 ` Steve Twiss
1 sibling, 0 replies; 33+ messages in thread
From: Steve Twiss @ 2019-03-29 11:01 UTC (permalink / raw)
To: Wolfram Sang, Mark Brown
Cc: LKML, linux-renesas-soc, Lee Jones, Support Opensource, Liam Girdwood
Hi,
On 18 March 2019 15:48, Wolfram Sang wrote:
> Subject: [PATCH 6/6] regulator: da9063: platform_data is gone, depend on OF
>
> With OF being the only configuration possibility left, depend on it to
> simplify some code.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/regulator/Kconfig | 2 +-
> drivers/regulator/da9063-regulator.c | 10 ----------
> 2 files changed, 1 insertion(+), 11 deletions(-)
Thanks!
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>
Regards,
Steve
^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: [PATCH 0/6] mfd: da9063: remove platform_data
2019-03-18 15:47 [PATCH 0/6] mfd: da9063: remove platform_data Wolfram Sang
` (5 preceding siblings ...)
2019-03-18 15:47 ` [PATCH 6/6] regulator: da9063: platform_data is gone, depend on OF Wolfram Sang
@ 2019-03-18 16:34 ` Steve Twiss
2019-03-29 11:02 ` Steve Twiss
7 siblings, 0 replies; 33+ messages in thread
From: Steve Twiss @ 2019-03-18 16:34 UTC (permalink / raw)
To: Mark Brown, Wolfram Sang
Cc: linux-kernel, linux-renesas-soc, Lee Jones, Support Opensource,
linux-input
Hi Mark,
On 18 March 2019 15:48, Wolfram Sang wrote:
> To: linux-kernel@vger.kernel.org
> Subject: [PATCH 0/6] mfd: da9063: remove platform_data
>
> When working with this driver while debugging something else, I noticed that
> there are no in-kernel users of platform_data anymore. Removing the support
> simplifies the code and gets rid of quite some lines. The biggest refactoring
> went to the regulator driver which could maybe benefit from more
> refactorization. However, there is no in-kernel user of that driver, so no
> testing. I left it at this stage. I think the changes are still at a level
> where review and build-testing will give enough confidence.
>
> Besides the regulator thing, it was tested on a Renesas Lager board (R-Car H2).
> No regressions encountered. buildbot was happy, too.
>
> The patches are based on v5.1-rc1. I'd vote for all of them going through the
> MFD tree. Looking forward to comments!
>
> Wolfram
My regulator tests are currently broken, so I'm looking into it.
I'll read-through and test these patches as soon as I've solved the regressions.
Regards,
Steve
^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: [PATCH 0/6] mfd: da9063: remove platform_data
2019-03-18 15:47 [PATCH 0/6] mfd: da9063: remove platform_data Wolfram Sang
` (6 preceding siblings ...)
2019-03-18 16:34 ` [PATCH 0/6] mfd: da9063: remove platform_data Steve Twiss
@ 2019-03-29 11:02 ` Steve Twiss
2019-03-29 11:27 ` Wolfram Sang
2019-03-29 11:28 ` Steve Twiss
7 siblings, 2 replies; 33+ messages in thread
From: Steve Twiss @ 2019-03-29 11:02 UTC (permalink / raw)
To: Wolfram Sang, linux-kernel
Cc: linux-renesas-soc, Lee Jones, Mark Brown, Support Opensource,
linux-input
Hi,
On 18 March 2019 15:48 Wolfram Sang wrote:
> Subject: [PATCH 0/6] mfd: da9063: remove platform_data
>
> When working with this driver while debugging something else, I noticed that
> there are no in-kernel users of platform_data anymore. Removing the support
> simplifies the code and gets rid of quite some lines. The biggest refactoring
> went to the regulator driver which could maybe benefit from more
> refactorization. However, there is no in-kernel user of that driver, so no
> testing. I left it at this stage. I think the changes are still at a level
> where review and build-testing will give enough confidence.
>
> Besides the regulator thing, it was tested on a Renesas Lager board (R-Car H2).
> No regressions encountered. buildbot was happy, too.
>
> The patches are based on v5.1-rc1. I'd vote for all of them going through the
> MFD tree. Looking forward to comments!
>
> Wolfram
I've acked-by and tested-by for all the patches now. Apologies because it took
such a long time to get around to looking at this.
(For my benefit) I regression tested against v5.0 and v5.1-rc1, ok.
Thanks,
Steve
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 0/6] mfd: da9063: remove platform_data
2019-03-29 11:02 ` Steve Twiss
@ 2019-03-29 11:27 ` Wolfram Sang
2019-03-29 11:28 ` Steve Twiss
1 sibling, 0 replies; 33+ messages in thread
From: Wolfram Sang @ 2019-03-29 11:27 UTC (permalink / raw)
To: Steve Twiss
Cc: Wolfram Sang, linux-kernel, linux-renesas-soc, Lee Jones,
Mark Brown, Support Opensource, linux-input
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
> I've acked-by and tested-by for all the patches now. Apologies because it took
> such a long time to get around to looking at this.
Thanks for the testing! I think 10 days is actually quite fast :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: [PATCH 0/6] mfd: da9063: remove platform_data
2019-03-29 11:02 ` Steve Twiss
2019-03-29 11:27 ` Wolfram Sang
@ 2019-03-29 11:28 ` Steve Twiss
1 sibling, 0 replies; 33+ messages in thread
From: Steve Twiss @ 2019-03-29 11:28 UTC (permalink / raw)
To: 'Wolfram Sang', linux-kernel
Cc: linux-renesas-soc, Lee Jones, Mark Brown, Support Opensource,
linux-input
Caveat.
On 29 March 2019 11:02 Steve Twiss, wrote:
> Subject: RE: [PATCH 0/6] mfd: da9063: remove platform_data
>
[...]
>
> I've acked-by and tested-by for all the patches now. Apologies because it took
> such a long time to get around to looking at this.
>
> (For my benefit) I regression tested against v5.0 and v5.1-rc1, ok.
These were tested with two extra patches that are not in vanilla v5.0 or v5.1.-rc1.
One is in discussion and one is applied to linux-next,
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next-history.git/commit/?id=70b464918e5331e488058870fcc6821d54c4e541
E-mail threads are here:
https://lore.kernel.org/lkml/20190318163132.1BB633FBA2@swsrvapps-01.diasemi.com/
https://lore.kernel.org/lkml/20190320120604.7D99B3FBE9@swsrvapps-01.diasemi.com/
Regards,
Steve
^ permalink raw reply [flat|nested] 33+ messages in thread