* [PATCH] printk: Remove no longer used console_silent().
@ 2019-03-18 14:05 Tetsuo Handa
2019-03-18 14:34 ` Sergey Senozhatsky
0 siblings, 1 reply; 3+ messages in thread
From: Tetsuo Handa @ 2019-03-18 14:05 UTC (permalink / raw)
To: Petr Mladek, Sergey Senozhatsky; +Cc: LKML, Tetsuo Handa
console_silent() is no longer used after the removal of
arch/mn10300/kernel/mn10300-watchdog.c in Linux 4.17-rc1.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
---
include/linux/printk.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/include/linux/printk.h b/include/linux/printk.h
index d7c77ed..65b6d4f 100644
--- a/include/linux/printk.h
+++ b/include/linux/printk.h
@@ -66,11 +66,6 @@ static inline const char *printk_skip_headers(const char *buffer)
#define minimum_console_loglevel (console_printk[2])
#define default_console_loglevel (console_printk[3])
-static inline void console_silent(void)
-{
- console_loglevel = CONSOLE_LOGLEVEL_SILENT;
-}
-
static inline void console_verbose(void)
{
if (console_loglevel)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] printk: Remove no longer used console_silent().
2019-03-18 14:05 [PATCH] printk: Remove no longer used console_silent() Tetsuo Handa
@ 2019-03-18 14:34 ` Sergey Senozhatsky
2019-03-20 14:39 ` Petr Mladek
0 siblings, 1 reply; 3+ messages in thread
From: Sergey Senozhatsky @ 2019-03-18 14:34 UTC (permalink / raw)
To: Tetsuo Handa; +Cc: Petr Mladek, Sergey Senozhatsky, LKML
On (03/18/19 23:05), Tetsuo Handa wrote:
> console_silent() is no longer used after the removal of
> arch/mn10300/kernel/mn10300-watchdog.c in Linux 4.17-rc1.
[..]
> -static inline void console_silent(void)
> -{
> - console_loglevel = CONSOLE_LOGLEVEL_SILENT;
> -}
I would keep it, I guess, and would instead covert
kernel/debug/kdb/kdb_io.c: console_loglevel = CONSOLE_LOGLEVEL_SILENT
to use proper API (console_silent()).
-ss
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] printk: Remove no longer used console_silent().
2019-03-18 14:34 ` Sergey Senozhatsky
@ 2019-03-20 14:39 ` Petr Mladek
0 siblings, 0 replies; 3+ messages in thread
From: Petr Mladek @ 2019-03-20 14:39 UTC (permalink / raw)
To: Sergey Senozhatsky; +Cc: Tetsuo Handa, LKML
On Mon 2019-03-18 23:34:21, Sergey Senozhatsky wrote:
> On (03/18/19 23:05), Tetsuo Handa wrote:
> > console_silent() is no longer used after the removal of
> > arch/mn10300/kernel/mn10300-watchdog.c in Linux 4.17-rc1.
>
> [..]
>
> > -static inline void console_silent(void)
> > -{
> > - console_loglevel = CONSOLE_LOGLEVEL_SILENT;
> > -}
>
> I would keep it, I guess, and would instead covert
>
> kernel/debug/kdb/kdb_io.c: console_loglevel = CONSOLE_LOGLEVEL_SILENT
>
> to use proper API (console_silent()).
I agree with Sergey.
Best Regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-20 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-18 14:05 [PATCH] printk: Remove no longer used console_silent() Tetsuo Handa
2019-03-18 14:34 ` Sergey Senozhatsky
2019-03-20 14:39 ` Petr Mladek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).