[PATCH 1/2] dt-bindings: ARM: dts: rockchip: Add rk3288-veyron-jerry rev 10-15

[PATCH 1/2] dt-bindings: ARM: dts: rockchip: Add rk3288-veyron-jerry rev 10-15

[Douglas Anderson]

As far as I can tell/remember rev10 was originally created to support
making a SKU of jerry that had a different LCD.  rev11-rev15 were
added to give some wiggle room for future builds.  Downstream has a
separate device tree for rev10-rev15 (compared to rev3-rev7) with the
expectation that differences relating to the LCD would be accounted
for there but nothing was ever added to the rev10-rev15 making it
identical to the rev3-rev7 one.

It's likely nothing actually shipped with rev10-rev15 but they are
listed in the downstream kernel's device tree and it seems like it
should add a little safety if we match them here just in case
something actually shipped with one of these revisions and that device
will break if we don't claim support.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 0161b4a66586..864ee1fddcb0 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -160,6 +160,12 @@ properties:
 
       - description: Google Jerry (Hisense Chromebook C11 and more)
         items:
+          - const: google,veyron-jerry-rev15
+          - const: google,veyron-jerry-rev14
+          - const: google,veyron-jerry-rev13
+          - const: google,veyron-jerry-rev12
+          - const: google,veyron-jerry-rev11
+          - const: google,veyron-jerry-rev10
           - const: google,veyron-jerry-rev7
           - const: google,veyron-jerry-rev6
           - const: google,veyron-jerry-rev5
-- 
2.21.0.392.gf8f6787159e-goog

[PATCH 2/2] ARM: dts: rockchip: Add rk3288-veyron-jerry rev 10-15

[Douglas Anderson]

As far as I can tell/remember rev10 was originally created to support
making a SKU of jerry that had a different LCD.  rev11-rev15 were
added to give some wiggle room for future builds.  Downstream has a
separate device tree for rev10-rev15 (compared to rev3-rev7) with the
expectation that differences relating to the LCD would be accounted
for there but nothing was ever added to the rev10-rev15 making it
identical to the rev3-rev7 one.

It's likely nothing actually shipped with rev10-rev15 but they are
listed in the downstream kernel's device tree and it seems like it
should add a little safety if we match them here just in case
something actually shipped with one of these revisions and that device
will break if we don't claim support.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 arch/arm/boot/dts/rk3288-veyron-jerry.dts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/rk3288-veyron-jerry.dts b/arch/arm/boot/dts/rk3288-veyron-jerry.dts
index 2ba89895c33a..517c6999a978 100644
--- a/arch/arm/boot/dts/rk3288-veyron-jerry.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-jerry.dts
@@ -11,7 +11,10 @@
 
 / {
 	model = "Google Jerry";
-	compatible = "google,veyron-jerry-rev7", "google,veyron-jerry-rev6",
+	compatible = "google,veyron-jerry-rev15", "google,veyron-jerry-rev14",
+		     "google,veyron-jerry-rev13", "google,veyron-jerry-rev12",
+		     "google,veyron-jerry-rev11", "google,veyron-jerry-rev10",
+		     "google,veyron-jerry-rev7", "google,veyron-jerry-rev6",
 		     "google,veyron-jerry-rev5", "google,veyron-jerry-rev4",
 		     "google,veyron-jerry-rev3", "google,veyron-jerry",
 		     "google,veyron", "rockchip,rk3288";
-- 
2.21.0.392.gf8f6787159e-goog

Re: [PATCH 1/2] dt-bindings: ARM: dts: rockchip: Add rk3288-veyron-jerry rev 10-15

[Rob Herring]

On Fri, Mar 22, 2019 at 2:59 PM Douglas Anderson <dianders@chromium.org> wrote:
>
> As far as I can tell/remember rev10 was originally created to support
> making a SKU of jerry that had a different LCD.  rev11-rev15 were
> added to give some wiggle room for future builds.  Downstream has a
> separate device tree for rev10-rev15 (compared to rev3-rev7) with the
> expectation that differences relating to the LCD would be accounted
> for there but nothing was ever added to the rev10-rev15 making it
> identical to the rev3-rev7 one.
>
> It's likely nothing actually shipped with rev10-rev15 but they are
> listed in the downstream kernel's device tree and it seems like it
> should add a little safety if we match them here just in case
> something actually shipped with one of these revisions and that device
> will break if we don't claim support.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 1/2] dt-bindings: ARM: dts: rockchip: Add rk3288-veyron-jerry rev 10-15

[Heiko Stuebner]

Am Freitag, 22. März 2019, 20:59:23 CET schrieb Douglas Anderson:
> As far as I can tell/remember rev10 was originally created to support
> making a SKU of jerry that had a different LCD.  rev11-rev15 were
> added to give some wiggle room for future builds.  Downstream has a
> separate device tree for rev10-rev15 (compared to rev3-rev7) with the
> expectation that differences relating to the LCD would be accounted
> for there but nothing was ever added to the rev10-rev15 making it
> identical to the rev3-rev7 one.
> 
> It's likely nothing actually shipped with rev10-rev15 but they are
> listed in the downstream kernel's device tree and it seems like it
> should add a little safety if we match them here just in case
> something actually shipped with one of these revisions and that device
> will break if we don't claim support.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

applied both for 5.2

Thanks
Heiko